From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E591AA00E6 for ; Wed, 10 Jul 2019 22:40:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E0FE6322C; Wed, 10 Jul 2019 22:40:52 +0200 (CEST) Received: from mail-ot1-f67.google.com (mail-ot1-f67.google.com [209.85.210.67]) by dpdk.org (Postfix) with ESMTP id B23DE2B99 for ; Wed, 10 Jul 2019 22:40:51 +0200 (CEST) Received: by mail-ot1-f67.google.com with SMTP id j19so3560403otq.2 for ; Wed, 10 Jul 2019 13:40:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=c8qwOAJxqekh+mX07CIaQZzLbsz28X8iJrQ/CV7T6yI=; b=P3oESoSyDL1UsSZ9/8F5qKLCg6dHOuTP9KIoK8j5+X1DtxKnF8nJSUB8EuLtpLMhj2 6YJay83CgOuRrG8r/ST+Dhc2VK5fMNu3UkmbeEGKhyRChRAwrkgNXrhgNx/I/slF6Low h4gveklKq6sGaIhXxoC72ev1cWBcuREe5CJ8LL7x3tcmHy6fXhAbcjkHHF1xnDP0Kg0o jBKNiJYCD0jTeRqF9cy9f989RCKAzMrFsMBSzgZ/oL6T0y+dqoRUWKOErqVWvgMCxooh OOHhZm5YcOdvD4w+w7C6aY9C8xf+4I4TH7ppptDYq0cTZTDJAbiqkkzUzzTjngvhEDGF GrAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=c8qwOAJxqekh+mX07CIaQZzLbsz28X8iJrQ/CV7T6yI=; b=Zg8N13MM4PnVJ3ZqS8blIHclWLppZAyHI0iKK6w6tbKItUB6cCFJOL1G1Y0SWFwnBF aZMMeWD0mFKfpBkBui0KVGSU+QZJkNoEdIeSF3VWNDBpeN/iBOkhJ2i9h6L8HO4GFUPM y8igrCTDliQeh2+tXFj/2+1s4thtlkFPsXBcO7nuVeVyuDgTVX+W1PCRPYh3ANw14QZL k/Zvns3u5sT7ceEDlaMqxRDgwqiC8uqO9OB2F2L9TzIg3exB94/drHF9Jj9DxN2MLByP sJZaOJS4eLkkh1U/2ssrR1QSSHnFjaUUVLd0VyOl9Y+gyxaLWDEMcmJIlDOG7nbhCrkR xTKA== X-Gm-Message-State: APjAAAUkO0GVh1gRoufXPMo9HghiZJvJqzkGW9SMh06ZzhtZV4yMG2ZO 8JQDOY0emeOmUuC4I63n0KyULoOObaNC0JlW3Tw= X-Google-Smtp-Source: APXvYqxgQxQwAfKXsoW6nac0Uk4HnWsf0F+J/ZXLJvfYVE6hy+qGN2y8CDYzhBDcbep69zRN/djGf9R7LPAPsh2lKkM= X-Received: by 2002:a9d:7284:: with SMTP id t4mr279650otj.154.1562791250917; Wed, 10 Jul 2019 13:40:50 -0700 (PDT) MIME-Version: 1.0 References: <20190625150414.11332-1-zhouyates@gmail.com> <201907022007.x62K7LjD029770@lectura.cs.arizona.edu> In-Reply-To: From: yoursunny Date: Wed, 10 Jul 2019 16:40:40 -0400 Message-ID: To: Ferruh Yigit Cc: dev@dpdk.org, Yangchao Zhou , stephen@networkplumber.org, sodey@rbbn.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [v3] kni: fix possible kernel crash with va2pa X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ferruh I've uploaded my test case to Bug 183. You can determine whether it is a bug that should be covered by this patch, or it should be handled separately. Yours, Junxiao On Wed, Jul 10, 2019 at 4:11 PM Ferruh Yigit wrote: > > On 7/2/2019 9:07 PM, Junxiao Shi wrote: > > I am battling a related problem as reported on > > https://bugs.dpdk.org/show_bug.cgi?id=183 and this patch seems > > relevant, so I applied this patch on 196a46fab6eeb3ce2039e3bcaca80f8ba43ffc8d > > > > However, this patch does not work for me: > > with CONFIG_RTE_LIBRTE_MBUF_DEBUG enabled, kni_free_mbufs's invocation of > > rte_pktmbuf_free throws "bad mbuf pool" error. > > > > While all mbufs and segments in kni->rx_q now have physical addresses, > > the mbufs and segments placed back to kni->free_q still have (mis-)calculated > > virtual address. The pa2va function is not working properly. > > > > Consequently, userspace side is passing wrong pointer to rte_pktmbuf_free, > > so that application crashes with CONFIG_RTE_LIBRTE_MBUF_DEBUG enabled. > > > > Hi Junxiao, > > I don't see any issue in the code, and as far as I tested not seeing any issue. > > Can you please provide more information how to reproduce the issue, is it only > enabling "CONFIG_RTE_LIBRTE_MBUF_DEBUG" config? > > Thanks, > ferruh