From: "Jan Mędala" <jan@semihalf.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Jakub Palider <jpa@semihalf.com>,
Netanel Belgazal <netanel@amazon.com>,
Evgeny Schemeilin <evgenys@amazon.com>
Subject: Re: [dpdk-dev] [PATCH] net/ena: fix icc compile error
Date: Tue, 19 Jul 2016 13:34:19 +0200 [thread overview]
Message-ID: <CANw_3ZdR77Jfv9xNS4EcR9hDsax67jF5YcOoqZbfqHjd_j73ww@mail.gmail.com> (raw)
In-Reply-To: <578E056B.6060006@intel.com>
Ferruh,
Actually we can stay with this patch. It's ok.
Acked-by: Jan Medala <jan@semihalf.com>
Jan
2016-07-19 12:48 GMT+02:00 Ferruh Yigit <ferruh.yigit@intel.com>:
> On 7/19/2016 10:33 AM, Ferruh Yigit wrote:
> > compile error:
> > CC ena_com.o
> > .../drivers/net/ena/base/ena_com.c(346):
> > error #3656: variable "dev_node" may be used before its value is set
> > ENA_MEM_ALLOC_COHERENT_NODE(ena_dev->dmadev,
> > ^
> >
> > .../drivers/net/ena/base/ena_com.c(399):
> > error #3656: variable "prev_node" may be used before its value is set
> > ENA_MEM_ALLOC_COHERENT_NODE(ena_dev->dmadev,
> > ^
> >
> > Fixes: 3d3edc265fc8 ("net/ena: make coherent memory allocation
> NUMA-aware")
> >
> > Reported-by: Eoin Breen <eoin.breen@intel.com>
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Self-Nack
> I wasn't aware Jan is already working on this and has a patch. We can
> drop this one.
>
> Thanks,
> ferruh
>
>
next prev parent reply other threads:[~2016-07-19 11:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-19 9:33 Ferruh Yigit
2016-07-19 10:48 ` Ferruh Yigit
2016-07-19 11:34 ` Jan Mędala [this message]
2016-07-21 22:39 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANw_3ZdR77Jfv9xNS4EcR9hDsax67jF5YcOoqZbfqHjd_j73ww@mail.gmail.com \
--to=jan@semihalf.com \
--cc=dev@dpdk.org \
--cc=evgenys@amazon.com \
--cc=ferruh.yigit@intel.com \
--cc=jpa@semihalf.com \
--cc=netanel@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).