From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <jan@semihalf.com>
Received: from mail-vk0-f52.google.com (mail-vk0-f52.google.com
[209.85.213.52]) by dpdk.org (Postfix) with ESMTP id 31827F94
for <dev@dpdk.org>; Tue, 19 Jul 2016 13:34:21 +0200 (CEST)
Received: by mail-vk0-f52.google.com with SMTP id w127so20187182vkh.2
for <dev@dpdk.org>; Tue, 19 Jul 2016 04:34:21 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=semihalf-com.20150623.gappssmtp.com; s=20150623;
h=mime-version:in-reply-to:references:from:date:message-id:subject:to
:cc; bh=6KgWsHhfsC0k0zf9DYEaMdmOAmjJO9XoSkVFobpUgww=;
b=dB+uDdM9DGsLAQ0HepwiOFNRuCJ8LxSHDSRJS+jr4wb273X7wXoDXBrRKxDQWdJFOw
4kNITLnuiYSuAitfUMYzjMsRuGtLYhgrRtLIaGHJbdWzcWJq69xNquFhWCFzg4U8L2x7
1fBqDvzvWhyl301RTi5tJG0JJkzWly8N9qp87RtEIhGtwcE+cC1JGEeLo5ZLoqClxD/z
gXHV/qx8kXBJLbvSNb+DHfQDMp39wpnYQtYnSsx/Jx/JxCz13gW0FCOpO2UG6l6bP7D2
YwhQvqtRxx/IPtxHzsekqwYnAzc/ryZx0sqfSpIUBbCwoKpMVSr9Gz9ptt3ARJ3JLzS2
SQrw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20130820;
h=x-gm-message-state:mime-version:in-reply-to:references:from:date
:message-id:subject:to:cc;
bh=6KgWsHhfsC0k0zf9DYEaMdmOAmjJO9XoSkVFobpUgww=;
b=j/v0Ymd8YnF/KX6k3G8aiwcEeE119D2X+lAekqn10Z8iJITKcMPCdcxBbysPsFfxkL
aW7fwRwD3naKQz2+oKAfIYS3E0iidu9xDmFrbwKQtfupzH8nVGfjqqso2yYTs/mRUFEe
RGiJtCtJgDT3/zG3hSpisfN+LXEeEiVjIN6DR9IhAsU1A1uPWx9OG/YdMOIKGEgIKG4d
PRjlrbM0fx+LWkSl/HKorSMcGm7NZfgMJy7VQTR3lXe2BEZebYPc+hfQcrcV6vn5WJnT
GEZIDW/5q4xwGsOn7E75nGX55zsZ4bV9u9XFTVCfkHFAqCQhNe7v/5zXgmIQpY5K400q
Z11A==
X-Gm-Message-State: ALyK8tJhmDsqitJgz59kfw0kAsCKult8JwPBkCv29ruFKXeVkR6/BpcwMa7cPjID0aPHuWHmqbB7FrYFy7nWyw==
X-Received: by 10.159.34.55 with SMTP id 52mr19548445uad.2.1468928060551; Tue,
19 Jul 2016 04:34:20 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.159.36.54 with HTTP; Tue, 19 Jul 2016 04:34:19 -0700 (PDT)
In-Reply-To: <578E056B.6060006@intel.com>
References: <1468920783-27136-1-git-send-email-ferruh.yigit@intel.com>
<578E056B.6060006@intel.com>
From: =?UTF-8?Q?Jan_M=C4=99dala?= <jan@semihalf.com>
Date: Tue, 19 Jul 2016 13:34:19 +0200
Message-ID: <CANw_3ZdR77Jfv9xNS4EcR9hDsax67jF5YcOoqZbfqHjd_j73ww@mail.gmail.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Jakub Palider <jpa@semihalf.com>,
Netanel Belgazal <netanel@amazon.com>,
Evgeny Schemeilin <evgenys@amazon.com>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH] net/ena: fix icc compile error
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Jul 2016 11:34:22 -0000
Ferruh,
Actually we can stay with this patch. It's ok.
Acked-by: Jan Medala <jan@semihalf.com>
Jan
2016-07-19 12:48 GMT+02:00 Ferruh Yigit <ferruh.yigit@intel.com>:
> On 7/19/2016 10:33 AM, Ferruh Yigit wrote:
> > compile error:
> > CC ena_com.o
> > .../drivers/net/ena/base/ena_com.c(346):
> > error #3656: variable "dev_node" may be used before its value is set
> > ENA_MEM_ALLOC_COHERENT_NODE(ena_dev->dmadev,
> > ^
> >
> > .../drivers/net/ena/base/ena_com.c(399):
> > error #3656: variable "prev_node" may be used before its value is set
> > ENA_MEM_ALLOC_COHERENT_NODE(ena_dev->dmadev,
> > ^
> >
> > Fixes: 3d3edc265fc8 ("net/ena: make coherent memory allocation
> NUMA-aware")
> >
> > Reported-by: Eoin Breen <eoin.breen@intel.com>
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Self-Nack
> I wasn't aware Jan is already working on this and has a patch. We can
> drop this one.
>
> Thanks,
> ferruh
>
>