Re: [dpdk-dev] [PATCH v3 6/6] ena: fix for icc compiler

["Jan Mędala" <jan@semihalf.com>]

There are no obstacles.
We first produced patches 1-5, then tested on different compilers so patch
no. 6 was made.

Thank you Bruce for support!
I'm still learning DPDK's submission/upstream process so all comments and
gained knowledge will easier future patches.

  Jan

2016-07-06 10:14 GMT+02:00 Bruce Richardson <bruce.richardson@intel.com>:

> On Tue, Jul 05, 2016 at 07:10:54PM +0200, Jan Mędala wrote:
> > Let me point it this way:
> > ​​This patch fixes: [dpdk-dev,v3,1/6] ena: update of ENA communication
> layer
> >
> >   Jan
>
> Since it fixes another patch in the same series, I think the two patches
> could
> actually be merged, rather than adding code with a known issue and later
> having
> a two-line(ish) patch to fix it.
> I will merge the two on apply, if there is no objection.
>
> /Bruce
>
> >
> > 2016-07-05 19:04 GMT+02:00 Jan Mędala <jan@semihalf.com>:
> >
> > > Uhm, wait, I think that sha is wrong, please let me check it double
> time.
> > >
> > >   Jan
> > >
> > > 2016-07-05 19:03 GMT+02:00 Jan Mędala <jan@semihalf.com>:
> > >
> > >> Bruce,
> > >>
> > >>
> > >> That'd be very kind of you if you can fix trailing zeros.
> > >>
> > >>
> > >> This patch
> > >>
> > >> Fixes: b5b8cd9 ("ena: update of ENA communication layer")
> > >>
> > >>
> > >> Regards,
> > >>
> > >>   Jan
> > >>
> > >> 2016-07-05 18:19 GMT+02:00 Bruce Richardson <
> bruce.richardson@intel.com>:
> > >>
> > >>> On Tue, Jul 05, 2016 at 09:52:09AM +0100, Ferruh Yigit wrote:
> > >>> > On 6/30/2016 4:04 PM, Jan Medala wrote:
> > >>> > > Signed-off-by: Alexander Matushevsky <matua@amazon.com>
> > >>> > > Signed-off-by: Jakub Palider <jpa@semihalf.com>
> > >>> > > Signed-off-by: Jan Medala <jan@semihalf.com>
> > >>> >
> > >>> > The compilation error to fix is [1], it may be good to add what to
> fix
> > >>> > into commit log.
> > >>> >
> > >>> > [1]
> > >>> > == Build drivers/net/ena
> > >>> >   CC ena_ethdev.o
> > >>> > /tmp/dpdk_maintain/ena_v3/dpdk/drivers/net/ena/ena_ethdev.c(943):
> error
> > >>> > #188: enumerated type mixed with another type
> > >>> >         struct ena_com_create_io_ctx ctx = { 0 };
> > >>> >                                              ^
> > >>> >
> > >>> > /tmp/dpdk_maintain/ena_v3/dpdk/drivers/net/ena/ena_ethdev.c(1036):
> > >>> error
> > >>> > #188: enumerated type mixed with another type
> > >>> >         struct ena_com_create_io_ctx ctx = { 0 };
> > >>> >                                              ^
> > >>> > ...
> > >>> >
> > >>> > > --- a/drivers/net/ena/ena_ethdev.c
> > >>> > > +++ b/drivers/net/ena/ena_ethdev.c
> > >>> > > @@ -940,7 +940,10 @@ static int ena_tx_queue_setup(struct
> > >>> rte_eth_dev *dev,
> > >>> > >                           __rte_unused unsigned int socket_id,
> > >>> > >                           __rte_unused const struct
> rte_eth_txconf
> > >>> *tx_conf)
> > >>> > >  {
> > >>> > > -   struct ena_com_create_io_ctx ctx = { 0 };
> > >>> > > +   struct ena_com_create_io_ctx ctx =
> > >>> > > +           /* policy set to _HOST just to satisfy icc compiler
> */
> > >>> > > +           { ENA_ADMIN_PLACEMENT_POLICY_HOST,
> > >>> > > +             ENA_COM_IO_QUEUE_DIRECTION_TX, 0, 0, 0, 0 };
> > >>> >
> > >>> > Trailing "0" are not required, compiler will take care of them.
> > >>> >
> > >>> Jan,
> > >>>
> > >>> any comment on this? If you want, I can remove the trailing zeros on
> > >>> apply
> > >>> rather than needing a V3. Is that ok?
> > >>>
> > >>> Again a fixes line is missing, can you supply one.
> > >>>
> > >>> /Bruce
> > >>>
> > >>
> > >>
> > >
>