From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f178.google.com (mail-qk0-f178.google.com [209.85.220.178]) by dpdk.org (Postfix) with ESMTP id E9E7320F for ; Wed, 14 Dec 2016 15:36:03 +0100 (CET) Received: by mail-qk0-f178.google.com with SMTP id x190so22392488qkb.0 for ; Wed, 14 Dec 2016 06:36:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=G5J5ZNB4jnWUHvqnBXpNkh0AQE1DJRXb31xMpU5soBI=; b=RQO/2SQsg6bLaALBBkvz12thNcuKJLy2nPTK2WKZBOdyWwBCh417to+eAusfgRrZp/ 1ny7SIOnaaGCA2F8JmYJ52FJhkxuO0n5eTW3qBFGER5koHnbdYqCi5jtb0+hjUpDpSmt A7Tj3mRz1M4vtiQwhNbSugoIBYWKtjvbLoJ2bELRqRsM7sUpvXKOrxnEIsYUDpIXBy5Z OXd5FQdjen98K8nR5seSkS51wXD90h0brGF0J6PtQ43OOxs5i7zWOYkW9mK2qNgAEJb7 2Zq0Ee12mt26tTIuNE631AZCkc1ZJidLh+lSa8yxfWwYwjb+NnvXG2HZYz0oWh9K4JOC eB4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=G5J5ZNB4jnWUHvqnBXpNkh0AQE1DJRXb31xMpU5soBI=; b=etBIXAB4E8jwrj2pkCbrO4Zb3nv2qh84GxQYxBcW5xUyoGtYKkITWjLtNSuvuIY9JH /4k07gOgud3P34WeDYn44hiBbJpNq5gANupR0nNTSuTnwsxXBYSd/6wR8lPWLCu1Eoo0 kbCskZ7owMF99yHAQyN0kGaUxrt/MJqMewUyUQWT/JZvtZ3MXiuukp5PXzlMCFwU3rSu TEQ8udCo1INJ5b6Jdj704R/y/M9/qmF5Jw23cnl9D15agSjnT8sE02McIi3SKMD29Py3 tXR/InSUxFce5WlXaAuk9XD7RspZ8i9Yb0WO0Q0lcaL6vpXnuaTIZqALgU+DfV/1pOr5 10Kw== X-Gm-Message-State: AKaTC00u2+38lDCskAaOXpOSavSz8qimx32ZxxZA6QAIcD/Vyi2uVUbHVy5JBkItNH15YttdnAkOtP+JU1rLHw== X-Received: by 10.55.68.80 with SMTP id r77mr97336036qka.318.1481726163116; Wed, 14 Dec 2016 06:36:03 -0800 (PST) MIME-Version: 1.0 Received: by 10.12.147.70 with HTTP; Wed, 14 Dec 2016 06:36:02 -0800 (PST) In-Reply-To: <1481680558-4003-20-git-send-email-jerin.jacob@caviumnetworks.com> References: <1481680558-4003-1-git-send-email-jerin.jacob@caviumnetworks.com> <1481680558-4003-20-git-send-email-jerin.jacob@caviumnetworks.com> From: =?UTF-8?Q?Jan_M=C4=99dala?= Date: Wed, 14 Dec 2016 15:36:02 +0100 Message-ID: To: Jerin Jacob Cc: dev@dpdk.org, "Ananyev, Konstantin" , Thomas Monjalon , Bruce Richardson , jianbo.liu@linaro.org, viktorin@rehivetech.com, Santosh Shukla , Jakub Palider , Alexander Matushevsky Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 19/28] net/ena: use eal I/O device memory read/write API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Dec 2016 14:36:04 -0000 Despite the issue with naming convention (either it will be writel or write32), I'm fine with this change and new API. Acked-by: Jan Medala Jan 2016-12-14 2:55 GMT+01:00 Jerin Jacob : > From: Santosh Shukla > > Replace the raw I/O device memory read/write access with eal > abstraction for I/O device memory read/write access to fix > portability issues across different architectures. > > Signed-off-by: Santosh Shukla > Signed-off-by: Jerin Jacob > CC: Jan Medala > CC: Jakub Palider > --- > drivers/net/ena/base/ena_plat_dpdk.h | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ena/base/ena_plat_dpdk.h > b/drivers/net/ena/base/ena_plat_dpdk.h > index 87c3bf1..4db07c7 100644 > --- a/drivers/net/ena/base/ena_plat_dpdk.h > +++ b/drivers/net/ena/base/ena_plat_dpdk.h > @@ -50,6 +50,7 @@ > #include > > #include > +#include > > typedef uint64_t u64; > typedef uint32_t u32; > @@ -226,12 +227,12 @@ typedef uint64_t dma_addr_t; > > static inline void writel(u32 value, volatile void *addr) > { > - *(volatile u32 *)addr = value; > + rte_writel(value, addr); > } > > static inline u32 readl(const volatile void *addr) > { > - return *(const volatile u32 *)addr; > + return rte_readl(addr); > } > > #define ENA_REG_WRITE32(value, reg) writel((value), (reg)) > -- > 2.5.5 > >