Re: [PATCH v9] gro : ipv6 changes to support GRO for TCP/ipv6

[kumaraparameshwaran rathinavel <kumaraparamesh92@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 3217 bytes --]

On Thu, Jun 15, 2023 at 1:31 PM Hu, Jiayu <jiayu.hu@intel.com> wrote:

> Hi Kumara,
>
> > -----Original Message-----
> > From: Kumara Parameshwaran <kumaraparamesh92@gmail.com>
> > Sent: Thursday, June 15, 2023 2:20 PM
> > To: Hu, Jiayu <jiayu.hu@intel.com>
> > Cc: dev@dpdk.org; Kumara Parameshwaran
> > <kumaraparamesh92@gmail.com>
> > Subject: [PATCH v9] gro : ipv6 changes to support GRO for TCP/ipv6
> >
> > The patch adds GRO support for TCP/ipv6 packets. This does not include
> the
> > support for vxlan, udp ipv6 packets.
> >
> > Signed-off-by: Kumara Parameshwaran <kumaraparamesh92@gmail.com>
> > ---
> > v1:
> >       * Changes to support GRO for TCP/ipv6 packets. This does not
> > include
> >         vxlan changes.
> >       * The GRO is performed only for ipv6 packets that does not contain
> >        extension headers.
> >       * The logic for the TCP coalescing remains the same, in ipv6 header
> >         the source address, destination address, flow label, version
> fields
> >         are expected to be the same.
> >       * Re-organised the code to reuse certain tcp functions for both
> ipv4
> > and
> >         ipv6 flows.
> > v2:
> >       * Fix comments in gro_tcp6.h header file.
> >
> > v3:
> >       * Adderess review comments to fix code duplication for v4 and v6
> >
> > v4:
> >       * Addresses review comments for v3, do not use callbacks
> >
> > v5:
> >       * Address review comments
> >
> > v6:
> >       * Fix warning and coding style issues
> >
> > v7:
> >       * Fix build compilation issue
> >
> > v8:
> >       * Use gro_tcp_internal.h for functions used for gro_tcp4 and
> > gro_tcp6 and use
> >         gro_tcp.h for data structures and functions used across
> > gro_vxlan_tcp4
> >
> > v9:
> >       * Resolve merge conflict and add gro_tcp.h in proper path
> >
> >  .../generic_receive_offload_lib.rst           |  21 +-
> >  doc/guides/rel_notes/release_23_07.rst        |   2 +
> >  lib/gro/gro_tcp.h                             | 187 ++++++++++++
> >  lib/gro/gro_tcp4.c                            | 177 +++---------
> >  lib/gro/gro_tcp4.h                            | 170 +----------
> >  lib/gro/gro_tcp6.c                            | 268 ++++++++++++++++++
> >  lib/gro/gro_tcp6.h                            | 160 +++++++++++
> >  lib/gro/gro_tcp_internal.h                    | 128 +++++++++
> >  lib/gro/gro_vxlan_tcp4.c                      |  22 +-
> >  lib/gro/gro_vxlan_tcp4.h                      |   2 +-
> >  lib/gro/meson.build                           |   1 +
> >  lib/gro/rte_gro.c                             |  83 +++++-
> >  lib/gro/rte_gro.h                             |   3 +
> >  13 files changed, 883 insertions(+), 341 deletions(-)  create mode
> 100644
> > lib/gro/gro_tcp.h  create mode 100644 lib/gro/gro_tcp6.c  create mode
> > 100644 lib/gro/gro_tcp6.h  create mode 100644 lib/gro/gro_tcp_internal.h
> >
>
> Reviewed-by: Jiayu Hu <Jiayu.hu@intel.com>
>
> Hi Kumara,
>
> I notice you write Intel in the license header. Is it intended or mistaken?
>
>>
>> Hi Jiyau, This is intentional.
>>
>> Thanks,
>> Kumara.
>>
>
> Thanks,
> Jiayu
>

[-- Attachment #2: Type: text/html, Size: 4965 bytes --]