From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D5F0A42B8F; Wed, 24 May 2023 19:14:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C9E0F40156; Wed, 24 May 2023 19:14:15 +0200 (CEST) Received: from mail-vs1-f47.google.com (mail-vs1-f47.google.com [209.85.217.47]) by mails.dpdk.org (Postfix) with ESMTP id AAA3D400EF for ; Wed, 24 May 2023 19:14:14 +0200 (CEST) Received: by mail-vs1-f47.google.com with SMTP id ada2fe7eead31-437e7088b64so778021137.1 for ; Wed, 24 May 2023 10:14:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1684948454; x=1687540454; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=sfWz6klCIn/DUw/bIVAYPry8xvcF/Ccm4O6OmmAu/yE=; b=r8M2fjnwaA0WhttOV5oV9CrCsEwte8pJ2R5su5nmeNKn0+4IMKbPu2ySkQ+qudZaoc mirxgypn26vPbOheLVdO1IaF4UwVTQ8UkV8v9vsvkXJqwyPaC5u7XYpdRRG1ihbNBYyo 3+2A1V65u9nX1trG05CkO9DnYDkmmwMLTSkmVgXLK3ESTgsGAozevrCS1WGcRSuUzTaF dsgQnEQ/HvuLJQfw9lAh6M2Fakd+F6wiM9DCF6H+pwccrMBRB5J0ehtzcVQf/TDi1zr0 4/29j4XnuGBh+tclM4LTEhYOn91e0z/1SxHS2youvWL8a586WDWAKXm0sfJOCgF6rHMb fmzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684948454; x=1687540454; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sfWz6klCIn/DUw/bIVAYPry8xvcF/Ccm4O6OmmAu/yE=; b=cd7Im2zJqPUd+SLYyzyjsQypVTEZGd0MoWlnYdqD8CB+n86xJbJk4DUa2s/b5DqA7u CxDkzOdp/j9000BwsMl6fp1tS7nE7keoD+B9vptbg4Qq6En8jeSA+4Q0s3ZEswIM8aaT oS+ZPuvNYymFzo5qi4MiHGP3eFytJIs8v2NvN5cETEikkRwmkXWd2SpBIgvFU4bNmU0k MU3oH1sxJHZBDgaGd0t/aiLHR+xtMXvkcMZQ4+5MINWndUFgL+3jdFQqQYAmUGwE3cAj V1xfDZ2pCLFPXK3v0zRQuyK+jbREt2VRut7hmSop7E3vwvOO3ZETP2jE1P1HdeFKkMW2 LMow== X-Gm-Message-State: AC+VfDxcwJS0hEY4Cl0zpHZCMuC9ZpTrt9wTkwbAWRFwPd2daae2QOSp d2JPWSnRK4JDmfeBWKR79Uk71eFnPyxli3KbwbB40Q== X-Google-Smtp-Source: ACHHUZ4HO1AHIS1/SwqQ64wyhdq7VHbkArLb7y9BB9BrPd3FZlRwgk8lI+1evVvdI6Yfknu6rH4jcAi/9xMPKi2CsPw= X-Received: by 2002:a67:f344:0:b0:437:e68a:7091 with SMTP id p4-20020a67f344000000b00437e68a7091mr5797284vsm.29.1684948453932; Wed, 24 May 2023 10:14:13 -0700 (PDT) MIME-Version: 1.0 References: <20230519072600.1444309-1-rushilg@google.com> <20230519204618.1507956-1-rushilg@google.com> In-Reply-To: From: Rushil Gupta Date: Wed, 24 May 2023 10:14:03 -0700 Message-ID: Subject: Re: [v4] net/gve: check driver compatibility To: Ferruh Yigit Cc: qi.z.zhang@intel.com, jingjing.wu@intel.com, junfeng.guo@intel.com, joshwash@google.com, dev@dpdk.org, Jeroen de Borst Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org As noted from spec: "Some commands require an additional dma memory region to be passed to the device" We are passing virtual addresses to devices (please look at link-speed and describe-device adminq commands): describe device: https://github.com/DPDK/dpdk/blob/main/drivers/net/gve/base/gve_adminq.c#L7= 04 link-speed: https://github.com/DPDK/dpdk/blob/main/drivers/net/gve/base/gve= _adminq.c#L869 These adminq commands rely on gve_dma_alloc which presents mz->addr and not iova as memory region: https://github.com/DPDK/dpdk/blob/main/drivers/net/gve/base/gve_osdep.h#L13= 9 Here is the new patch: http://patchwork.dpdk.org/project/dpdk/patch/20230524171324.2072742-1-rushi= lg@google.com/ On Tue, May 23, 2023 at 3:22=E2=80=AFAM Ferruh Yigit = wrote: > > On 5/19/2023 9:46 PM, Rushil Gupta wrote: > > diff --git a/drivers/net/gve/base/gve_osdep.h b/drivers/net/gve/base/gv= e_osdep.h > > index abf3d379ae..5e8ae1eac6 100644 > > --- a/drivers/net/gve/base/gve_osdep.h > > +++ b/drivers/net/gve/base/gve_osdep.h > > @@ -21,9 +21,14 @@ > > #include > > #include > > #include > > +#include > > > > #include "../gve_logs.h" > > > > +#ifdef __linux__ > > +#include > > +#endif > > + > > Can you please use 'RTE_EXEC_ENV_LINUX' macro instead of '__linux__'?