From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B4EDA42B40; Sat, 20 May 2023 18:44:20 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7BD0242BC9; Sat, 20 May 2023 18:44:19 +0200 (CEST) Received: from mail-ua1-f43.google.com (mail-ua1-f43.google.com [209.85.222.43]) by mails.dpdk.org (Postfix) with ESMTP id 37E0E40395 for ; Sat, 20 May 2023 18:44:18 +0200 (CEST) Received: by mail-ua1-f43.google.com with SMTP id a1e0cc1a2514c-783fdeed241so1251867241.1 for ; Sat, 20 May 2023 09:44:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1684601057; x=1687193057; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=xm3ZYFAzgonkns8K7fAKzoRqjapvQyrxgS2E9eESTzU=; b=Rk3O3gVlrfSYbjz20J/VIcFjrfOYGGReVsjvvkeG2/WDvyH8y+MQAJ9WX/O1ZTaSvx h8FywMZTKV6Uh+U3hvrywZ37BaWQxojsXA20bLwHFbkMYrGtYAIy6sNl0zXO76UxtsBs 2g59bwmggpwwNDfuryDzkAt5Yc/chWldae/Ds8CfueHC5EYu5K+6uOqrMMRnGSMIY7Bg Jers1xb3tEnu0Ed1/ODxY9I9sVV1X9f9RNFG6lcP968khRaaJGhrQ5lfzVfs3lsmCKeT kYsaVGYsX7ZbTOO2WzH1evQquKi+OfsUjWy3pwU0TeTvFNYlhygTrvyAmHnyqQe8xnyq D74g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684601057; x=1687193057; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xm3ZYFAzgonkns8K7fAKzoRqjapvQyrxgS2E9eESTzU=; b=NkFeAcLAh2U4zjhjSLHalb7cqceODfE8aviPcwQSo72uHD97pSmgMhSmJcVagadMZt FHY4US71h7IMVCr4We3pOCzzy3byyX0a81J2+FFLA0/Xqis8y294latFiMbp9dGq6GPw AxUAoILVW9akqWDKkSm9gD7BmKq3YlAdzFPcvtAzkB27UH+XHYuy4uyXlcwgNVLpXqEy k3r8AzpT+GgUoJsGzUjKiUyTpMjOf7VHf/N0+kbtysVxOSa1T78MV1aSmtKopoO0B6c/ 6FM2k8olge2M5RXeYq96BgysmAZFD+fpCXzSKI2vTruARa4wHBJgxtUMQLXIB4SGBTzT i74g== X-Gm-Message-State: AC+VfDzjII7AxarLxeZoawqPzhRVPivSnagiTl9Nn5uJeIYCDy0t5Ifc jruupKqb45LjYQeWzOEhKJKuRZgn4k7Y6B2dNEqKPQ== X-Google-Smtp-Source: ACHHUZ5x0uRZbui/LGEvbIIPW2kPg2PcH/Dv66P94MnoXx4zKjAjLKLSMkN7ClpVEFHmyHx7PEstcJBCu6S2ldS5bgY= X-Received: by 2002:a67:fe17:0:b0:439:e3f:9d6 with SMTP id l23-20020a67fe17000000b004390e3f09d6mr1064849vsr.17.1684601057377; Sat, 20 May 2023 09:44:17 -0700 (PDT) MIME-Version: 1.0 References: <20230519072600.1444309-1-rushilg@google.com> <20230519204618.1507956-1-rushilg@google.com> <20230519135609.52338b1e@hermes.local> In-Reply-To: <20230519135609.52338b1e@hermes.local> From: Rushil Gupta Date: Sat, 20 May 2023 09:44:06 -0700 Message-ID: Subject: Re: [v4] net/gve: check driver compatibility To: Stephen Hemminger Cc: ferruh.yigit@amd.com, qi.z.zhang@intel.com, jingjing.wu@intel.com, junfeng.guo@intel.com, joshwash@google.com, dev@dpdk.org, Jeroen de Borst Content-Type: multipart/alternative; boundary="0000000000009d48f505fc22bfe2" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --0000000000009d48f505fc22bfe2 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable We are not validating anything. This is for our internal analysis and product requirements. On Fri, May 19, 2023 at 1:56=E2=80=AFPM Stephen Hemminger < stephen@networkplumber.org> wrote: > On Fri, 19 May 2023 13:46:18 -0700 > Rushil Gupta wrote: > > > +#include > > > > #include "../gve_logs.h" > > > > +#ifdef __linux__ > > +#include > > +#endif > > + > > typedef uint8_t u8; > > typedef uint16_t u16; > > typedef uint32_t u32; > > @@ -73,6 +78,12 @@ typedef rte_iova_t dma_addr_t; > > > > #define msleep(ms) rte_delay_ms(ms) > > > > +#define OS_VERSION_STRLEN 128 > > +struct os_version_string { > > + char os_version_str1[OS_VERSION_STRLEN]; > > + char os_version_str2[OS_VERSION_STRLEN]; > > +}; > > + > > Not sure this a good idea. Are you having the host validate > against DPDK versions. This is a bad idea. > > Better to use feature bits like virtio and not be creating > and validating strings about versions. For example, ever minor > stable release changes this. > --0000000000009d48f505fc22bfe2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
We are not validating anything.
This is for our intern= al analysis and product requirements.

On Fri, May 19, 2023 at 1:56=E2= =80=AFPM Stephen Hemminger <stephen@networkplumber.org> wrote:
On Fri, 19 May 2023 13:46:18 -0700
Rushil Gupta <ru= shilg@google.com> wrote:

> +#include <rte_version.h>
>=C2=A0
>=C2=A0 #include "../gve_logs.h"
>=C2=A0
> +#ifdef __linux__
> +#include <sys/utsname.h>
> +#endif
> +
>=C2=A0 typedef uint8_t u8;
>=C2=A0 typedef uint16_t u16;
>=C2=A0 typedef uint32_t u32;
> @@ -73,6 +78,12 @@ typedef rte_iova_t dma_addr_t;
>=C2=A0
>=C2=A0 #define msleep(ms)=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0rte_d= elay_ms(ms)
>=C2=A0
> +#define OS_VERSION_STRLEN 128
> +struct os_version_string {
> +=C2=A0 =C2=A0 =C2=A0char os_version_str1[OS_VERSION_STRLEN];
> +=C2=A0 =C2=A0 =C2=A0char os_version_str2[OS_VERSION_STRLEN];
> +};
> +

Not sure this a good idea. Are you having the host validate
against DPDK versions. This is a bad idea.

Better to use feature bits like virtio and not be creating
and validating strings about versions.=C2=A0 For example, ever minor
stable release changes this.
--0000000000009d48f505fc22bfe2--