From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AE4C042C05; Thu, 1 Jun 2023 18:32:41 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3E8FB40EF0; Thu, 1 Jun 2023 18:32:41 +0200 (CEST) Received: from mail-vs1-f49.google.com (mail-vs1-f49.google.com [209.85.217.49]) by mails.dpdk.org (Postfix) with ESMTP id AAE1940DDC for ; Thu, 1 Jun 2023 18:32:40 +0200 (CEST) Received: by mail-vs1-f49.google.com with SMTP id ada2fe7eead31-4394a8f26d5so232107137.0 for ; Thu, 01 Jun 2023 09:32:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1685637160; x=1688229160; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=z6lpG2Y1Vz7RUipyczMaYaH3vak7XECbGzSNZdVPtAE=; b=grA+ZAmWuoVO5JdExrBn59HPhXwHXqwvFVYinMjRdP7Bx0HQ0vtHwnYE24hqwVx3m7 m5vLf+10a3lRVzlNVV/BGCq/aFM7XwIlp5EKge6WKVlwtxyAmrdXFMKnzwH/dIi0+Qh7 Z3VNZ6eyxChkl2UEnTCsn7f/J7ot9oKTZIxSGjr8onK4QPexyG4ZhRbThhu6OoP+Zg9j NrO7qzC6Fr1yw59GFDbE1JR+TV6XrqNX7v5fxnDCkysZwotXriyVOFbesVn5BBOW796M /5StaLOBa77xlTS81Xx7XTnfEIPUPTylCjE5LfP3ggPCvbz50KXBBcdTS1VgeUnQ7hQf RZQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685637160; x=1688229160; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=z6lpG2Y1Vz7RUipyczMaYaH3vak7XECbGzSNZdVPtAE=; b=QwWXEPPNa7loW6jm0CwhpQRfUY59h53ZLajZ1N600//ZSr8S8klnq5jGTJQsL/XXd5 BpBQXcNMrYE5w9XVp60DUyq/SYTpACHz0oKPFg85w4y1HI/k1Eg14lTpghvWDjG7nrxv 64A6cY/B8+Wk4onDuYmfqXVTeegjbHG2fKQLXeezqac2S6sEBIeZqd90/YW68guIcVcH YFiIxGIUqt6EiFdRfj8/rBxtzUp6VbRuMUKK6DZx4skTZsEOkw4Ye7IQLqJfwSk7LzoU uh4+VqtCQYz5dZZsh4Ir7eg1f9eVWo1FngC5ipNa6uKO5uAd9brl9NGUMAVabx6415S9 K40Q== X-Gm-Message-State: AC+VfDwi83n1AVbOSL7f1vfmMJ7TaQvJEm5lfhmoyolZ9Ab7I/vHp3b5 3nepz9SWvLRt3qLZmZjeuuoRM6IssyareUJk7G5g6A== X-Google-Smtp-Source: ACHHUZ6zgyRApgADeYngs4wyVCDqmc8eYY+0fr13jsaIJ0B8hqimPVhwYJn3+OQImg4p4kIf1w11gwde6xeoY2H1VfU= X-Received: by 2002:a05:6102:83:b0:439:730b:3af6 with SMTP id t3-20020a056102008300b00439730b3af6mr3061821vsp.3.1685637159879; Thu, 01 Jun 2023 09:32:39 -0700 (PDT) MIME-Version: 1.0 References: <20230601031513.453016-1-rushilg@google.com> <20230601044950.465926-1-rushilg@google.com> <859b86f2-888f-b60b-b10e-d83d3a37fe7e@amd.com> <660baf37-53e9-6274-1cef-9beea3f69f8c@amd.com> In-Reply-To: <660baf37-53e9-6274-1cef-9beea3f69f8c@amd.com> From: Rushil Gupta Date: Thu, 1 Jun 2023 09:32:29 -0700 Message-ID: Subject: Re: [PATCH] net/gve: fix bug in verify driver compatibility To: Ferruh Yigit Cc: qi.z.zhang@intel.com, junfeng.guo@intel.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Thanks for the quick response! Just for my own knowledge, what Junfeng described is the process to fix the bug if a bug is present in the main dpdk repo? On Thu, Jun 1, 2023 at 3:24=E2=80=AFAM Ferruh Yigit = wrote: > > On 6/1/2023 9:26 AM, Ferruh Yigit wrote: > > On 6/1/2023 5:49 AM, Rushil Gupta wrote: > >> gVNIC requires physical address to be passed in the adminq command. > >> This was initially rightly pointed by ferruh.yigit@. > >> Fixed by passing 'driver_info_mem->iova'. > >> > >> Signed-off-by: Rushil Gupta > >> --- > >> drivers/net/gve/gve_ethdev.c | 3 ++- > >> 1 file changed, 2 insertions(+), 1 deletion(-) > >> > >> diff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethdev= .c > >> index 2c1e73d07a..aa75abe102 100644 > >> --- a/drivers/net/gve/gve_ethdev.c > >> +++ b/drivers/net/gve/gve_ethdev.c > >> @@ -276,7 +276,8 @@ gve_verify_driver_compatibility(struct gve_priv *p= riv) > >> (char *)driver_info->os_version_str2); > >> > >> err =3D gve_adminq_verify_driver_compatibility(priv, > >> - sizeof(struct gve_driver_info), (dma_addr_t)driver_info); > >> + sizeof(struct gve_driver_info), > >> + (dma_addr_t)driver_info_mem->iova); > >> > > > > Yep, this was my point, let me squashed onto original patch in next-net= . > > > > > > Squashed into relevant commit in next-net, thanks. > Can you please verify latest code in next-net?