From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7D79F42BF6; Wed, 31 May 2023 18:41:03 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 10A7940A89; Wed, 31 May 2023 18:41:03 +0200 (CEST) Received: from mail-vs1-f49.google.com (mail-vs1-f49.google.com [209.85.217.49]) by mails.dpdk.org (Postfix) with ESMTP id 1645840A82 for ; Wed, 31 May 2023 18:41:01 +0200 (CEST) Received: by mail-vs1-f49.google.com with SMTP id ada2fe7eead31-437e6ffa660so1609822137.1 for ; Wed, 31 May 2023 09:41:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1685551260; x=1688143260; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=uK2MF5ow7fOkz2f4QXUVyHtn1GQ/gXkG2AtuoNfgw7E=; b=cUcnNWuOfCLoOVzIPGKV3LY7eSedstGH70FATePk/0tcPpbgmuFDi9atJwPoJRGLBW k+myqgK6WFLcEXz1EeU/LKhLhCE17uCFtKh0msAZQa+fXizuV+bqCiMxSHBTZnwXJ8Cz gzFiuV0abjeqcN3WyQgVwU0xbbsTJW2anqHHwZWbjYQLJjkcRYO5tMY+5iCYgXBd/Qz/ 4ejeGxnuxyyaSznlKxdB3kH5DMYwg1bbiyL8WZh0ruSK3K27YNE5VlpFGEpijiTNAMGw DxKjgWKPevpoM9FbaI8uUgxpxIrk6bNQKRmB3PUnZeEprJiDca0Dvge20FrhTEvhQZDa dfKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685551260; x=1688143260; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uK2MF5ow7fOkz2f4QXUVyHtn1GQ/gXkG2AtuoNfgw7E=; b=UiNZQW+VTiiUvFqnJyPbjpYY1cofH56OTOK4GyDEBDsLLmR+b4QN2gXfCiOsuuoK6k DxJ1W0NPujRVv0ZYL8fFkiDTdYt/eeCCu3ERFfw461TOOc6mxWuToKXWQCehHDC2PLpE Kq9HEAB98NEf9vGFVdOK1kP+rl8u2+UyfdO9ZecROEWRe4ZQeZPTr2+aCZzjk59I3H6k FLXt2RTm3EfxqW34+PWwX+8ZneVUKL0mlcilFiwRLJ35/dVDaXmU/PaURyuXfhzds0cq 5/EQ0TXAq3IRgChB53oWRfH6W+eH0tC3Dey9GLueacqeZY9iy0/M3hvF55ulHMOVnv9R n1fw== X-Gm-Message-State: AC+VfDyDHuuJ3opS1NcmtPIvrBn5Su52kh98W/uU74j4z8M2B0a19V9a JPOis/EnoGfRlFgNunP1TXajk103+m04GSQFrn83PQ== X-Google-Smtp-Source: ACHHUZ74oylToyZUCzYJbr/h5GKsRcWo+2x6keJIMIPBBZKxv0DNO1DAAvFqp+plEOi15jkCHUARA210Q3XRo6JJ3ho= X-Received: by 2002:a67:f5d5:0:b0:426:20a8:a5b0 with SMTP id t21-20020a67f5d5000000b0042620a8a5b0mr2290636vso.13.1685551260313; Wed, 31 May 2023 09:41:00 -0700 (PDT) MIME-Version: 1.0 References: <20230519072600.1444309-1-rushilg@google.com> <20230519204618.1507956-1-rushilg@google.com> In-Reply-To: From: Rushil Gupta Date: Wed, 31 May 2023 09:40:48 -0700 Message-ID: Subject: Re: [v4] net/gve: check driver compatibility To: Ferruh Yigit Cc: qi.z.zhang@intel.com, jingjing.wu@intel.com, junfeng.guo@intel.com, joshwash@google.com, dev@dpdk.org, Jeroen de Borst Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org http://patchwork.dpdk.org/project/dpdk/patch/20230524171324.2072742-1-rushi= lg@google.com/ Does this look good to you? On Wed, May 24, 2023 at 10:14=E2=80=AFAM Rushil Gupta = wrote: > > As noted from spec: "Some commands require an additional dma memory > region to be passed to the device" > We are passing virtual addresses to devices (please look at link-speed > and describe-device adminq commands): > describe device: > https://github.com/DPDK/dpdk/blob/main/drivers/net/gve/base/gve_adminq.c#= L704 > link-speed: https://github.com/DPDK/dpdk/blob/main/drivers/net/gve/base/g= ve_adminq.c#L869 > > These adminq commands rely on gve_dma_alloc which presents mz->addr > and not iova as memory region: > https://github.com/DPDK/dpdk/blob/main/drivers/net/gve/base/gve_osdep.h#L= 139 > > Here is the new patch: > http://patchwork.dpdk.org/project/dpdk/patch/20230524171324.2072742-1-rus= hilg@google.com/ > > > > On Tue, May 23, 2023 at 3:22=E2=80=AFAM Ferruh Yigit wrote: > > > > On 5/19/2023 9:46 PM, Rushil Gupta wrote: > > > diff --git a/drivers/net/gve/base/gve_osdep.h b/drivers/net/gve/base/= gve_osdep.h > > > index abf3d379ae..5e8ae1eac6 100644 > > > --- a/drivers/net/gve/base/gve_osdep.h > > > +++ b/drivers/net/gve/base/gve_osdep.h > > > @@ -21,9 +21,14 @@ > > > #include > > > #include > > > #include > > > +#include > > > > > > #include "../gve_logs.h" > > > > > > +#ifdef __linux__ > > > +#include > > > +#endif > > > + > > > > Can you please use 'RTE_EXEC_ENV_LINUX' macro instead of '__linux__'?