From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f180.google.com (mail-io0-f180.google.com [209.85.223.180]) by dpdk.org (Postfix) with ESMTP id 774E9559C for ; Tue, 11 Apr 2017 00:21:02 +0200 (CEST) Received: by mail-io0-f180.google.com with SMTP id a103so50011836ioj.1 for ; Mon, 10 Apr 2017 15:21:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Hfgumb+ENxFvbmIuPdrtIOyool4u9qioc+m/DrNFmR4=; b=m4At57hs7V81SnuZFUQlL3EnVa0cljFVwMoWLhgFz0YY4l08G8rUtvQE7BnNqICv9f agPMS1EXBCfaDR/qH43e8BwjGVyZf0qM9pxuOHF1RG+r2Nf0awztAoZ5rXOkjq0DvlkA 5ZM7hhF+ulWYmnEg/MD81uDs/rSbK46e6wcv1qUT1rK8YIogL4pJHkLZbCcjEpr7+/Cj n9OJ4o2HVOssbYrfR5XcAmK94jpUVHJyjv9Mtdg/faBfExbOOHkpdZWYSFCh3VF4LCBW C90Y6opt42yBeYVufsQ15Ih1VcGhgXT+Podm9Pll5h81Wpan1n6piAkOrdGtlM9nh84s aW4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Hfgumb+ENxFvbmIuPdrtIOyool4u9qioc+m/DrNFmR4=; b=nFiDGqwL3/Xugeh8maTPjnNjfq7X0ditoqbLDl6VTcK9o7edoyUeeWy4iu+yIqbOyQ yvQQMr7oCfJhRas7YpC3PJNtwA8kRpSCuu5rIVuV3dfYiXTViSaLwuLXH42bFV76vm7p ++BgjT0LRHWRQe8V7RQgghcsWNnfpoVXQT3ukRwY3dpQ/H4FDHge3emAouYcxe8P80k+ GgN2qZ1Fm0yFC/QwScmtN4hohUaToO3cBOY6783bwOMlBkqKbPqkqj0BcYcO2pZdj20g Sfk+qG/JkUaFPUwpxynZUXpiWKys0RKWskfznbvIUXTUkoH3cAk3PLb+wsj3ktqn4e5V /v8g== X-Gm-Message-State: AN3rC/5ax5eYPBgwryNxR22+UaDUFeQSwadzoYkzE8W2LruyM7J7fFRtU5s5tc4aYf/e7XC4qdbtRq9ZcAkGTw== X-Received: by 10.36.105.67 with SMTP id e64mr5231200itc.44.1491862861690; Mon, 10 Apr 2017 15:21:01 -0700 (PDT) MIME-Version: 1.0 Received: by 10.79.30.67 with HTTP; Mon, 10 Apr 2017 15:20:41 -0700 (PDT) In-Reply-To: <1491834491-13944-1-git-send-email-mw@semihalf.com> References: <1491834491-13944-1-git-send-email-mw@semihalf.com> From: Jakub Palider Date: Tue, 11 Apr 2017 00:20:41 +0200 Message-ID: To: Marcin Wojtas Cc: dev@dpdk.org, =?UTF-8?Q?Jan_M=C4=99dala?= , netanel@amazon.com, evgenys@amazon.com, matua@amazon.com, gtzalik@amazon.com, igorch@amazon.com, mk@semihalf.com X-Mailman-Approved-At: Wed, 12 Apr 2017 09:13:05 +0200 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 0/4] Ena PMD fixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Apr 2017 22:21:02 -0000 On Mon, Apr 10, 2017 at 4:28 PM, Marcin Wojtas wrote: > Hi, > > I sent second version of a patchset with various fixes for ena PMD. > All remarks after v1 review have been taken into account. Details > can be found in the changelog below. > > We are looking forward to any comments or remarks. > > Best regards, > Marcin > > Changelog: > v1 -> v2 > * 1/4: > - Part of the changes related to the allocation of wrong amount of Rx > descriptors from patch 2 were moved to patch 1 > * 2/4: > - Remove additional variable desc_to_refill > - Update desc_to_use after reading all descriptors - significant diff > reduction > - Update information why next_to_use must be assigned before call of > the > ena_rx_populate() > - Update commit message to reflect recent changes > * 4/4: > - Check for the type of the packet before doing further investigation > in TSO > > Michal Krawczyk (4): > net/ena: fix incorrect Rx descriptors allocation > net/ena: fix delayed cleanup of Rx descriptors > net/ena: cleanup if refilling of rx descriptors fails > net/ena: calculate partial checksum if DF bit is disabled > > drivers/net/ena/ena_ethdev.c | 52 ++++++++++++++++++++++++++++-- > -------------- > 1 file changed, 33 insertions(+), 19 deletions(-) > > -- > 1.8.3.1 > > =E2=80=8BReviewed-by: Jakub Palider =E2=80=8B