From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 80222436D9; Wed, 13 Dec 2023 04:07:21 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 048A242E47; Wed, 13 Dec 2023 04:07:21 +0100 (CET) Received: from mail-ot1-f52.google.com (mail-ot1-f52.google.com [209.85.210.52]) by mails.dpdk.org (Postfix) with ESMTP id 63BAD410FB for ; Wed, 13 Dec 2023 04:07:20 +0100 (CET) Received: by mail-ot1-f52.google.com with SMTP id 46e09a7af769-6d7fa93afe9so4729951a34.2 for ; Tue, 12 Dec 2023 19:07:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1702436839; x=1703041639; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=nicugKpruCDiGfZ0vvhtt6JgH72zF7Z5xNSnrNwjjDo=; b=N7+MjUX2XUuJjbG+Y9XYTYL9nw4TXYb9yBQ8600x0up2bXZRJq0ClYHKyJda2BVBJx uGETdIB4+24ffGNcLhY4HQnKFTpazMG7FvZvckIufZ2IEicZEZjXU0y2rdABCTQAYlLy ozoGho222+A0ftPlxr8nmQEATrDCuJSM8dCQM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702436839; x=1703041639; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nicugKpruCDiGfZ0vvhtt6JgH72zF7Z5xNSnrNwjjDo=; b=ARoApTt+aihlL8g5NsBzKzCLgbZMQ+HLkcQokV0NMDz+X63IqcsjBrPot0v9t7FxCh TNZk3/mCT3JrPqwWiYolt2UADUgnuqbHKZpFfkL8lmI3nNgr+lzvA+HF9KU0bSIUi8RS kh2ElvFsNqZwiCw76EKemlGFZF0ns/8AlTj7qiMGhmryJ+4cB0B8lM7fXgiHNCNYdpOp OJtNhASK8wD6AeAdg32QDjoK6QjERkmvaMl4j42h3Wm4lHnbBn8FBh0a645EgeDbn0fM x5lVToyDdtqGMX5fw7DXjEb+01anzxQRSrJYSVwmFmJyEVGTGZ+5riWZGZmAUY12lk8A 2lWw== X-Gm-Message-State: AOJu0YzBlobgyzHUADKXsjlEJ197W0X/h/iQBFMhld3co6892FyrddI2 l8WW4FnnIwfZqdJOnO9Gv2GkjKCRWGkujzYro3uFSQ== X-Google-Smtp-Source: AGHT+IGG2/MMZCmKmaLRMA4Cgcm53vlYAD+9wCxLxqtkff/jEr8+ml+r0QCqltkLqr0oTDHd+CpVIBifr0AfKeja7oQ= X-Received: by 2002:a9d:6f96:0:b0:6da:2ec0:cdb2 with SMTP id h22-20020a9d6f96000000b006da2ec0cdb2mr1238424otq.10.1702436839445; Tue, 12 Dec 2023 19:07:19 -0800 (PST) MIME-Version: 1.0 References: <20231213014408.612051-1-stephen@networkplumber.org> <20231213014408.612051-6-stephen@networkplumber.org> In-Reply-To: <20231213014408.612051-6-stephen@networkplumber.org> From: Somnath Kotur Date: Wed, 13 Dec 2023 08:37:06 +0530 Message-ID: Subject: Re: [PATCH 05/26] net/bnxt: replace RTE_LOG_DP with rte_log_dp To: Stephen Hemminger Cc: dev@dpdk.org, Ajit Khaparde , Ruifeng Wang , Bruce Richardson , Konstantin Ananyev Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="00000000000017471b060c5b77bb" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --00000000000017471b060c5b77bb Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Dec 13, 2023 at 7:14=E2=80=AFAM Stephen Hemminger wrote: > > Want datapath logs to use own logtype. > > Signed-off-by: Stephen Hemminger > --- > drivers/net/bnxt/bnxt.h | 5 +++++ > drivers/net/bnxt/bnxt_rxtx_vec_neon.c | 3 +-- > drivers/net/bnxt/bnxt_rxtx_vec_sse.c | 3 +-- > drivers/net/bnxt/bnxt_txr.c | 4 +--- > 4 files changed, 8 insertions(+), 7 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h > index 0e01b1d4baea..3aa9213a12f9 100644 > --- a/drivers/net/bnxt/bnxt.h > +++ b/drivers/net/bnxt/bnxt.h > @@ -1058,6 +1058,11 @@ extern int bnxt_logtype_driver; > #define PMD_DRV_LOG(level, fmt, args...) \ > PMD_DRV_LOG_RAW(level, fmt, ## args) > > +#define PMD_DRV_LOG_DP(level, fmt, args...) \ > + rte_log_dp(RTE_LOG_ ## level, bnxt_logtype_driver, \ > + fmt, ## args) > + > + > extern const struct rte_flow_ops bnxt_ulp_rte_flow_ops; > int32_t bnxt_ulp_port_init(struct bnxt *bp); > void bnxt_ulp_port_deinit(struct bnxt *bp); > diff --git a/drivers/net/bnxt/bnxt_rxtx_vec_neon.c b/drivers/net/bnxt/bnx= t_rxtx_vec_neon.c > index aa1b1ab8bb7e..64c1dfac47d9 100644 > --- a/drivers/net/bnxt/bnxt_rxtx_vec_neon.c > +++ b/drivers/net/bnxt/bnxt_rxtx_vec_neon.c > @@ -357,8 +357,7 @@ bnxt_handle_tx_cp_vec(struct bnxt_tx_queue *txq) > if (likely(CMP_TYPE(txcmp) =3D=3D TX_CMPL_TYPE_TX_L2)) > nb_tx_pkts +=3D txcmp->opaque; > else > - RTE_LOG_DP(ERR, PMD, > - "Unhandled CMP type %02x\n", > + PMD_DRV_LOG_DP(ERR, "Unhandled CMP type %02x\n", > CMP_TYPE(txcmp)); > raw_cons =3D NEXT_RAW_CMP(raw_cons); > } while (nb_tx_pkts < ring_mask); > diff --git a/drivers/net/bnxt/bnxt_rxtx_vec_sse.c b/drivers/net/bnxt/bnxt= _rxtx_vec_sse.c > index e99a547f5857..572b21a00837 100644 > --- a/drivers/net/bnxt/bnxt_rxtx_vec_sse.c > +++ b/drivers/net/bnxt/bnxt_rxtx_vec_sse.c > @@ -326,8 +326,7 @@ bnxt_handle_tx_cp_vec(struct bnxt_tx_queue *txq) > if (likely(CMP_TYPE(txcmp) =3D=3D TX_CMPL_TYPE_TX_L2)) > nb_tx_pkts +=3D txcmp->opaque; > else > - RTE_LOG_DP(ERR, PMD, > - "Unhandled CMP type %02x\n", > + PMD_DRV_LOG_DP(ERR, "Unhandled CMP type %02x\n", > CMP_TYPE(txcmp)); > raw_cons =3D NEXT_RAW_CMP(raw_cons); > } while (nb_tx_pkts < ring_mask); > diff --git a/drivers/net/bnxt/bnxt_txr.c b/drivers/net/bnxt/bnxt_txr.c > index 899986764f93..bd0a75653ab3 100644 > --- a/drivers/net/bnxt/bnxt_txr.c > +++ b/drivers/net/bnxt/bnxt_txr.c > @@ -542,9 +542,7 @@ static int bnxt_handle_tx_cp(struct bnxt_tx_queue *tx= q) > if (CMP_TYPE(txcmp) =3D=3D TX_CMPL_TYPE_TX_L2) > nb_tx_pkts +=3D opaque; > else > - RTE_LOG_DP(ERR, PMD, > - "Unhandled CMP type %02x\n", > - CMP_TYPE(txcmp)); > + PMD_DRV_LOG_DP(ERR, "Unhandled CMP type %02x\n", = CMP_TYPE(txcmp)); > raw_cons =3D NEXT_RAW_CMP(raw_cons); > } while (nb_tx_pkts < ring_mask); > > -- > 2.42.0 > Acked-by: Somnath Kotur --00000000000017471b060c5b77bb Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIQcAYJKoZIhvcNAQcCoIIQYTCCEF0CAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg gg3HMIIFDTCCA/WgAwIBAgIQeEqpED+lv77edQixNJMdADANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA5MTYwMDAwMDBaFw0yODA5MTYwMDAwMDBaMFsxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBS MyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA vbCmXCcsbZ/a0fRIQMBxp4gJnnyeneFYpEtNydrZZ+GeKSMdHiDgXD1UnRSIudKo+moQ6YlCOu4t rVWO/EiXfYnK7zeop26ry1RpKtogB7/O115zultAz64ydQYLe+a1e/czkALg3sgTcOOcFZTXk38e aqsXsipoX1vsNurqPtnC27TWsA7pk4uKXscFjkeUE8JZu9BDKaswZygxBOPBQBwrA5+20Wxlk6k1 e6EKaaNaNZUy30q3ArEf30ZDpXyfCtiXnupjSK8WU2cK4qsEtj09JS4+mhi0CTCrCnXAzum3tgcH cHRg0prcSzzEUDQWoFxyuqwiwhHu3sPQNmFOMwIDAQABo4IB2jCCAdYwDgYDVR0PAQH/BAQDAgGG MGAGA1UdJQRZMFcGCCsGAQUFBwMCBggrBgEFBQcDBAYKKwYBBAGCNxQCAgYKKwYBBAGCNwoDBAYJ KwYBBAGCNxUGBgorBgEEAYI3CgMMBggrBgEFBQcDBwYIKwYBBQUHAxEwEgYDVR0TAQH/BAgwBgEB /wIBADAdBgNVHQ4EFgQUljPR5lgXWzR1ioFWZNW+SN6hj88wHwYDVR0jBBgwFoAUj/BLf6guRSSu TVD6Y5qL3uLdG7wwegYIKwYBBQUHAQEEbjBsMC0GCCsGAQUFBzABhiFodHRwOi8vb2NzcC5nbG9i YWxzaWduLmNvbS9yb290cjMwOwYIKwYBBQUHMAKGL2h0dHA6Ly9zZWN1cmUuZ2xvYmFsc2lnbi5j b20vY2FjZXJ0L3Jvb3QtcjMuY3J0MDYGA1UdHwQvMC0wK6ApoCeGJWh0dHA6Ly9jcmwuZ2xvYmFs c2lnbi5jb20vcm9vdC1yMy5jcmwwWgYDVR0gBFMwUTALBgkrBgEEAaAyASgwQgYKKwYBBAGgMgEo CjA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzAN BgkqhkiG9w0BAQsFAAOCAQEAdAXk/XCnDeAOd9nNEUvWPxblOQ/5o/q6OIeTYvoEvUUi2qHUOtbf jBGdTptFsXXe4RgjVF9b6DuizgYfy+cILmvi5hfk3Iq8MAZsgtW+A/otQsJvK2wRatLE61RbzkX8 9/OXEZ1zT7t/q2RiJqzpvV8NChxIj+P7WTtepPm9AIj0Keue+gS2qvzAZAY34ZZeRHgA7g5O4TPJ /oTd+4rgiU++wLDlcZYd/slFkaT3xg4qWDepEMjT4T1qFOQIL+ijUArYS4owpPg9NISTKa1qqKWJ jFoyms0d0GwOniIIbBvhI2MJ7BSY9MYtWVT5jJO3tsVHwj4cp92CSFuGwunFMzCCA18wggJHoAMC AQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUAMEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9v dCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWduMRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5 MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEgMB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENB IC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqG SIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0E XyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuul9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+J J5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJpij2aTv2y8gokeWdimFXN6x0FNx04Druci8u nPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTv riBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti+w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGj QjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5N UPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEAS0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigH M8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9ubG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmU Y/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaMld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V 14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcy a5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/fhO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/ XzCCBU8wggQ3oAMCAQICDHrACvo11BjSxMYbtzANBgkqhkiG9w0BAQsFADBbMQswCQYDVQQGEwJC RTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTExMC8GA1UEAxMoR2xvYmFsU2lnbiBHQ0MgUjMg UGVyc29uYWxTaWduIDIgQ0EgMjAyMDAeFw0yMjA5MTAwODE4NDJaFw0yNTA5MTAwODE4NDJaMIGQ MQswCQYDVQQGEwJJTjESMBAGA1UECBMJS2FybmF0YWthMRIwEAYDVQQHEwlCYW5nYWxvcmUxFjAU BgNVBAoTDUJyb2FkY29tIEluYy4xFjAUBgNVBAMTDVNvbW5hdGggS290dXIxKTAnBgkqhkiG9w0B CQEWGnNvbW5hdGgua290dXJAYnJvYWRjb20uY29tMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIB CgKCAQEAwSM6HryOBKGRppHga4G18QnbgnWFlW7A7HePfwcVN3QOMgkXq0EfqT2hd3VAX9Dgoi2U JeG28tGwAJpNxAD+aAlL0MVG7D4IcsTW9MrBzUGFMBpeUqG+81YWwUNqxL47kkNHZU5ecEbaUto9 ochP8uGU16ud4wv60eNK59ZvoBDzhc5Po2bEQxrJ5c8V5JHX1K2czTnR6IH6aPmycffF/qHXfWHN nSGLsSobByQoGh1GyLfFTXI7QOGn/6qvrJ7x9Oem5V7miUTD0wGAIozD7MCVoluf5Psa4Q2a5AFV gROLty059Ex4oK55Op/0e3Aa/a8hZD/tPBT3WE70owdiCwIDAQABo4IB2zCCAdcwDgYDVR0PAQH/ BAQDAgWgMIGjBggrBgEFBQcBAQSBljCBkzBOBggrBgEFBQcwAoZCaHR0cDovL3NlY3VyZS5nbG9i YWxzaWduLmNvbS9jYWNlcnQvZ3NnY2NyM3BlcnNvbmFsc2lnbjJjYTIwMjAuY3J0MEEGCCsGAQUF BzABhjVodHRwOi8vb2NzcC5nbG9iYWxzaWduLmNvbS9nc2djY3IzcGVyc29uYWxzaWduMmNhMjAy MDBNBgNVHSAERjBEMEIGCisGAQQBoDIBKAowNDAyBggrBgEFBQcCARYmaHR0cHM6Ly93d3cuZ2xv YmFsc2lnbi5jb20vcmVwb3NpdG9yeS8wCQYDVR0TBAIwADBJBgNVHR8EQjBAMD6gPKA6hjhodHRw Oi8vY3JsLmdsb2JhbHNpZ24uY29tL2dzZ2NjcjNwZXJzb25hbHNpZ24yY2EyMDIwLmNybDAlBgNV HREEHjAcgRpzb21uYXRoLmtvdHVyQGJyb2FkY29tLmNvbTATBgNVHSUEDDAKBggrBgEFBQcDBDAf BgNVHSMEGDAWgBSWM9HmWBdbNHWKgVZk1b5I3qGPzzAdBgNVHQ4EFgQUabMpSsFcjDNUWMvGf76o yB7jBJUwDQYJKoZIhvcNAQELBQADggEBAJBDQpQ1TqY57vpQbwtXYP0N01q8J3tfNA/K2vOiNOpv IufqZ5WKdKEtmT21nujCeuaCQ6SmpWqCUJVkLd+u/sHR62vCo8j2fb1pTkA7jeuCAuT9YMPRE86M sUphsGDq2ylriQ7y5kvl728hZ0Oakm3xUCnZ9DYS/32sFGSZyrCGZipTBnjK4n5uLQ0yekSLACiD R0zi4nzkbhwXqDbDaB+Duk52ec/Vj4xuc2uWu9rTmJNVjdk0qu9vh48xcd/BzrlmwY0crGTijAC/ r4x2/y9OfG0FyVmakU0qwDnZX982aa66tXnKNgae2k20WCDVMM5FPTrbMsQyz6Hrv3bg6qgxggJt MIICaQIBATBrMFsxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYD VQQDEyhHbG9iYWxTaWduIEdDQyBSMyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwAgx6wAr6NdQY0sTG G7cwDQYJYIZIAWUDBAIBBQCggdQwLwYJKoZIhvcNAQkEMSIEICIA+BJL6iw8JnA489A01e1eg5Zq ZjZh2duGbOykbUcmMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkFMQ8XDTIz MTIxMzAzMDcxOVowaQYJKoZIhvcNAQkPMVwwWjALBglghkgBZQMEASowCwYJYIZIAWUDBAEWMAsG CWCGSAFlAwQBAjAKBggqhkiG9w0DBzALBgkqhkiG9w0BAQowCwYJKoZIhvcNAQEHMAsGCWCGSAFl AwQCATANBgkqhkiG9w0BAQEFAASCAQA21taAIV/ku/fdmwKWZTd5V4IrNNOKMF6ti7dCnkqNTCG3 7YTECqXn8wqxGxw+7fT+SdSnzL0XEijCWIjM4gPvlemjRrzWLGj1Uf/TKVawzXWbIJIwvhzMTFMh ev7wZdGJ2DqvuHRC+S3oLGVcWPDcvIAXm2suTyHi6ZWfEXxmTeW+iA2G2Z7VcZRaL1eqS0nflTDr geDZtHexLQaw+ogYL4PvezSsX57nLNnHoeo712WeEMhMaE2KGkxQUjmpApeEOpu4iio3X4/XhqSq FhAqEI2v0Ajwx+T/hjcaKh6OlB0cR+A4YE3jMZD16iEiMe/YJH0NC4PY8KrpagRMAciT --00000000000017471b060c5b77bb--