From: Somnath Kotur <somnath.kotur@broadcom.com>
To: Thierry Herbelot <thierry.herbelot@6wind.com>
Cc: dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
Ajit Khaparde <ajit.khaparde@broadcom.com>
Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix compilation error on Redhat 8
Date: Fri, 18 Sep 2020 12:42:02 +0530 [thread overview]
Message-ID: <CAOBf=muEsQ0=KObmVvw9eTF3pNkFbcVhDEdJNhE=Fb7mL8XYWA@mail.gmail.com> (raw)
In-Reply-To: <20200918070155.31789-1-thierry.herbelot@6wind.com>
On Fri, Sep 18, 2020 at 12:32 PM Thierry Herbelot
<thierry.herbelot@6wind.com> wrote:
>
> .../drivers/net/bnxt/tf_ulp/ulp_def_rules.c: In function ‘bnxt_ulp_destroy_df_rules’:
> .../dpdk/drivers/net/bnxt/tf_ulp/ulp_def_rules.c:425:28: error:
> comparison is always true due to limited range of data type [-Werror=type-limits]
> for (port_id = 0; port_id < RTE_MAX_ETHPORTS; port_id++) {
> ^
>
> Fixes: 769de16872ab9 ('net/bnxt: fix port default rule create/destroy')
> Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Cc: Somnath Kotur <somnath.kotur@broadcom.com>
>
> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> ---
> drivers/net/bnxt/tf_ulp/ulp_def_rules.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bnxt/tf_ulp/ulp_def_rules.c b/drivers/net/bnxt/tf_ulp/ulp_def_rules.c
> index 9fb1a028ff66..ff5aed3d74c4 100644
> --- a/drivers/net/bnxt/tf_ulp/ulp_def_rules.c
> +++ b/drivers/net/bnxt/tf_ulp/ulp_def_rules.c
> @@ -397,7 +397,7 @@ void
> bnxt_ulp_destroy_df_rules(struct bnxt *bp, bool global)
> {
> struct bnxt_ulp_df_rule_info *info;
> - uint8_t port_id;
> + uint16_t port_id;
>
> if (!BNXT_TRUFLOW_EN(bp) ||
> BNXT_ETH_DEV_IS_REPRESENTOR(bp->eth_dev))
> --
> 2.27.0
>
Acked-by: Somnath Kotur <somnath.kotur@broadcom.com>
next prev parent reply other threads:[~2020-09-18 7:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 7:01 Thierry Herbelot
2020-09-18 7:12 ` Somnath Kotur [this message]
2020-09-18 7:31 ` David Marchand
2020-09-18 16:16 ` Ajit Khaparde
2020-09-20 15:26 ` Xia, Chenbo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOBf=muEsQ0=KObmVvw9eTF3pNkFbcVhDEdJNhE=Fb7mL8XYWA@mail.gmail.com' \
--to=somnath.kotur@broadcom.com \
--cc=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=thierry.herbelot@6wind.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).