From: Somnath Kotur <somnath.kotur@broadcom.com>
To: Lance Richardson <lance.richardson@broadcom.com>
Cc: dev <dev@dpdk.org>,
Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>,
Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Subject: Re: [dpdk-dev] [PATCH 2/2] net/bnxt: set Rx checksum flags in vector mode receive
Date: Tue, 30 Jul 2019 21:15:08 +0530 [thread overview]
Message-ID: <CAOBf=muquHRtS+gURS+PKOFuSj6iM4jDuRHwLS1j8FdY+OxiwQ@mail.gmail.com> (raw)
In-Reply-To: <20190729212825.5077-1-lance.richardson@broadcom.com>
On Tue, Jul 30, 2019 at 2:58 AM Lance Richardson
<lance.richardson@broadcom.com> wrote:
>
> From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
>
> Fixed to return the checksum status of rx packets by setting
> "ol_flags" correctly in vector mode receive.
>
> These changes have been there for non vector mode receive.
> In vector mode receive also indicate inner and outer checksum
> errors individually in "ol_flag" to indicate L3 and L4 error.
>
> Fixes: bc4a000f2f53 ("net/bnxt: implement SSE vector mode")
>
> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> Reviewed-by: Lance Richardson <lance.richardson@broadcom.com>
> Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>
> ---
> drivers/net/bnxt/bnxt_rxtx_vec_sse.c | 47 ++++++++++++++++++++++++++++
> 1 file changed, 47 insertions(+)
>
> diff --git a/drivers/net/bnxt/bnxt_rxtx_vec_sse.c b/drivers/net/bnxt/bnxt_rxtx_vec_sse.c
> index adc5020ec..2e6e83c94 100644
> --- a/drivers/net/bnxt/bnxt_rxtx_vec_sse.c
> +++ b/drivers/net/bnxt/bnxt_rxtx_vec_sse.c
> @@ -157,6 +157,52 @@ bnxt_parse_pkt_type(struct rx_pkt_cmpl *rxcmp, struct rx_pkt_cmpl_hi *rxcmp1)
> return pkt_type;
> }
>
> +static void
> +bnxt_parse_csum(struct rte_mbuf *mbuf, struct rx_pkt_cmpl_hi *rxcmp1)
> +{
> + uint32_t flags;
> +
> + flags = flags2_0xf(rxcmp1);
> + /* IP Checksum */
> + if (likely(IS_IP_NONTUNNEL_PKT(flags))) {
> + if (unlikely(RX_CMP_IP_CS_ERROR(rxcmp1)))
> + mbuf->ol_flags |= PKT_RX_IP_CKSUM_BAD;
> + else
> + mbuf->ol_flags |= PKT_RX_IP_CKSUM_GOOD;
> + } else if (IS_IP_TUNNEL_PKT(flags)) {
> + if (unlikely(RX_CMP_IP_OUTER_CS_ERROR(rxcmp1) ||
> + RX_CMP_IP_CS_ERROR(rxcmp1)))
> + mbuf->ol_flags |= PKT_RX_IP_CKSUM_BAD;
> + else
> + mbuf->ol_flags |= PKT_RX_IP_CKSUM_GOOD;
> + } else if (unlikely(RX_CMP_IP_CS_UNKNOWN(rxcmp1))) {
> + mbuf->ol_flags |= PKT_RX_IP_CKSUM_UNKNOWN;
> + }
> +
> + /* L4 Checksum */
> + if (likely(IS_L4_NONTUNNEL_PKT(flags))) {
> + if (unlikely(RX_CMP_L4_INNER_CS_ERR2(rxcmp1)))
> + mbuf->ol_flags |= PKT_RX_L4_CKSUM_BAD;
> + else
> + mbuf->ol_flags |= PKT_RX_L4_CKSUM_GOOD;
> + } else if (IS_L4_TUNNEL_PKT(flags)) {
> + if (unlikely(RX_CMP_L4_INNER_CS_ERR2(rxcmp1)))
> + mbuf->ol_flags |= PKT_RX_L4_CKSUM_BAD;
> + else
> + mbuf->ol_flags |= PKT_RX_L4_CKSUM_GOOD;
> + if (unlikely(RX_CMP_L4_OUTER_CS_ERR2(rxcmp1))) {
> + mbuf->ol_flags |= PKT_RX_OUTER_L4_CKSUM_BAD;
> + } else if (unlikely(IS_L4_TUNNEL_PKT_ONLY_INNER_L4_CS
> + (flags))) {
> + mbuf->ol_flags |= PKT_RX_OUTER_L4_CKSUM_UNKNOWN;
> + } else {
> + mbuf->ol_flags |= PKT_RX_OUTER_L4_CKSUM_GOOD;
> + }
> + } else if (unlikely(RX_CMP_L4_CS_UNKNOWN(rxcmp1))) {
> + mbuf->ol_flags |= PKT_RX_L4_CKSUM_UNKNOWN;
> + }
> +}
> +
> uint16_t
> bnxt_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,
> uint16_t nb_pkts)
> @@ -254,6 +300,7 @@ bnxt_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,
> mbuf->ol_flags |= PKT_RX_VLAN;
> }
>
> + bnxt_parse_csum(mbuf, rxcmp1);
> mbuf->packet_type = bnxt_parse_pkt_type(rxcmp, rxcmp1);
>
> rx_pkts[nb_rx_pkts++] = mbuf;
> --
> 2.17.1
>
Acked-by: Somnath Kotur <somnath.kotur@broadcom.com>
next prev parent reply other threads:[~2019-07-30 15:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 21:28 Lance Richardson
2019-07-30 15:32 ` Ferruh Yigit
2019-07-30 15:45 ` Somnath Kotur
2019-07-30 15:45 ` Somnath Kotur [this message]
2019-07-30 17:23 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOBf=muquHRtS+gURS+PKOFuSj6iM4jDuRHwLS1j8FdY+OxiwQ@mail.gmail.com' \
--to=somnath.kotur@broadcom.com \
--cc=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=lance.richardson@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).