DPDK patches and discussions
 help / color / mirror / Atom feed
From: Somnath Kotur <somnath.kotur@broadcom.com>
To: wangyunjian <wangyunjian@huawei.com>
Cc: dev <dev@dpdk.org>,
	Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>,
	jerry.lilijun@huawei.com,  xudingke@huawei.com,
	dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix missed unlock reported by coverity
Date: Wed, 27 May 2020 17:43:12 +0530	[thread overview]
Message-ID: <CAOBf=mvCQwgO+r6D5LsG0nrTcMWC3D_mYkAarDNfZxjensu5WA@mail.gmail.com> (raw)
In-Reply-To: <c1ce7c941e28d75d8b1fe140cadcd70a3fdf19c2.1590580273.git.wangyunjian@huawei.com>

On Wed, May 27, 2020 at 5:42 PM wangyunjian <wangyunjian@huawei.com> wrote:
>
> From: Yunjian Wang <wangyunjian@huawei.com>
>
> Coverity issue: 357741
> Fixes: 02a95625fe9c ("net/bnxt: add flow stats in extended stats")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> ---
>  drivers/net/bnxt/bnxt_stats.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/bnxt/bnxt_stats.c b/drivers/net/bnxt/bnxt_stats.c
> index cfe193284..8df6922f5 100644
> --- a/drivers/net/bnxt/bnxt_stats.c
> +++ b/drivers/net/bnxt/bnxt_stats.c
> @@ -1008,8 +1008,10 @@ int bnxt_flow_stats_req(struct bnxt *bp)
>                 }
>         }
>
> -       if (!in_flow_tbl_cnt)
> +       if (!in_flow_tbl_cnt) {
> +               bnxt_release_flow_lock(bp);
>                 goto out;
> +       }
>
>         rc = bnxt_update_fc_tbl(bp, counter_type, valid_en_tbl,
>                                 in_flow_tbl_cnt);
> --
> 2.23.0
>
>
Acked-by: Somnath Kotur <somnath.kotur@broadcom.com>

  reply	other threads:[~2020-05-27 12:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-27 12:11 wangyunjian
2020-05-27 12:13 ` Somnath Kotur [this message]
2020-05-28  1:05   ` Ajit Khaparde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOBf=mvCQwgO+r6D5LsG0nrTcMWC3D_mYkAarDNfZxjensu5WA@mail.gmail.com' \
    --to=somnath.kotur@broadcom.com \
    --cc=ajit.khaparde@broadcom.com \
    --cc=dev@dpdk.org \
    --cc=jerry.lilijun@huawei.com \
    --cc=stable@dpdk.org \
    --cc=wangyunjian@huawei.com \
    --cc=xudingke@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).