From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 32E11A034E; Wed, 27 May 2020 14:13:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CC0491D922; Wed, 27 May 2020 14:13:26 +0200 (CEST) Received: from mail-vk1-f195.google.com (mail-vk1-f195.google.com [209.85.221.195]) by dpdk.org (Postfix) with ESMTP id 035501D915 for ; Wed, 27 May 2020 14:13:24 +0200 (CEST) Received: by mail-vk1-f195.google.com with SMTP id f126so3251816vkb.13 for ; Wed, 27 May 2020 05:13:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Jocsvn6VoWL4b7Acq+SOQ7Jm7s5gVGzSPO42zrzeGq4=; b=MQ8bI36MNzdq/cFYxVk510V00WnmLFmATFROzdDbuKy2DoJkjF5CxiN86rJyC9QedT I5Tgag4/gmvCw5T+nkrE7FOHQgSbvcnxfo/B6oZv3SqkqDXdA6hfKRYNJnIDxtmQB/gf BdMqMhhcaab1EAmG+bR2DCmlg4wo6vx4nh75M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Jocsvn6VoWL4b7Acq+SOQ7Jm7s5gVGzSPO42zrzeGq4=; b=QPyeL8IAY2VT43LKSV+pKHJlh1qnlSUT93+mfmD0NcErZvuRYK1bXJsYjbdZC+PpRA 4Q2xLCeUwK4N66HKlBUDg9b5igJ6mojMb5U64Egze8TIHhpSR7G/CIwB9WwNTo5xbPQH 04RId8Yp2cSyvBM/KE6PVStCeksrWf+OzOTLSRGTZDdlq91il1jxwy3Dh7+EwZ5Bh8V6 dQsHh3kP0kmJEyhwjEQtZMGnersWtTsHz0EJLkgGZIkHJOUGdB812qwI0uhLr18Oc+YZ dR/VbvejyGCAeRUQzOEl1NJGVEKeoOjdyKpvlBRxecsp2bylF9RvnXCqXnuTXDl7SyHv 5pLw== X-Gm-Message-State: AOAM533rF8Qqa1ywc6HOJ05n5BuuQbY4gf0vh2Gq3iZLTg8Gk3U8Udx1 yiRcMgoBg5OOKq2z6MwEkF5bjtxwU+SqLvN53VZmtw== X-Google-Smtp-Source: ABdhPJwxT0zhzPUln7oCO6EKrr1HPqUhOQ2uOynZzJWZ+vkdWBXzryA9k4Xg/DNnMSUE+ftHWdKfDE9y/T4vmsaj8OA= X-Received: by 2002:ac5:cdcc:: with SMTP id u12mr2099778vkn.32.1590581604232; Wed, 27 May 2020 05:13:24 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Somnath Kotur Date: Wed, 27 May 2020 17:43:12 +0530 Message-ID: To: wangyunjian Cc: dev , Ajit Kumar Khaparde , jerry.lilijun@huawei.com, xudingke@huawei.com, dpdk stable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix missed unlock reported by coverity X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, May 27, 2020 at 5:42 PM wangyunjian wrote: > > From: Yunjian Wang > > Coverity issue: 357741 > Fixes: 02a95625fe9c ("net/bnxt: add flow stats in extended stats") > Cc: stable@dpdk.org > > Signed-off-by: Yunjian Wang > --- > drivers/net/bnxt/bnxt_stats.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/bnxt/bnxt_stats.c b/drivers/net/bnxt/bnxt_stats.c > index cfe193284..8df6922f5 100644 > --- a/drivers/net/bnxt/bnxt_stats.c > +++ b/drivers/net/bnxt/bnxt_stats.c > @@ -1008,8 +1008,10 @@ int bnxt_flow_stats_req(struct bnxt *bp) > } > } > > - if (!in_flow_tbl_cnt) > + if (!in_flow_tbl_cnt) { > + bnxt_release_flow_lock(bp); > goto out; > + } > > rc = bnxt_update_fc_tbl(bp, counter_type, valid_en_tbl, > in_flow_tbl_cnt); > -- > 2.23.0 > > Acked-by: Somnath Kotur