From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EA06BA0C53; Wed, 3 Nov 2021 15:39:11 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7A73A42716; Wed, 3 Nov 2021 15:39:09 +0100 (CET) Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) by mails.dpdk.org (Postfix) with ESMTP id 287DB4270E for ; Wed, 3 Nov 2021 15:39:08 +0100 (CET) Received: by mail-ed1-f53.google.com with SMTP id o8so10062678edc.3 for ; Wed, 03 Nov 2021 07:39:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CFp8sJ8lzAq7yssiHYorT7ctNKydw8EXrYAajffY5k0=; b=LwlqKQcAuZwsgMo0zKDSB2UqtqK8VmSXnL/Yo3Yzm3Viksm41R6sgRXzcbf3X+MCVu v88wCRmxrqYYuV4WMXCRLjYdaTVAMF3uYDsdY3jHTYEEjC1BXRr8epYUpXbOh+KUf4HN 4qubZ/VkYsdgxG6DxlB12SqaMRMfXt1DNV8Vs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CFp8sJ8lzAq7yssiHYorT7ctNKydw8EXrYAajffY5k0=; b=sWQmCEM7HvqbOldqkgkj9jGQnYfp60y8vIUh29L7+CM0iyh381g3odCIxEzSHtpoSI 1Vm2UC5qbF/xlgn1h7FgUA3DKTX5Jfb7wBlWLlq1D2lfGFfG4qODkj5Q7OFoqlmS7v5S DTELyNdhbv8f8cD+xRMgo5RTmniibBAsFo358J1O6ravIMPEtWwU7x60tfAp7ZURryat JxgxgMedkJ0y5y99QZs/qLrjX9bBm8Zb/ptWr6DfBKOd6XwkRWfoRFPcF5JrbTqTyiVg ay7D4QNnRW6wYkAYo+BGiO+5rUpnYEFp/PIr4waH2inCQ81BcXc18VhV3+4T+gm1fTJo WLPQ== X-Gm-Message-State: AOAM5305Pv1pBVKpCpF1WWuk5iw1POXEYZ6J5TDoX1E95Fxs8X0h3D2D MAMt8zcN7BCkPlcWTl0I2MIaJApxCKL1vdD+bAs/cgowZe8= X-Google-Smtp-Source: ABdhPJxkMbjOthLGQfDamnbdsRkVwutUZ3HS+LSZ4hij1NAFD2zOvvJpo3O7V/zqJk9Pg7lHnui7CI8qsotBne9STfw= X-Received: by 2002:a17:906:4fcd:: with SMTP id i13mr17037027ejw.472.1635950344576; Wed, 03 Nov 2021 07:39:04 -0700 (PDT) MIME-Version: 1.0 References: <20211102104748.57078-1-maxime.coquelin@redhat.com> <3a63bda9-2ff7-30bc-87b7-48e1324d1666@redhat.com> <242aa665-45b6-2441-4288-26a4056dc3e2@redhat.com> <75726d5f-35b9-4d59-7bde-483cb1c5475e@redhat.com> In-Reply-To: <75726d5f-35b9-4d59-7bde-483cb1c5475e@redhat.com> From: Lincoln Lavoie Date: Wed, 3 Nov 2021 10:38:53 -0400 Message-ID: To: Maxime Coquelin Cc: David Marchand , "Xia, Chenbo" , "dev@dpdk.org" , "Liu, Changpeng" , Thomas Monjalon , Aaron Conole , dpdklab , ci@dpdk.org, Owen Hilyard Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [dpdklab] Re: [PATCH] vhost: rename driver callbacks struct X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Nov 3, 2021 at 9:16 AM Maxime Coquelin wrote: > > > On 11/3/21 14:11, Lincoln Lavoie wrote: > > > > > > > > On Wed, Nov 3, 2021 at 5:53 AM Maxime Coquelin > > > wrote: > > > > > > > > On 11/3/21 09:38, Maxime Coquelin wrote: > > > Hi David, > > > > > > On 11/3/21 09:36, David Marchand wrote: > > >> On Wed, Nov 3, 2021 at 9:16 AM Xia, Chenbo > > wrote: > > >>> Testing issues reported in patchwork is expected as SPDK uses > > >>> this struct, so we can ignore it as SPDK will rename it when it > > >>> adapts to DPDK 21.11 > > >> > > >> Please, no. > > >> We can't simply say "ignore failure in CI". > > >> > > >> The SPDK build test must be disabled in CI first. > > >> You can create a bugzilla and assign it to UNH lab. > > >> Example: https://bugs.dpdk.org/show_bug.cgi?id=579 > > > > >> > > >> Once done, we can merge this patch in DPDK. > > >> > > >> > > >> In parallel, either prepare the patch or talk to SPDK guys to > handle > > >> this change. > > >> Once this is done, update the bugzilla so that we can get SPDK > build > > >> tested again in CI. > > > > > > Thanks for the insights, I'll file a Bz and work with the SPDK > team. > > > > The Bz has been filed: > > https://bugs.dpdk.org/show_bug.cgi?id=876 > > > > > > > Maxime > > >> Thanks. > > >> > > >> > > > > SDPK tests have been disabled in the CI testing and shouldn't run for > > any new patches. Anything that was already in the queue will finish > > out. Bug ticket has been updated. > > Thanks Lincoln, as the patch wasn't merged yet, this API change will not > impact other jobs already queued. > > > Who from the SPDK team "has the ball" on this item, so we know it's > > being tracked and worked on? > > I think Changpeng Liu in Cc: is the right contact from the SPDK team for > this. For my information, are the SPDK tests based on their main branch > or on the last release? > SDPK branch should be their current LTS branch (21.1.x), so not the main branch. > > Thanks, > Maxime > > > Cheers, > > Lincoln > > > > > > -- > > *Lincoln Lavoie* > > Principal Engineer, Broadband Technologies > > 21 Madbury Rd., Ste. 100, Durham, NH 03824 > > lylavoie@iol.unh.edu > > https://www.iol.unh.edu > > +1-603-674-2755 (m) > > > > -- *Lincoln Lavoie* Principal Engineer, Broadband Technologies 21 Madbury Rd., Ste. 100, Durham, NH 03824 lylavoie@iol.unh.edu https://www.iol.unh.edu +1-603-674-2755 (m)