From: Lincoln Lavoie <lylavoie@iol.unh.edu>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dev <dev@dpdk.org>, Zhihong Peng <zhihongx.peng@intel.com>,
Neil Horman <nhorman@tuxdriver.com>,
ci@dpdk.org
Subject: Re: [dpdk-dev] [dpdk-ci] [PATCH v2] pmdinfogen: allow padding after NUL terminator
Date: Wed, 9 Jun 2021 12:01:00 -0400 [thread overview]
Message-ID: <CAOE1vsP76g1mzFFSSmZimV+E6YLNdU7FDkP-VjG+awhmg97gsA@mail.gmail.com> (raw)
In-Reply-To: <20210609185219.5eefdddd@sovereign>
Hi Dmitry,
If the failing test is the unit test func_reentrancy_autotest, that is
being looked into , as it seems like the test case does not reliably run.
It passes / fails between different systems running both on bare metal and
in virtual environments, on different OSes and architectures.
Do you have a link to your patch in patchworks or the lab dashboard?
Cheers,
Lincoln
On Wed, Jun 9, 2021 at 11:52 AM Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
wrote:
> 2021-05-28 00:24 (UTC+0300), Dmitry Kozlyuk:
> > Size of string constant symbol may be larger than its length
> > measured up to NUL terminator. In this case pmdinfogen included padding
> > bytes after NUL terminator in generated source, yielding incorrect code.
> >
> > Always trim string data to NUL terminator while reading ELF.
> > It was already done for COFF because there's no symbol size.
> >
> > Bugzilla ID: 720
> > Fixes: f0f93a7adfee ("buildtools: use Python pmdinfogen")
> >
> > Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> > ---
> > v2: return helper to coff.py, where it's needed (David Marchand).
> >
> > buildtools/pmdinfogen.py | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/buildtools/pmdinfogen.py b/buildtools/pmdinfogen.py
> > index 7a739ec7d4..2a44f17bda 100755
> > --- a/buildtools/pmdinfogen.py
> > +++ b/buildtools/pmdinfogen.py
> > @@ -28,7 +28,7 @@ def __init__(self, image, symbol):
> > def string_value(self):
> > size = self._symbol["st_size"]
> > value = self.get_value(0, size)
> > - return value[:-1].decode() if value else ""
> > + return coff.decode_asciiz(value) # not COFF-specific
> >
> > def get_value(self, offset, size):
> > section = self._symbol["st_shndx"]
>
> There are CI failures that seem unrelated to this patch:
> some tests with NICs that I can't check
> and an Arch Linux build failure that I failed to reproduce.
> GitHub Actions are passing.
> Are these known CI bugs or does this patch need any corrections?
>
--
*Lincoln Lavoie*
Principal Engineer, Broadband Technologies
21 Madbury Rd., Ste. 100, Durham, NH 03824
lylavoie@iol.unh.edu
https://www.iol.unh.edu
+1-603-674-2755 (m)
<https://www.iol.unh.edu>
next prev parent reply other threads:[~2021-06-09 16:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 21:43 [dpdk-dev] [PATCH] " Dmitry Kozlyuk
2021-05-27 6:53 ` David Marchand
2021-05-27 7:09 ` Dmitry Kozlyuk
2021-05-27 7:31 ` David Marchand
2021-05-27 21:24 ` [dpdk-dev] [PATCH v2] " Dmitry Kozlyuk
2021-06-09 15:52 ` Dmitry Kozlyuk
2021-06-09 16:01 ` Lincoln Lavoie [this message]
2021-06-09 16:48 ` [dpdk-dev] [dpdk-ci] " Dmitry Kozlyuk
2021-06-09 17:19 ` Owen Hilyard
2021-06-18 14:39 ` [dpdk-dev] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOE1vsP76g1mzFFSSmZimV+E6YLNdU7FDkP-VjG+awhmg97gsA@mail.gmail.com \
--to=lylavoie@iol.unh.edu \
--cc=ci@dpdk.org \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=nhorman@tuxdriver.com \
--cc=zhihongx.peng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).