Recently I have submitted patches and some tests were failing on patchwork. My question is, which tests are compulsory to pass for a patch to be accepted. As in the below mentioned patch, it is accepted while 1 test was still failing. http://patches.dpdk.org/patch/70348/ kind regards. Muhammad Bilal
On Thu, 28 May 2020 01:13:27 +0500
Muhammad Bilal <m.bilal@emumba.com> wrote:
> Recently I have submitted patches and some tests were failing on patchwork.
> My question is, which tests are compulsory to pass for a patch to be accepted.
> As in the below mentioned patch, it is accepted while 1 test was still failing.
> http://patches.dpdk.org/patch/70348/
>
> kind regards.
> Muhammad Bilal
There are two different issues:
1. A patch should not get blamed for some failure in the CI infrastructure.
Or collataral damage from an earlier merge.
2. A patch must not introduce a failure. I.e. if all tests passed before
each patch in a patchset must pass.
Thank you for your response.
How will we know if a patch is failing because of some failure in the
CI infrastructure or due to earlier merge?
On Thu, May 28, 2020 at 1:59 AM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> On Thu, 28 May 2020 01:13:27 +0500
> Muhammad Bilal <m.bilal@emumba.com> wrote:
>
> > Recently I have submitted patches and some tests were failing on patchwork.
> > My question is, which tests are compulsory to pass for a patch to be accepted.
> > As in the below mentioned patch, it is accepted while 1 test was still failing.
> > http://patches.dpdk.org/patch/70348/
> >
> > kind regards.
> > Muhammad Bilal
>
> There are two different issues:
> 1. A patch should not get blamed for some failure in the CI infrastructure.
> Or collataral damage from an earlier merge.
> 2. A patch must not introduce a failure. I.e. if all tests passed before
> each patch in a patchset must pass.