From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E865BA0540; Thu, 16 Jul 2020 06:58:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CF9A91BEA9; Thu, 16 Jul 2020 06:58:59 +0200 (CEST) Received: from mail-il1-f196.google.com (mail-il1-f196.google.com [209.85.166.196]) by dpdk.org (Postfix) with ESMTP id A23C51BEA1 for ; Thu, 16 Jul 2020 06:58:58 +0200 (CEST) Received: by mail-il1-f196.google.com with SMTP id t27so3960979ill.9 for ; Wed, 15 Jul 2020 21:58:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emumba-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=flO36vhhCK7qLbBXvR+mTwvHOUz1943XQ2nyI77Dz0w=; b=mK2KzAYaDH7r2367x47xVq9Q5DLrrSNBiVVDc95jZJlnbVuHe+ByDy0Tw+wIpUb2Ui BlIMW1LHZ4jyYSkfDU2HJmY9o5maPDRnAk1Qj7OD9g2jcK4OA/uGl5toDjK56Y8zMMYR nAWwwuBr6LX7YRr0msFl35TveRYIRHYGrU/Pf0TM9x9cQRbCunAwYulOXwDNQhJNfkMl wbJBNa8w7IT192ZPNQ67tPJDHvzJk+JG4Hsv33KMjed1O42iT/CjTiIVWRH0ydTiMpw/ oq1Rm4nt7GA6ThmZnjyxjDr2XaOHJiSnbjy2LQ7N/JFvdDKmATFlKXz+kq4OA3M1e4jn RY2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=flO36vhhCK7qLbBXvR+mTwvHOUz1943XQ2nyI77Dz0w=; b=AN/CvI3JXOedlaD+asuCC+PFGfr74HM70iKmYcTqdptaYtE6nRHRl/TftZFIJYcvYX vbr4yLdEkgacB19CTeO3L0Bd++73T17iELDOsvZh/cljPWGwkRh9+/naB5NVmbf2Yv7w VsLke66orUOcxEn+1V5cs6wErA6Pt3gd0/QfqCXhwWcgK7O0n17ZjJcfGn9RJiWN74yx cgRxCthvNti7Vc2/+bn9R20yCFGukg1HbGro+z3t07wFDjUPjCYywzjrZFiY/qTq4+Lv jBSSI/rkx31v8IHRmFvhb8Gqi/QWWRHcBR11UAj1SxYKyD1hew5suBZatr8lk3xPGKWm 1k9g== X-Gm-Message-State: AOAM531BegvsgQvWRMbiv4WlhcMgEh/KubKMckh+P9G9ztcv100wn9qj u8OnmauYNtbjrdFfP8WxhYeBuWTAraBzfPvYm/PYdQ== X-Google-Smtp-Source: ABdhPJyT55WwqI4v8kG0bwKzPf8B46FOJ0s0r0t+SEg1Hv9IAqTa8daz7uxIVqUXOzjqdWxyu4RnzyEYD+jwWMEKoGk= X-Received: by 2002:a92:d6d2:: with SMTP id z18mr2850706ilp.272.1594875537975; Wed, 15 Jul 2020 21:58:57 -0700 (PDT) MIME-Version: 1.0 References: <20200714155847.51442-1-m.bilal@emumba.com> <093266f0-1938-026e-1d7e-71db9ee92499@intel.com> In-Reply-To: <093266f0-1938-026e-1d7e-71db9ee92499@intel.com> From: Muhammad Bilal Date: Thu, 16 Jul 2020 09:58:47 +0500 Message-ID: To: Ferruh Yigit Cc: beilei.xing@intel.com, xiaolong.ye@intel.com, dev@dpdk.org, stable@dpdk.org, zijie.pan@6wind.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] drivers/net/i40e: fixed misplaced arguments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Yes, This is the patch for the same bug, Which is already fixed. So this duplicate patch can be ignored. On Tue, Jul 14, 2020 at 9:54 PM Ferruh Yigit wrote: > > On 7/14/2020 4:58 PM, Muhammad Bilal wrote: > > Here I have corrected a misplaced argument of i40e_aq_get_phy_register() > > This was also evident after seeing the datatype of its arguments. > > > > Fixes: 98e60c0d43f1 ("net/i40e: add module EEPROM callbacks for i40e") > > Cc: zijie.pan@6wind.com > > > > Bugzilla ID: 506 > > Signed-off-by: Muhammad Bilal > > --- > > drivers/net/i40e/i40e_ethdev.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c > > index 970a31cb2..5fdfadf7b 100644 > > --- a/drivers/net/i40e/i40e_ethdev.c > > +++ b/drivers/net/i40e/i40e_ethdev.c > > @@ -12093,7 +12093,7 @@ static int i40e_get_module_eeprom(struct rte_eth_dev *dev, > > } > > status = i40e_aq_get_phy_register(hw, > > I40E_AQ_PHY_REG_ACCESS_EXTERNAL_MODULE, > > - addr, offset, 1, &value, NULL); > > + addr, 1, offset, &value, NULL); > > if (status) > > return -EIO; > > data[i] = (uint8_t)value; > > > > Hi Muhammad, > > This seems already fixed [1], can you please double check in the 'v20.08-rc1'? > > > > [1] > https://git.dpdk.org/dpdk/commit/?id=2fc1d6da882563ab80786d69b6d7c9d0e4ce860a > https://patches.dpdk.org/patch/72827/