DPDK patches and discussions
 help / color / mirror / Atom feed
From: Vladislav Zolotarov <vladz@cloudius-systems.com>
To: Helin Zhang <helin.zhang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4] ixgbe: Drop flow control frames from VFs
Date: Fri, 23 Oct 2015 09:24:11 +0300	[thread overview]
Message-ID: <CAOYyTHY6hAjcd7z678Mz-mBQ27gRw=VhLS-gnxQ4puxsWnNytg@mail.gmail.com> (raw)
In-Reply-To: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A91C5F9@SHSMSX104.ccr.corp.intel.com>

On Oct 23, 2015 9:02 AM, "Zhang, Helin" <helin.zhang@intel.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Lu, Wenzhuo
> > Sent: Friday, October 23, 2015 1:52 PM
> > To: dev@dpdk.org
> > Cc: Zhang, Helin; Lu, Wenzhuo
> > Subject: [PATCH v4] ixgbe: Drop flow control frames from VFs
> >
> > This patch will drop flow control frames from being transmitted from
VSIs.
> > With this patch in place a malicious VF cannot send flow control or PFC
packets
> > out on the wire.

The whole idea of this (and similar i40e patches sent before) is really
confusing.
If u want to disable FC feature for VFs then go and disable the feature.
Why keep (not malicious) user think that he/she has enabled the feature
while u silently block it?


> >
> > V2:
> > Reword the comments.
> >
> > V3:
> > Move the check of set_ethertype_anti_spoofing to the top of the
function, to
> > avoid occupying an ethertype_filter entity without using it.
> >
> > V4:
> > Remove the useless braces and return.
> >
> > Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> Acked-by: Helin Zhang <helin.zhang@intel.com>
>

  reply	other threads:[~2015-10-23  6:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-10  2:56 [dpdk-dev] [PATCH] ixgbe: workaround for Security issue in SR-IOV mode Wenzhuo Lu
2015-10-22  7:34 ` [dpdk-dev] [PATCH v2] ixgbe: Drop flow control frames from VFs Wenzhuo Lu
2015-10-23  2:49   ` Zhang, Helin
2015-10-23  3:26     ` Lu, Wenzhuo
2015-10-23  5:52 ` [dpdk-dev] [PATCH v4] " Wenzhuo Lu
2015-10-23  6:02   ` Zhang, Helin
2015-10-23  6:24     ` Vladislav Zolotarov [this message]
2015-10-23  6:30       ` Zhang, Helin
2015-10-23  6:57         ` Vladislav Zolotarov
2015-10-23  7:14           ` Zhang, Helin
2015-10-23  8:27             ` Vlad Zolotarov
2015-10-23  8:32               ` Zhang, Helin
2015-10-23  9:00                 ` Vlad Zolotarov
2015-10-26  0:47                   ` Zhang, Helin
2015-10-28 16:42     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOYyTHY6hAjcd7z678Mz-mBQ27gRw=VhLS-gnxQ4puxsWnNytg@mail.gmail.com' \
    --to=vladz@cloudius-systems.com \
    --cc=dev@dpdk.org \
    --cc=helin.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).