From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yk0-f181.google.com (mail-yk0-f181.google.com [209.85.160.181]) by dpdk.org (Postfix) with ESMTP id B2F7E9A8D for ; Fri, 23 Oct 2015 08:24:12 +0200 (CEST) Received: by ykaz22 with SMTP id z22so108920595yka.2 for ; Thu, 22 Oct 2015 23:24:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=DOfeRSwMvRt8aw94DST3QpFZRg6JI3WRj5wts1sQI3I=; b=TKO+Ik/mNjoSxC8SGc3zMuL7Kp1haGM2LGRIVkeM6vhZX9/1aJlFm1MK+iDoXs/xyU 5Qdg3OcY+/XlZOGSfSWQaUf0ipZAE02Tdz/laOeXnBFhcTq6Y7jgyUBZNHEnmS+RGnoI u76TOfj9nDAxFB6gxNfAs8qaVZ0d8t5USfq/LqCRlIJG1zSEujapn0m5jbNHV/Xi8HQ6 iN75lzzLxuCjlp0nxjUrZOjmwBPaTA6t7nDIIfDPEoEzbU4GdMmt/DcfPK1t2ccm65up QtxvsTBrH4k8hsJForaLYddENqfBYeziC6bg1DvnF5zdI1OLwrNYLGVj9k620qMMQ6Ma TXKw== X-Gm-Message-State: ALoCoQkVogDdhteSKE6OMxs+KP3Tc48GtJlw+/1TCI/QrsZYowCMilooz/gmG3IG3SEVAPIjyUCR MIME-Version: 1.0 X-Received: by 10.140.147.146 with SMTP id 140mr25201560qht.68.1445581452055; Thu, 22 Oct 2015 23:24:12 -0700 (PDT) Received: by 10.233.221.2 with HTTP; Thu, 22 Oct 2015 23:24:11 -0700 (PDT) Received: by 10.233.221.2 with HTTP; Thu, 22 Oct 2015 23:24:11 -0700 (PDT) In-Reply-To: References: <1444445798-23929-1-git-send-email-wenzhuo.lu@intel.com> <1445579545-2430-1-git-send-email-wenzhuo.lu@intel.com> Date: Fri, 23 Oct 2015 09:24:11 +0300 Message-ID: From: Vladislav Zolotarov To: Helin Zhang Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v4] ixgbe: Drop flow control frames from VFs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Oct 2015 06:24:13 -0000 On Oct 23, 2015 9:02 AM, "Zhang, Helin" wrote: > > > > > -----Original Message----- > > From: Lu, Wenzhuo > > Sent: Friday, October 23, 2015 1:52 PM > > To: dev@dpdk.org > > Cc: Zhang, Helin; Lu, Wenzhuo > > Subject: [PATCH v4] ixgbe: Drop flow control frames from VFs > > > > This patch will drop flow control frames from being transmitted from VSIs. > > With this patch in place a malicious VF cannot send flow control or PFC packets > > out on the wire. The whole idea of this (and similar i40e patches sent before) is really confusing. If u want to disable FC feature for VFs then go and disable the feature. Why keep (not malicious) user think that he/she has enabled the feature while u silently block it? > > > > V2: > > Reword the comments. > > > > V3: > > Move the check of set_ethertype_anti_spoofing to the top of the function, to > > avoid occupying an ethertype_filter entity without using it. > > > > V4: > > Remove the useless braces and return. > > > > Signed-off-by: Wenzhuo Lu > Acked-by: Helin Zhang >