From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by dpdk.org (Postfix) with ESMTP id 5062D592B for ; Mon, 9 Mar 2015 18:13:33 +0100 (CET) Received: by wivr20 with SMTP id r20so22970478wiv.5 for ; Mon, 09 Mar 2015 10:13:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=p0Db54d2A5tqGAiDqMeI72BaBBQYOis0NlDlvXScZzc=; b=dsQiu8/HvuS/iQRQG+xHSOirHZxzT7EdYhr7EUZTRKuI9VYO8x4zxd2vbnfgbb2zt9 4P6Ybj4xkx9mhLYw6M5YrpVZVZ+gcDifLayIMW+6rGn7TaXQxdwmh+oGCY5wJ5w040qE bWIHhgE08TpBs1H9sliz8fqQzAqVDemjTyUjdUFEhzuhQaKfYyIjm1gFHPgpBwS6HsHW 6vB6Fs1JiDiJQm7HtUcyfNZ8FQ/fyn+vCc7/BsjY8JcEuEd4xun3wDutRgMk4O0oK+pn 0qfYlydgxyHVA9SjFEWRtZis9dLKv/XEV2UngjCoWlOWGZZ6e0DzieAdNakfUzU3mtdv SqcA== X-Gm-Message-State: ALoCoQkFR2rB+/ZEY+Oaq8ok7Y9hjNHqpZnOIpFsqbxYYcyMIZq6PVVmjoObJBPsCo32esvUs9Uy MIME-Version: 1.0 X-Received: by 10.180.9.111 with SMTP id y15mr62753111wia.86.1425921213102; Mon, 09 Mar 2015 10:13:33 -0700 (PDT) Received: by 10.194.179.170 with HTTP; Mon, 9 Mar 2015 10:13:33 -0700 (PDT) Received: by 10.194.179.170 with HTTP; Mon, 9 Mar 2015 10:13:33 -0700 (PDT) In-Reply-To: <2601191342CEEE43887BDE71AB977258213F4E68@irsmsx105.ger.corp.intel.com> References: <1425896433-12452-1-git-send-email-vladz@cloudius-systems.com> <1425896433-12452-2-git-send-email-vladz@cloudius-systems.com> <2601191342CEEE43887BDE71AB977258213F4B37@irsmsx105.ger.corp.intel.com> <54FD7F5A.4090809@intel.com> <2601191342CEEE43887BDE71AB977258213F4B99@irsmsx105.ger.corp.intel.com> <54FDC306.4030503@cloudius-systems.com> <2601191342CEEE43887BDE71AB977258213F4E68@irsmsx105.ger.corp.intel.com> Date: Mon, 9 Mar 2015 19:13:33 +0200 Message-ID: From: Vladislav Zolotarov To: Konstantin Ananyev Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v5 1/3] ixgbe: Cleanups X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Mar 2015 17:13:33 -0000 On Mar 9, 2015 6:39 PM, "Ananyev, Konstantin" wrote: > > > > > -----Original Message----- > > From: Vlad Zolotarov [mailto:vladz@cloudius-systems.com] > > Sent: Monday, March 09, 2015 3:58 PM > > To: Ananyev, Konstantin; Wodkowski, PawelX; dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v5 1/3] ixgbe: Cleanups > > > > > > > > On 03/09/15 13:29, Ananyev, Konstantin wrote: > > > > > >> -----Original Message----- > > >> From: Wodkowski, PawelX > > >> Sent: Monday, March 09, 2015 11:09 AM > > >> To: Ananyev, Konstantin; Vlad Zolotarov; dev@dpdk.org > > >> Subject: Re: [dpdk-dev] [PATCH v5 1/3] ixgbe: Cleanups > > >> > > >> On 2015-03-09 11:49, Ananyev, Konstantin wrote: > > >>> > > >>>> -----Original Message----- > > >>>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Vlad Zolotarov > > >>>> Sent: Monday, March 09, 2015 10:21 AM > > >>>> To: dev@dpdk.org > > >>>> Subject: [dpdk-dev] [PATCH v5 1/3] ixgbe: Cleanups > > >>>> > > >>>> - Removed the not needed casting. > > >>>> - ixgbe_dev_rx_init(): shorten the lines by defining a local alias variable to access > > >>>> &dev->data->dev_conf.rxmode. > > >>>> > > >>>> Signed-off-by: Vlad Zolotarov > > >>>> --- > > >>>> lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 27 ++++++++++++--------------- > > >>>> 1 file changed, 12 insertions(+), 15 deletions(-) > > >>>> > > >>>> diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c > > >>>> index 72c65df..609b5fd 100644 > > >>>> --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c > > >>>> +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c > > >>>> @@ -1032,8 +1032,7 @@ ixgbe_rx_alloc_bufs(struct igb_rx_queue *rxq) > > >>>> int diag, i; > > >>>> > > >>>> /* allocate buffers in bulk directly into the S/W ring */ > > >>>> - alloc_idx = (uint16_t)(rxq->rx_free_trigger - > > >>>> - (rxq->rx_free_thresh - 1)); > > >>>> + alloc_idx = rxq->rx_free_trigger - (rxq->rx_free_thresh - 1); > > >>> I think all these extra casts came in to keep icc 12.* compiling without warnings. > > >>> I am agree that they are unnecessary. > > >>> Though if we still have to support icc 12.* we either need to keep them, or find > > >>> some other way to keep it happy. > > >>> Konstantin > > >>> > > >> What warnings icc 12.* is throwing? > > > Try and see :) > > > > > >> Only warning I can think of here is > > >> signed -> unsigned implicit cast. > > > If I remember things correctly, it considered result at right side of '=' operator as unsigned int, > > > and then complained that we assign it to smaller size (unsigned short) operand. > > > > If that's the case - that's a clear compiler bug. > > Might be, though if we still have to support it, there is no much choice I am afraid. Well to begin with could anybody who has this icc thing (preferably the latest version) post the compilation errors u are talking about. Let's continue this discussion with some specific things in hands. So far there were a lot of "maybe"s and "as far as i remember"s. Could u, guys, pls., be more specific so that i could address the real issues and not just your fears? ;) Thanks, Vlad > > > > > > > > >> Changing '1' to '1U' helps? > > > Don't think so, but you are welcome to try. > > > > > > Konstantin > > > > > >> > > >> -- > > >> Pawel > ,