From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f42.google.com (mail-wg0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 880E46837 for ; Fri, 13 Mar 2015 14:03:39 +0100 (CET) Received: by wghl18 with SMTP id l18so23065889wgh.5 for ; Fri, 13 Mar 2015 06:03:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=fkzHiA0guTxuDreYYK8IWOtKSmHtIjZJdB+qthIh9Ws=; b=VMiWP/GSMScIOLI5YNx1vlxSa7+Q78/UXovnP1qzPCdlKiEdxKgPFyfUuzq5XHc6eP Gy9FF7+zTdEgfngcLpUUm8etAnQDBNCMytH9jaBon07wwxh7EnoB6PvmWM+EY9MGLbK9 269bcuvBsNs61KnL3vuYJfrJi8hl2IDSRv8/LIFjHzWN8PFnEbLmQhaFcsWRAIU6hS8i Noo9dJqB2IoyAUjDxo29ijf+1PjjFOuGwLobycRVDxtb3dbq9iXjcYwEAs9F2FcRRpim NZUIRUqC1YxnS+Es1kN2Uy3GD1LJqoVVTGjbBbySwc1n2hAOe6YFkVUPFpqKsX5t+rB3 Y7og== X-Gm-Message-State: ALoCoQlLEp3N/+8LpWwaqHfbHf5dnBGj5i3vABuQCg+VB9uLNHrYIAzwK1aOoYXag5fUIdF9GnYx MIME-Version: 1.0 X-Received: by 10.180.212.40 with SMTP id nh8mr10982438wic.86.1426251819328; Fri, 13 Mar 2015 06:03:39 -0700 (PDT) Received: by 10.194.179.170 with HTTP; Fri, 13 Mar 2015 06:03:39 -0700 (PDT) Received: by 10.194.179.170 with HTTP; Fri, 13 Mar 2015 06:03:39 -0700 (PDT) In-Reply-To: <2601191342CEEE43887BDE71AB977258213F63E2@irsmsx105.ger.corp.intel.com> References: <1426195052-4640-1-git-send-email-vladz@cloudius-systems.com> <2601191342CEEE43887BDE71AB977258213F5E9B@irsmsx105.ger.corp.intel.com> <5502CF58.3050504@cloudius-systems.com> <2601191342CEEE43887BDE71AB977258213F63E2@irsmsx105.ger.corp.intel.com> Date: Fri, 13 Mar 2015 15:03:39 +0200 Message-ID: From: Vladislav Zolotarov To: Konstantin Ananyev Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 0/3]: bug fixes in the ixgbe PF PMD Rx flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Mar 2015 13:03:39 -0000 On Mar 13, 2015 2:51 PM, "Ananyev, Konstantin" wrote: > > Hi Vlad, > > > -----Original Message----- > > From: Vlad Zolotarov [mailto:vladz@cloudius-systems.com] > > Sent: Friday, March 13, 2015 11:52 AM > > To: Ananyev, Konstantin; dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v3 0/3]: bug fixes in the ixgbe PF PMD Rx flow > > > > > > > > On 03/13/15 13:07, Ananyev, Konstantin wrote: > > > > > >> -----Original Message----- > > >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Vlad Zolotarov > > >> Sent: Thursday, March 12, 2015 9:17 PM > > >> To: dev@dpdk.org > > >> Subject: [dpdk-dev] [PATCH v3 0/3]: bug fixes in the ixgbe PF PMD Rx flow > > >> > > >> This series contains some bug fixes that were found during my work on the ixgbe LRO > > >> patches. Sending this series separately on Thomas request so that it may be integrated > > >> into the 2.0 release. > > >> > > >> New in v3: > > >> - Adjusted to the new structs naming in the master. > > >> - Fixed rx_bulk_alloc_allowed and rx_vec_allowed initialization: > > >> - Don't set them to FALSE in rte_eth_dev_stop() flow - the following > > >> rte_eth_dev_start() will need them. > > >> - Reset them to TRUE in rte_eth_dev_configure() and not in a probe() flow. > > >> This will ensure the proper behaviour if port is re-configured. > > >> - Rename: > > >> - ixgbe_rx_vec_condition_check() -> ixgbe_rx_vec_dev_conf_condition_check() > > >> - set_rx_function() -> ixgbe_set_rx_function() > > >> - Clean up the logic in ixgbe_set_rx_function(). > > >> - Define stubs with __attribute__((weak)) instead of using #ifdef's. > > >> - Styling: beautify ixgbe_rxtx.h a bit. > > >> > > >> New in v2: > > >> - Fixed a compilation failure. > > >> > > >> > > >> Vlad Zolotarov (3): > > >> ixgbe: Use the rte_le_to_cpu_xx()/rte_cpu_to_le_xx() when > > >> reading/setting HW ring descriptor fields > > >> ixgbe: Bug fix: Properly configure Rx CRC stripping for x540 devices > > >> ixgbe: Unify the rx_pkt_bulk callback initialization > > >> > > >> lib/librte_pmd_ixgbe/ixgbe/ixgbe_type.h | 2 + > > >> lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 13 +- > > >> lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 216 +++++++++++++++++++++----------- > > >> lib/librte_pmd_ixgbe/ixgbe_rxtx.h | 28 ++++- > > >> lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c | 2 +- > > >> 5 files changed, 183 insertions(+), 78 deletions(-) > > >> > > > Acked-by: Konstantin Ananyev > > > > > > Just one nit: > > > > > > +int __attribute__((weak)) ixgbe_rxq_vec_setup( > > > + struct ixgbe_rx_queue __rte_unused *rxq) > > > +{ > > > > > > Please use notation: > > > int __attribute__((weak)) > > > ixgbe_rxq_vec_setup(struct ixgbe_rx_queue __rte_unused *rxq) > > > > > > To keep up with the rest of the code, plus makes much easier to read. > > > > I took an example from kni/ethtool/igb/kcompat.h for a template but no > > problem. > > Do u want me to respin or it's ok? I will use this format for the > > follow-up LRO patch anyway... > > Doing that in LRO patch set is ok. > No need for respin that one, I think. Great! Thanks a lot for reviewing this. Thomas, it seems like ixgbe maintainer gives this series a green light!.. ;) > Konstantin > > > > > > > > >> -- > > >> 2.1.0 >