DPDK patches and discussions
 help / color / mirror / Atom feed
From: Vladislav Zolotarov <vladz@cloudius-systems.com>
To: John Mcnamara <john.mcnamara@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v5 1/3] ixgbe: Cleanups
Date: Mon, 9 Mar 2015 20:21:29 +0200	[thread overview]
Message-ID: <CAOYyTHbaQYrooa76SGXjHZf-FYhhz0spWWebC_tHP0-a_uzj7g@mail.gmail.com> (raw)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE2ECC700@IRSMSX103.ger.corp.intel.com>

On Mar 9, 2015 8:01 PM, "Mcnamara, John" <john.mcnamara@intel.com> wrote:
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Vladislav Zolotarov
> > Sent: Monday, March 9, 2015 5:14 PM
> > To: Ananyev, Konstantin
> > Cc: dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH v5 1/3] ixgbe: Cleanups
> >
> > On Mar 9, 2015 6:39 PM, "Ananyev, Konstantin"
> > <konstantin.ananyev@intel.com>
> > wrote:
> > > > > If I remember things correctly, it considered result at right side
> > > > > of
> > '=' operator as unsigned int,
> > > > > and then complained that we assign it to smaller size (unsigned
> > short) operand.
> > > >
> > > > If that's the case - that's a clear compiler bug.
> > >
> > > Might be, though if we still have to support it, there is no much
> > > choice
> > I am afraid.
> >
> > Well to begin with could anybody who has this icc thing (preferably the
> > latest version) post the compilation errors u are talking about
>
> Hi,
>
> For what it is worth there aren't any warnings with ICC 13 and the 1/3
patch (+ the previous patchset):
>
>   $ make T=x86_64-native-linuxapp-icc install CC=icc
>   Build complete
>
>   $ git log --pretty=format:"%h - %an: %s" -4
>   b5d06e4 - Vladislav Zolotarov: ixgbe: Cleanups
>   3cd0367 - Vladislav Zolotarov: ixgbe: Unify the rx_pkt_bulk callback ...
>   10ed30e - Vladislav Zolotarov: ixgbe: Bug fix: Properly configure Rx ...
>   2a5bc6a - Vladislav Zolotarov: ixgbe: Use the rte_le_to_cpu_xx()/rte_...
>
>   $ icc --version
>   icc (ICC) 13.1.1 20130313

That's worth a lot to me!.. :D

>
> John.
> --
>
>

  reply	other threads:[~2015-03-09 18:21 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-09 10:20 [dpdk-dev] [PATCH v5 0/3]This series adds the missing flow for enabling the LRO in the ethdev and Vlad Zolotarov
2015-03-09 10:20 ` [dpdk-dev] [PATCH v5 1/3] ixgbe: Cleanups Vlad Zolotarov
2015-03-09 10:49   ` Ananyev, Konstantin
2015-03-09 11:09     ` Pawel Wodkowski
2015-03-09 11:29       ` Ananyev, Konstantin
2015-03-09 15:57         ` Vlad Zolotarov
2015-03-09 16:39           ` Ananyev, Konstantin
2015-03-09 17:13             ` Vladislav Zolotarov
2015-03-09 18:00               ` Mcnamara, John
2015-03-09 18:21                 ` Vladislav Zolotarov [this message]
2015-03-09 18:21                 ` Vladislav Zolotarov
     [not found]                   ` <2601191342CEEE43887BDE71AB977258213F4F13@irsmsx105.ger.corp.intel.com>
2015-03-09 19:13                     ` Ananyev, Konstantin
2015-03-09 19:32                       ` Vlad Zolotarov
2015-03-09 19:36                         ` Ananyev, Konstantin
2015-03-09 12:53     ` Vlad Zolotarov
2015-03-09 10:20 ` [dpdk-dev] [PATCH v5 2/3] ixgbe: Code refactoring Vlad Zolotarov
2015-03-09 10:20 ` [dpdk-dev] [PATCH v5 3/3] ixgbe: Add LRO support Vlad Zolotarov
2015-03-09 10:46 ` [dpdk-dev] [PATCH v5 0/3]This series adds the missing flow for enabling the LRO in the ethdev and Vlad Zolotarov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOYyTHbaQYrooa76SGXjHZf-FYhhz0spWWebC_tHP0-a_uzj7g@mail.gmail.com \
    --to=vladz@cloudius-systems.com \
    --cc=dev@dpdk.org \
    --cc=john.mcnamara@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).