From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f47.google.com (mail-wg0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 52F7D95E5 for ; Sun, 21 Dec 2014 09:01:51 +0100 (CET) Received: by mail-wg0-f47.google.com with SMTP id n12so4503572wgh.20 for ; Sun, 21 Dec 2014 00:01:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=tePPKOD0IzlGEftj7qyewGJyMV0L38O1X/sjf3a6/j4=; b=PVTdxjzlPgziwCm0eQCWzJdKBA+yxBatojxptj/XZxuf7S9SfVThTsb/+x2vTUZypN SIwVUfejg34MFeGcKDcEXARQc/EQCwUk6WZ36Y2EGMbaZcNjIzAHi/9BqSX7ilrM+WdL 7m1nB7BpCGN9TKPrIiMavZooLtnEDsBkXFz8w90YsHmhldHVSEO3CXNfWi4qwGDBAcwe f9swC6jU9+TBnWFNXigK7XFMhoZXAZFg7Y+h/3VFJTpPjUx70+Cy5Q4YKJzmignCZkLN tIIU5coEu0IUrSP/00d1nelXToB8a8t+Jz96IuiTtvKVtYMJSsIGOsSbczWUVbF+g32A gxvA== X-Gm-Message-State: ALoCoQlsG6IL7zKjlF/dsMev5EQYo+pZD0Bu78bB3ODjbery2IUoYQhGs4wcnPrHDC9nIpD4anGc MIME-Version: 1.0 X-Received: by 10.180.77.7 with SMTP id o7mr20509804wiw.81.1419148911139; Sun, 21 Dec 2014 00:01:51 -0800 (PST) Received: by 10.194.56.41 with HTTP; Sun, 21 Dec 2014 00:01:51 -0800 (PST) Received: by 10.194.56.41 with HTTP; Sun, 21 Dec 2014 00:01:51 -0800 (PST) In-Reply-To: References: <1418897516-25918-1-git-send-email-vladz@cloudius-systems.com> <5492D13C.4020006@cloudius-systems.com> Date: Sun, 21 Dec 2014 10:01:51 +0200 Message-ID: From: Vladislav Zolotarov To: Changchun Ouyang Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 0/6] Enable VF RSS for Niantic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Dec 2014 08:01:51 -0000 On Dec 19, 2014 3:35 AM, "Ouyang, Changchun" wrote: > > My response as below. > > > > From: Vlad Zolotarov [mailto:vladz@cloudius-systems.com] > Sent: Thursday, December 18, 2014 9:06 PM > To: dev@dpdk.org; Ouyang, Changchun > Subject: Re: [PATCH 0/6] Enable VF RSS for Niantic > > > > > > On 12/18/14 12:11, Vlad Zolotarov wrote: >> >> From: Changchun Ouyang >> >> >> >> This patch enables VF RSS for Niantic, which allow each VF having at most 4 queues. >> >> The actual queue number per VF depends on the number of VF: >> >> VF number from 1~32: 4 queues per VF; >> >> VF number from 33~max vf num: 2 queues per VF; >> >> >> >> On host, to enable VF RSS functionality, mq mode should be set as ETH_MQ_RX_VMDQ_RSS >> >> or ETH_MQ_RX_RSS mode, and SRIOV mode should be activated. >> >> It also needs config VF RSS information like hash function, RSS key, RSS key length. > > > This patch series is missing a few things: > > Taking into the consideration the number of Rx queues requested by a user in the rte_eth_dev_configure(). > > Changchun: yes, will have a v2 to consider it, as I say in my previous response. I must have joined the mailing list after your v2 series. I'll take a look in the web for it. > > dev->dev_ops->reta_query used by a rte_eth_dev_rss_reta_query() is still not initialized for a VF. Thus there is no way to query the RSS table > > Changchun: do you mean query rss table on guest? Of course. Niantic doesn=E2=80=99t have separate reta for a specific vf, the reta is s= hared by pf and all vf. AFAIK the reta is statically divided between all available functions. So, first of all we need a way to know that is the size of a single VF partition in order to know how many RSS queues may be configured. Then we need an ability to query/set the contents of the corresponding reta partition like we can for PF. > > Do you think of returning all reta contents for each vf make sense? Or any other insight here? > > rte_eth_dev_info_get() returns reta_size =3D=3D 0 when called for a VF function. > > Changchun: same as above. > > Your insight here are welcome here. > > thanks > > Changchun > >