From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f194.google.com (mail-qk0-f194.google.com [209.85.220.194]) by dpdk.org (Postfix) with ESMTP id 61BF5376C for ; Mon, 25 Jul 2016 17:16:58 +0200 (CEST) Received: by mail-qk0-f194.google.com with SMTP id n202so14582495qke.0 for ; Mon, 25 Jul 2016 08:16:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=htNu0gYaamfRnvzIBKAZQEDdpQcJHY7kl36K2S5Fu3A=; b=DC8cD8ipFl9Fyy/pJfSzbom+GDCEQuiR9uA6rRQIs2u1/fJCeFFwopK3K1rNKYWmTJ H7t2ZDum6WrTv4qjGZ/DRIwxqLJXrnN8SaJ7P3S+K2ZE0FyJZuj834rhUn9LtiBBlfmL LBBG7NHvp99tj2XA2FJ7nDOXSYt+ABmf1r2ZbSCNph6bsXl43RcjM8kAkf60P7EcJvgt ZuAT26N7m8v4lH88dHA7FhtK7lknU7XQNB9c//hOPmgdT4MfoeGG++SwnBvoTy+1l310 cJxEhLpHzoob/ELFlWhOAb2yVVYl4H+IwcQShXMY0hwyNgxqBC+8D3zsUkzTwny1fuzL zJEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=htNu0gYaamfRnvzIBKAZQEDdpQcJHY7kl36K2S5Fu3A=; b=MFHaccGFpZV1XQvAvXz7YFHEsJI3QQuWmTm+CMzIPEblDiQ5CMoQjGK20LDc6r6iZ4 uOZ06zKoPSQHzP6OjS8BjgGh67B1BmibnJChxsaOiB+Yx7SEzNyu+NWlLEf9H9Q6ghsn fBOKeke4CZ9GlMkD/L1KVw5du+s9NnmH8G5yQdpmOq2Ge3iDiU+c9ypi8Nb+9hWf/0tx w4NyTYOgvqEG4C3R9ybLbNwpfu6QDEzyTEynXr20mYn4vr/wH6diNKuzqnwkKqF2XMh1 K7EM+uriTzLNewWGSVksdRlUrdjn7K9Vn3eOUianG8mKMK9hGVb6h5HQys83a2Vd7fyn LfXQ== X-Gm-Message-State: AEkoouvuCUT5tZmBcxoKuzzaEYtnIy8sRuRpz2SMU2+I1NDo64nRvAPnxESvxiNxykLVp4PShSXzmd4jhP/YzA== X-Received: by 10.129.131.214 with SMTP id t205mr16545238ywf.157.1469459817935; Mon, 25 Jul 2016 08:16:57 -0700 (PDT) MIME-Version: 1.0 Received: by 10.37.36.87 with HTTP; Mon, 25 Jul 2016 08:16:38 -0700 (PDT) In-Reply-To: References: <1468766139-29545-1-git-send-email-h.mikita89@gmail.com> From: Hiroyuki Mikita Date: Tue, 26 Jul 2016 00:16:38 +0900 Message-ID: To: "Sanford, Robert" Cc: "dev@dpdk.org" , Thomas Monjalon Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH] timer: fix incorrect pending-list manipulation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jul 2016 15:16:58 -0000 Fixes: 9b15ba895b9f ("timer: use a skip list") 2016-07-23 7:05 GMT+09:00 Sanford, Robert : > > > On 7/17/16 10:35 AM, "Hiroyuki Mikita" wrote: > >>This commit fixes incorrect pending-list manipulation >>when getting list of expired timers in rte_timer_manage(). >> >>When timer_get_prev_entries() sets pending_head on prev, >>the pending-list is broken. >>The next of pending_head always becomes NULL. >>In this depth level, it is not need to manipulate the list. >> >>Signed-off-by: Hiroyuki Mikita >>--- >> lib/librte_timer/rte_timer.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >>diff --git a/lib/librte_timer/rte_timer.c b/lib/librte_timer/rte_timer.c >>index 3dcdab5..7457d32 100644 >>--- a/lib/librte_timer/rte_timer.c >>+++ b/lib/librte_timer/rte_timer.c >>@@ -543,6 +543,8 @@ void rte_timer_manage(void) >> /* break the existing list at current time point */ >> timer_get_prev_entries(cur_time, lcore_id, prev); >> for (i = priv_timer[lcore_id].curr_skiplist_depth -1; i >= 0; i--) { >>+ if (prev[i] == &priv_timer[lcore_id].pending_head) >>+ continue; >> priv_timer[lcore_id].pending_head.sl_next[i] = >> prev[i]->sl_next[i]; >> if (prev[i]->sl_next[i] == NULL) >>-- >>2.7.4 >> > > Acked-by: Robert Sanford >