Re: [dpdk-dev] [PATCH 1/2] enic: silence log message

[Stephen Hemminger <stephen@networkplumber.org>]

Other drivers are quiet, why does this one need to be noisy

On Wed, May 20, 2015 at 9:30 AM, Sujith Sankar (ssujith) <ssujith@cisco.com>
wrote:

>
>
> On 19/05/15 3:38 pm, "Bruce Richardson" <bruce.richardson@intel.com>
> wrote:
>
> >On Wed, Apr 08, 2015 at 10:37:49AM -0700, Stephen Hemminger wrote:
> >> From: Stephen Hemminger <shemming@brocade.com>
> >>
> >> Silence is normal. drivers should speak only when spoken to and not
> >> be chatty.
> >>
> >> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> >
> >Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> >
> >> ---
> >>  lib/librte_pmd_enic/enic_main.c | 2 --
> >>  1 file changed, 2 deletions(-)
> >>
> >> diff --git a/lib/librte_pmd_enic/enic_main.c
> >>b/lib/librte_pmd_enic/enic_main.c
> >> index 0892b3e..508621e 100644
> >> --- a/lib/librte_pmd_enic/enic_main.c
> >> +++ b/lib/librte_pmd_enic/enic_main.c
> >> @@ -1048,8 +1048,6 @@ int enic_probe(struct enic *enic)
> >>      struct rte_pci_device *pdev = enic->pdev;
> >>      int err = -1;
> >>
> >> -    dev_debug(enic, " Initializing ENIC PMD version %s\n",
> DRV_VERSION);
> >> -
>
> It would be good to retain this under RTE_LIBRTE_ENIC_DEBUG.
>
> >>      enic->bar0.vaddr = (void *)pdev->mem_resource[0].addr;
> >>      enic->bar0.len = pdev->mem_resource[0].len;
> >>
> >> --
> >> 2.1.4
> >>
>
>