From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ig0-f174.google.com (mail-ig0-f174.google.com [209.85.213.174]) by dpdk.org (Postfix) with ESMTP id 74BA6C320 for ; Wed, 20 May 2015 19:47:02 +0200 (CEST) Received: by igbyr2 with SMTP id yr2so108945037igb.0 for ; Wed, 20 May 2015 10:47:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=oPqw4c65ug9IzcZu9UErWer0RfvneNRT7N+6h5HOofU=; b=bLkJLA/LpVpvclsDKmFlhHA2aA80opwCPdQruHyzge44PNSfvJtaLslhkVrj6FyzKG pKrHFyHdVle/PQOzJQ7n6TJnWqq8Id2wqI/n67I+0z8lKCK8U3m88M2VvD3vN42y5frh qgL8Kc4T+yR8xp9IlTYyaF8M/8+y3GpGXlLioxrwP8pXnno2vE7jvbe8w1rIMob3mFe7 /9Zz7EiuCYrVyNs0+i0IVsuhzzXV6RWYpDCgcyGGjnXZJCdYswGVdLwsqEDBrGEFZTI8 /5GShByLV9mNiiUDVTvs96PDaqpho4Wc9y8SNSqb770e7iLlmyopd9TIC5QHxEE0nxOF w42w== X-Gm-Message-State: ALoCoQkztvFBR/fijW9Pu26nz/HbeXnM4eI5Wriu+piNKY58BI890QGK1wX6C2TelJLVuitWGKi/ MIME-Version: 1.0 X-Received: by 10.50.64.243 with SMTP id r19mr6879305igs.5.1432144021821; Wed, 20 May 2015 10:47:01 -0700 (PDT) Received: by 10.64.58.227 with HTTP; Wed, 20 May 2015 10:47:01 -0700 (PDT) In-Reply-To: References: <1428514670-7982-1-git-send-email-stephen@networkplumber.org> <1428514670-7982-2-git-send-email-stephen@networkplumber.org> <20150519100853.GB11036@bricha3-MOBL3> Date: Wed, 20 May 2015 10:47:01 -0700 Message-ID: From: Stephen Hemminger To: "Sujith Sankar (ssujith)" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" , Stephen Hemminger Subject: Re: [dpdk-dev] [PATCH 1/2] enic: silence log message X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 May 2015 17:47:02 -0000 Other drivers are quiet, why does this one need to be noisy On Wed, May 20, 2015 at 9:30 AM, Sujith Sankar (ssujith) wrote: > > > On 19/05/15 3:38 pm, "Bruce Richardson" > wrote: > > >On Wed, Apr 08, 2015 at 10:37:49AM -0700, Stephen Hemminger wrote: > >> From: Stephen Hemminger > >> > >> Silence is normal. drivers should speak only when spoken to and not > >> be chatty. > >> > >> Signed-off-by: Stephen Hemminger > > > >Acked-by: Bruce Richardson > > > >> --- > >> lib/librte_pmd_enic/enic_main.c | 2 -- > >> 1 file changed, 2 deletions(-) > >> > >> diff --git a/lib/librte_pmd_enic/enic_main.c > >>b/lib/librte_pmd_enic/enic_main.c > >> index 0892b3e..508621e 100644 > >> --- a/lib/librte_pmd_enic/enic_main.c > >> +++ b/lib/librte_pmd_enic/enic_main.c > >> @@ -1048,8 +1048,6 @@ int enic_probe(struct enic *enic) > >> struct rte_pci_device *pdev = enic->pdev; > >> int err = -1; > >> > >> - dev_debug(enic, " Initializing ENIC PMD version %s\n", > DRV_VERSION); > >> - > > It would be good to retain this under RTE_LIBRTE_ENIC_DEBUG. > > >> enic->bar0.vaddr = (void *)pdev->mem_resource[0].addr; > >> enic->bar0.len = pdev->mem_resource[0].len; > >> > >> -- > >> 2.1.4 > >> > >