From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vc0-f174.google.com (mail-vc0-f174.google.com [209.85.220.174]) by dpdk.org (Postfix) with ESMTP id F0E56231C for ; Tue, 20 May 2014 23:39:16 +0200 (CEST) Received: by mail-vc0-f174.google.com with SMTP id lh14so1406438vcb.5 for ; Tue, 20 May 2014 14:39:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=ozM8CvQoAn72cZdrqcqGTMuKDnCovaT0aTn8czAZ/gc=; b=kVTabXf8cvajR3WLsmCijUeKo0pM8T10n8etaHmETNUBKVCl/Ymqznn48crH7XIuht OmjMjPIJOiqITs7facBpOMrDKaXV/oF6Wz1KYPDtiUIKG1fZu/prpLDUf44KiXkJvoKR u7WF0kW0n9ax2067eesZpOSkeb87asq/vwC9TzqdfMiP51lHK7BqCZwMbNJ3Joz6Grxa 1WVtVtMbQjeFFkft18Mdxec73XuGd/j6RGUjwP3ZESrh1QF02vi1OF1VKFFxrRfMX1Xa 80oL5IYEJRqKqpbzo7sDWO5uxKgs7NJldKzfDnBaIO4D9tujhEivrBbCSYT/94BgIc1R KytA== X-Gm-Message-State: ALoCoQnufbfXJmDLfkuO/Uq94Km0y+rJxlhfbdYV4l4bb+UjMsjQDACmYJVfW+9+CMHVyP9CD86I MIME-Version: 1.0 X-Received: by 10.52.27.209 with SMTP id v17mr5141179vdg.23.1400621966155; Tue, 20 May 2014 14:39:26 -0700 (PDT) Received: by 10.220.185.199 with HTTP; Tue, 20 May 2014 14:39:26 -0700 (PDT) In-Reply-To: References: <1400514709-24087-11-git-send-email-anatoly.burakov@intel.com> <20140520042323.4dbea108@samsung-9> Date: Wed, 21 May 2014 06:39:26 +0900 Message-ID: From: Stephen Hemminger To: "Burakov, Anatoly" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 10/16] Added support for selecting VFIO interrupt type from EAL command-line X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 May 2014 21:39:17 -0000 Originally igb_uio had code for MSI, but it was broken. See my patches which fixed that and several other bugs. On Tue, May 20, 2014 at 8:26 PM, Burakov, Anatoly wrote: > Hi Stephen, > > > I am not sure that MSI-X has any advantage with only one IRQ, so MSI > would > > do. > > Igb_uio doesn't support MSI, so I never included MSI support. It can be > added though, but I don't see much point. > > > Then have the code look at the PCI capability of device and fallback to > INTX if > > needed. It should also check if INTX works, see kernel for details, > since some > > PCI emulation like VMware is broken. > > I believe VFIO itself does that already when it sets up interrupts. > > Best regards, > Anatoly Burakov > DPDK SW Engineer > > > >