Just for fun, experimented with AI code review. Like many things AI, it produced verbose output but no real insights. Here is the result if anyone cares. On Tue, Jun 24, 2025 at 7:29 PM Feifei Wang wrote: > From: Yi Chen > > The hinic3 PMD (**librte_net_hinic3**) provides poll mode driver support > for 25Gbps/100Gbps/200Gbps Huawei SPx series Network Adapters. > > Feifei Wang (2): > net/hinic3: add dev ops > net/hinic3: add Rx/Tx functions > > Xin Wang (7): > net/hinic3: add basic header files > net/hinic3: add support for cmdq mechanism > net/hinic3: add NIC event module > net/hinic3: add context and work queue support > net/hinic3: add device initialization > net/hinic3: add MML and EEPROM access feature > net/hinic3: add RSS promiscuous ops > > Yi Chen (8): > net/hinic3: add hardware interfaces of BAR operation > net/hinic3: add eq mechanism function code > net/hinic3: add mgmt module function code > net/hinic3: add module about hardware operation > net/hinic3: add a NIC business configuration module > net/hinic3: add a mailbox communication module > net/hinic3: add FDIR flow control module > drivers/net: add hinic3 PMD build and doc files > > Yi Chen (1): > This patch adds some basic files to describe the hinic3 driver. > > .mailmap | 4 +- > MAINTAINERS | 6 + > doc/guides/nics/features/hinic3.ini | 9 + > doc/guides/nics/hinic3.rst | 51 + > doc/guides/nics/index.rst | 1 + > doc/guides/rel_notes/release_25_07.rst | 4 + > drivers/net/hinic3/base/hinic3_cmd.h | 231 ++ > drivers/net/hinic3/base/hinic3_cmdq.c | 978 +++++ > drivers/net/hinic3/base/hinic3_cmdq.h | 230 ++ > drivers/net/hinic3/base/hinic3_compat.h | 266 ++ > drivers/net/hinic3/base/hinic3_csr.h | 108 + > drivers/net/hinic3/base/hinic3_eqs.c | 721 ++++ > drivers/net/hinic3/base/hinic3_eqs.h | 98 + > drivers/net/hinic3/base/hinic3_hw_cfg.c | 240 ++ > drivers/net/hinic3/base/hinic3_hw_cfg.h | 121 + > drivers/net/hinic3/base/hinic3_hw_comm.c | 452 +++ > drivers/net/hinic3/base/hinic3_hw_comm.h | 366 ++ > drivers/net/hinic3/base/hinic3_hwdev.c | 573 +++ > drivers/net/hinic3/base/hinic3_hwdev.h | 177 + > drivers/net/hinic3/base/hinic3_hwif.c | 779 ++++ > drivers/net/hinic3/base/hinic3_hwif.h | 142 + > drivers/net/hinic3/base/hinic3_mbox.c | 1399 +++++++ > drivers/net/hinic3/base/hinic3_mbox.h | 199 + > drivers/net/hinic3/base/hinic3_mgmt.c | 392 ++ > drivers/net/hinic3/base/hinic3_mgmt.h | 121 + > drivers/net/hinic3/base/hinic3_nic_cfg.c | 1828 +++++++++ > drivers/net/hinic3/base/hinic3_nic_cfg.h | 1527 ++++++++ > drivers/net/hinic3/base/hinic3_nic_event.c | 433 +++ > drivers/net/hinic3/base/hinic3_nic_event.h | 39 + > drivers/net/hinic3/base/hinic3_wq.c | 148 + > drivers/net/hinic3/base/hinic3_wq.h | 109 + > drivers/net/hinic3/base/meson.build | 50 + > drivers/net/hinic3/hinic3_ethdev.c | 3866 ++++++++++++++++++++ > drivers/net/hinic3/hinic3_ethdev.h | 167 + > drivers/net/hinic3/hinic3_fdir.c | 1394 +++++++ > drivers/net/hinic3/hinic3_fdir.h | 398 ++ > drivers/net/hinic3/hinic3_flow.c | 1700 +++++++++ > drivers/net/hinic3/hinic3_flow.h | 80 + > drivers/net/hinic3/hinic3_nic_io.c | 828 +++++ > drivers/net/hinic3/hinic3_nic_io.h | 169 + > drivers/net/hinic3/hinic3_rx.c | 1099 ++++++ > drivers/net/hinic3/hinic3_rx.h | 356 ++ > drivers/net/hinic3/hinic3_tx.c | 1028 ++++++ > drivers/net/hinic3/hinic3_tx.h | 315 ++ > drivers/net/hinic3/meson.build | 33 + > drivers/net/hinic3/mml/hinic3_dbg.c | 171 + > drivers/net/hinic3/mml/hinic3_dbg.h | 160 + > drivers/net/hinic3/mml/hinic3_mml_cmd.c | 375 ++ > drivers/net/hinic3/mml/hinic3_mml_cmd.h | 131 + > drivers/net/hinic3/mml/hinic3_mml_ioctl.c | 215 ++ > drivers/net/hinic3/mml/hinic3_mml_lib.c | 136 + > drivers/net/hinic3/mml/hinic3_mml_lib.h | 276 ++ > drivers/net/hinic3/mml/hinic3_mml_main.c | 167 + > drivers/net/hinic3/mml/hinic3_mml_queue.c | 745 ++++ > drivers/net/hinic3/mml/hinic3_mml_queue.h | 256 ++ > drivers/net/hinic3/mml/meson.build | 45 + > drivers/net/meson.build | 1 + > 57 files changed, 25912 insertions(+), 1 deletion(-) > create mode 100644 doc/guides/nics/features/hinic3.ini > create mode 100644 doc/guides/nics/hinic3.rst > create mode 100644 drivers/net/hinic3/base/hinic3_cmd.h > create mode 100644 drivers/net/hinic3/base/hinic3_cmdq.c > create mode 100644 drivers/net/hinic3/base/hinic3_cmdq.h > create mode 100644 drivers/net/hinic3/base/hinic3_compat.h > create mode 100644 drivers/net/hinic3/base/hinic3_csr.h > create mode 100644 drivers/net/hinic3/base/hinic3_eqs.c > create mode 100644 drivers/net/hinic3/base/hinic3_eqs.h > create mode 100644 drivers/net/hinic3/base/hinic3_hw_cfg.c > create mode 100644 drivers/net/hinic3/base/hinic3_hw_cfg.h > create mode 100644 drivers/net/hinic3/base/hinic3_hw_comm.c > create mode 100644 drivers/net/hinic3/base/hinic3_hw_comm.h > create mode 100644 drivers/net/hinic3/base/hinic3_hwdev.c > create mode 100644 drivers/net/hinic3/base/hinic3_hwdev.h > create mode 100644 drivers/net/hinic3/base/hinic3_hwif.c > create mode 100644 drivers/net/hinic3/base/hinic3_hwif.h > create mode 100644 drivers/net/hinic3/base/hinic3_mbox.c > create mode 100644 drivers/net/hinic3/base/hinic3_mbox.h > create mode 100644 drivers/net/hinic3/base/hinic3_mgmt.c > create mode 100644 drivers/net/hinic3/base/hinic3_mgmt.h > create mode 100644 drivers/net/hinic3/base/hinic3_nic_cfg.c > create mode 100644 drivers/net/hinic3/base/hinic3_nic_cfg.h > create mode 100644 drivers/net/hinic3/base/hinic3_nic_event.c > create mode 100644 drivers/net/hinic3/base/hinic3_nic_event.h > create mode 100644 drivers/net/hinic3/base/hinic3_wq.c > create mode 100644 drivers/net/hinic3/base/hinic3_wq.h > create mode 100644 drivers/net/hinic3/base/meson.build > create mode 100644 drivers/net/hinic3/hinic3_ethdev.c > create mode 100644 drivers/net/hinic3/hinic3_ethdev.h > create mode 100644 drivers/net/hinic3/hinic3_fdir.c > create mode 100644 drivers/net/hinic3/hinic3_fdir.h > create mode 100644 drivers/net/hinic3/hinic3_flow.c > create mode 100644 drivers/net/hinic3/hinic3_flow.h > create mode 100644 drivers/net/hinic3/hinic3_nic_io.c > create mode 100644 drivers/net/hinic3/hinic3_nic_io.h > create mode 100644 drivers/net/hinic3/hinic3_rx.c > create mode 100644 drivers/net/hinic3/hinic3_rx.h > create mode 100644 drivers/net/hinic3/hinic3_tx.c > create mode 100644 drivers/net/hinic3/hinic3_tx.h > create mode 100644 drivers/net/hinic3/meson.build > create mode 100644 drivers/net/hinic3/mml/hinic3_dbg.c > create mode 100644 drivers/net/hinic3/mml/hinic3_dbg.h > create mode 100644 drivers/net/hinic3/mml/hinic3_mml_cmd.c > create mode 100644 drivers/net/hinic3/mml/hinic3_mml_cmd.h > create mode 100644 drivers/net/hinic3/mml/hinic3_mml_ioctl.c > create mode 100644 drivers/net/hinic3/mml/hinic3_mml_lib.c > create mode 100644 drivers/net/hinic3/mml/hinic3_mml_lib.h > create mode 100644 drivers/net/hinic3/mml/hinic3_mml_main.c > create mode 100644 drivers/net/hinic3/mml/hinic3_mml_queue.c > create mode 100644 drivers/net/hinic3/mml/hinic3_mml_queue.h > create mode 100644 drivers/net/hinic3/mml/meson.build > > -- > 2.45.1.windows.1 > > >