From: Stephen Hemminger <stephen@networkplumber.org>
To: David Marchand <david.marchand@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 5/5] ixgbe: silence noisy log messages
Date: Tue, 19 May 2015 07:40:27 -0700 [thread overview]
Message-ID: <CAOaVG16Bzy=B8y2N=tm74=BiDiodJ5fFuj8XY=FSa7Aep1Dr6w@mail.gmail.com> (raw)
In-Reply-To: <CALwxeUvJwg7rnvsU6rmKupfMF9755Ner_A9pN+13O11RNP_CAw@mail.gmail.com>
We need info messages about topology etc from other components.
On Tue, May 19, 2015 at 12:46 AM, David Marchand <david.marchand@6wind.com>
wrote:
> On Mon, May 18, 2015 at 6:39 PM, Stephen Hemminger <
> stephen@networkplumber.org> wrote:
>
>> On Mon, 18 May 2015 10:32:01 +0100
>> Bruce Richardson <bruce.richardson@intel.com> wrote:
>>
>> > For the most part, this looks fine. However, I'm unsure about changing
>> the log
>> > level of the messages stating what the RX and TX burst functions in use
>> are. I
>> > would view this as important information that should generally be
>> displayed as
>> > the performance impacts of using a sub-optimal RX/TX code path are
>> large.
>> >
>> > /Bruce
>>
>>
>> At INFO level it shows up in log files that customers read.
>> This is an issue where DPDK has to grow up and be ready for real world
>> use, rather than being developer friendly.
>>
>> Our customers ask about every log message (believe me). So if there
>> is no problem the drivers must be absolutely silent (STFU)
>>
>
> Are there messages at INFO level you want to keep ?
> Or can't you just set the log level (the runtime option not the build one)
> to something like WARNING or ERR ?
>
>
> --
> David Marchand
>
>
prev parent reply other threads:[~2015-05-19 14:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-15 17:08 [dpdk-dev] [PATCH v2 0/5] ixgbe: logging patches Stephen Hemminger
2015-05-15 17:08 ` [dpdk-dev] [PATCH 1/5] ixgbe: remove unnecessary casts Stephen Hemminger
2015-05-18 9:24 ` Bruce Richardson
2015-05-15 17:08 ` [dpdk-dev] [PATCH 2/5] ixgbe: don't print PCI address on link change Stephen Hemminger
2015-05-18 9:32 ` Bruce Richardson
2015-05-15 17:08 ` [dpdk-dev] [PATCH 3/5] ixgbe: raise priority of significant events Stephen Hemminger
2015-05-18 9:27 ` Bruce Richardson
2015-05-15 17:08 ` [dpdk-dev] [PATCH 4/5] ixgbe: use RTE_LOG not rte_log Stephen Hemminger
2015-05-18 9:28 ` Bruce Richardson
2015-05-15 17:08 ` [dpdk-dev] [PATCH 5/5] ixgbe: silence noisy log messages Stephen Hemminger
2015-05-18 9:32 ` Bruce Richardson
2015-05-18 16:39 ` Stephen Hemminger
2015-05-19 7:46 ` David Marchand
2015-05-19 14:40 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOaVG16Bzy=B8y2N=tm74=BiDiodJ5fFuj8XY=FSa7Aep1Dr6w@mail.gmail.com' \
--to=stephen@networkplumber.org \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).