From: Stephen Hemminger <stephen@networkplumber.org>
To: "Zhang, Helin" <helin.zhang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v8 0/3]: Add LRO support to ixgbe PMD
Date: Tue, 21 Apr 2015 18:45:36 -0700 [thread overview]
Message-ID: <CAOaVG16C=JS9FDQFu3agG4DtGVJE7Os=88oAN22OX3stw7njrQ@mail.gmail.com> (raw)
In-Reply-To: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A851B71@SHSMSX104.ccr.corp.intel.com>
On Apr 21, 2015 6:23 PM, "Zhang, Helin" <helin.zhang@intel.com> wrote:
>
> Hi Vlad
>
> I have a concern about the code changes you added in ixgbe_type.h.
> For ixgbe, all source files in librte_pmd_ixgbe/ixgbe, except
ixgbe_osdep.h were called as "base driver", which was not developed by DPDK
developers, and released by the other team. We never modify any code in
those base driver source files, and just copy those file into DPDK project.
I have a concern long term that this model is not going to work.
It stifles innovation, prevents bug fixes and discourages contributors.
next prev parent reply other threads:[~2015-04-22 1:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 17:52 Vlad Zolotarov
2015-03-18 17:52 ` [dpdk-dev] [PATCH v8 1/3] ixgbe: Cleanups Vlad Zolotarov
2015-03-18 17:52 ` [dpdk-dev] [PATCH v8 2/3] ixgbe: Code refactoring Vlad Zolotarov
2015-03-18 17:52 ` [dpdk-dev] [PATCH v8 3/3] ixgbe: Add LRO support Vlad Zolotarov
2015-03-30 14:18 ` Ananyev, Konstantin
2015-03-30 15:37 ` Vlad Zolotarov
2015-03-30 15:57 ` Vlad Zolotarov
2015-03-29 8:57 ` [dpdk-dev] [PATCH v8 0/3]: Add LRO support to ixgbe PMD Vlad Zolotarov
2015-04-22 1:23 ` Zhang, Helin
2015-04-22 1:45 ` Stephen Hemminger [this message]
2015-04-22 2:01 ` Zhang, Helin
2015-04-22 2:22 ` Stephen Hemminger
2015-04-22 2:23 ` Stephen Hemminger
2015-04-22 4:58 ` Vlad Zolotarov
2015-04-22 5:28 ` Zhang, Helin
2015-04-22 9:19 ` Vlad Zolotarov
2015-04-23 0:28 ` Zhang, Helin
2015-04-23 9:20 ` Ananyev, Konstantin
2015-04-23 11:01 ` Vladislav Zolotarov
[not found] ` <2601191342CEEE43887BDE71AB9772582142100A@irsmsx105.ger.corp.intel.com>
2015-04-23 11:16 ` Ananyev, Konstantin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOaVG16C=JS9FDQFu3agG4DtGVJE7Os=88oAN22OX3stw7njrQ@mail.gmail.com' \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).