From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-ig0-f179.google.com (mail-ig0-f179.google.com
 [209.85.213.179]) by dpdk.org (Postfix) with ESMTP id AE25C6A94
 for <dev@dpdk.org>; Wed, 22 Apr 2015 03:45:36 +0200 (CEST)
Received: by igbpi8 with SMTP id pi8so95994337igb.0
 for <dev@dpdk.org>; Tue, 21 Apr 2015 18:45:36 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:date
 :message-id:subject:from:to:cc:content-type;
 bh=ASzWxbDQfHR5snaomOjYVDw17BgRW/hetvjjJjX4zM0=;
 b=L/GSuvs3yLe/yjwXJUa6TzRt5iknxB2h6VEW29Ohd1z3YsJFklK3YStIklD3VMW576
 DGozLowIuiritLlZfwtaHbztAk10+QYFpolF5rl54WKOpRl2efQP+puL7bisyj9+Fzpj
 QtjZrj/3hdo+BLzzLk/z05CHJum6+Zb/FxZx1kmRwK7Ax0kcwDTbN0cncK/o+CTZQdhZ
 OuyNDX3IO5wEJWXDAqjJvRamzjPScjAaeCzSxEF0+enLPsSWaDjNV8RaRdIVfLu3p39P
 d0L/7CEOMQPiIvpswvdNZCADwCCzWmNq9pLTRUo4ngUY9uKDzGq16LcFopTzaMwjsr4M
 +EtQ==
X-Gm-Message-State: ALoCoQmNR9f9q6Vnoc39MAVjHfw5hNyuA5GV71wJLLE6LPn653iu5Gix3DIkP3N6FoeCTvHFhmAZ
MIME-Version: 1.0
X-Received: by 10.43.64.144 with SMTP id xi16mr7097705icb.20.1429667136193;
 Tue, 21 Apr 2015 18:45:36 -0700 (PDT)
Received: by 10.64.58.227 with HTTP; Tue, 21 Apr 2015 18:45:36 -0700 (PDT)
Received: by 10.64.58.227 with HTTP; Tue, 21 Apr 2015 18:45:36 -0700 (PDT)
In-Reply-To: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A851B71@SHSMSX104.ccr.corp.intel.com>
References: <1426701144-21231-1-git-send-email-vladz@cloudius-systems.com>
 <F35DEAC7BCE34641BA9FAC6BCA4A12E70A851B71@SHSMSX104.ccr.corp.intel.com>
Date: Tue, 21 Apr 2015 18:45:36 -0700
Message-ID: <CAOaVG16C=JS9FDQFu3agG4DtGVJE7Os=88oAN22OX3stw7njrQ@mail.gmail.com>
From: Stephen Hemminger <stephen@networkplumber.org>
To: "Zhang, Helin" <helin.zhang@intel.com>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v8 0/3]: Add LRO support to ixgbe PMD
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Apr 2015 01:45:37 -0000

On Apr 21, 2015 6:23 PM, "Zhang, Helin" <helin.zhang@intel.com> wrote:
>
> Hi Vlad
>
> I have a concern about the code changes you added in ixgbe_type.h.
> For ixgbe, all source files in librte_pmd_ixgbe/ixgbe, except
ixgbe_osdep.h were called as "base driver", which was not developed by DPDK
developers, and released by the other team. We never modify any code in
those base driver source files, and just copy those file into DPDK project.

I have a concern long term that this model is not going to work.
It stifles innovation, prevents bug fixes and discourages contributors.