From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ie0-f172.google.com (mail-ie0-f172.google.com [209.85.223.172]) by dpdk.org (Postfix) with ESMTP id 102019A96 for ; Fri, 3 Apr 2015 00:18:33 +0200 (CEST) Received: by iebmp1 with SMTP id mp1so72865251ieb.0 for ; Thu, 02 Apr 2015 15:18:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=On0tmw9n9OQbdvm/DCqo7jS2R9FiZ2auKW2+emBAj6I=; b=l9TvO8ZDFBHdy31Y7oAJYFC4RZ6Bk6lC7M8pxjChZjNetM5bydfOuha8gprsds2jzn +Bg4Rf9hnX/mnnrYaUxBtj00EGBxCbIljQ3roUNFg97m5Xn34SauRpnUXKKW8sGgaY72 8Af8Cvzld14Ejgt362hPjjUyi4kMMQp48s6jogchzYe1Gw/ypfpLKyzqeURdqj4X2H57 9nU7B4WCXmw9RlE/vvcOaPGLl+btcgxytSVasdKlhifGCQKrdqT4LhL8GC2RBAf5CFiZ sGg8JHNwV07MNx6iAPwfzKXWoz+0agxcGdWZahgGUhir0D8htwrcme9r095j6t/9ZCFA SBdA== X-Gm-Message-State: ALoCoQlQIv+bpUUtv7bdJJXln8Eg436EBjUx+i0wIgMy8q4c+ONb6iy5bZrjcZw/e25N68f8JGWw MIME-Version: 1.0 X-Received: by 10.107.19.2 with SMTP id b2mr14722244ioj.9.1428013112342; Thu, 02 Apr 2015 15:18:32 -0700 (PDT) Received: by 10.64.58.129 with HTTP; Thu, 2 Apr 2015 15:18:32 -0700 (PDT) In-Reply-To: References: <1427855614-8654-1-git-send-email-cunming.liang@intel.com> <63FB47D6C0357E428AA804B2C89068BA012D58D6@SHSMSX104.ccr.corp.intel.com> <32480824.oD8BQeRvMH@xps13> Date: Thu, 2 Apr 2015 15:18:32 -0700 Message-ID: From: Stephen Hemminger To: "Liang, Cunming" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] i40e: fix no effect wait_to_complete on link_get X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Apr 2015 22:18:33 -0000 The qos_scheduler has a 32 bit speed value and therefore I doubt it will work work at 40G On Wed, Apr 1, 2015 at 6:44 PM, Liang, Cunming wrote: > Hi Thomas, > > > What is the relation between link status timeout and qos_sched? > [LCM] Validation team found qos_sched test failure on i40e. The sample > depends on link speed to calc the percentage. > The root cause comes from that i40e link_get hasn't support > wait_to_complete well. > I agree with you it should add more description in test report why 'Used > QoS example to verified'. > > > > +-----------------------+----------------------+ > > > | Subport output rate | Subport output rate | > > > | (% line rate) | (Mpps) | > > > +-----------+-----------+----------+-----------+ > > > | Expected | Actual | Expected | Actual | > > > +-----------+-----------+----------+-----------+ > > > > This table is empty. > [LCM] It's useless, should be omitted I think. > > Cunming > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > Sent: Thursday, April 02, 2015 3:52 AM > > To: Zhang, XiaonanX; Cao, Waterman > > Cc: dev@dpdk.org; Zhang, Helin; Liang, Cunming > > Subject: Re: [dpdk-dev] [PATCH] i40e: fix no effect wait_to_complete on > link_get > > > > Hi, > > > > 2015-04-01 06:10, Zhang, XiaonanX: > > > > > > Tested-by: Xiaonan zhang > > > > > > - OS: Fedora21 3.19.1-201.fc21.x86_64 > > > - GCC: gcc version 4.9.1 20140930 (Red Hat 4.9.1-11) (GCC) > > > - CPU: Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz > > > - NIC: Ethernet controller [0200]: Intel Corporation Ethernet > Controller X710 for > > 10GbE SFP+ [8086:1572] (rev 01) > > > - Default x86_64-native-linuxapp-gcc configuration > > > - Total 1 cases, 1 passed, 0 failed > > > > > > - Test case: Used Qos example to verified > > > ------------------------------------- > > > > What is the relation between link status timeout and qos_sched? > > > > > Traffic shaping for subport. Check that the subport rate is enforced. > > > > > > Set the subport output rate to x% of line rate (x = 10 .. 100). Set > the subport TC > > limits high (100% line rate each), so they do not constitute > limitations. Input traffic > > is 100% line rate. > > > > > > Different tb period and tb credits, therefore different output rate, > are tried: > > 25%, 50%, 75%, 90% and 100% the lineal rate. (The output for subport is > Tb credits > > per period / Tb period.) > > > The traffic is injected change subport value random. > > > > > > Other parameters are same before tests and they don't change here. > > > > > > Cmdline: ./examples/qos_sched/build/qos_sched -c 0xe -n 4 -- --pfc > > "0,1,2,3,3" --cfg "/root/profile_sched_pipe_1.cfg" > > > > > > The result is this table: > > > > > > > > > +-----------------------+----------------------+ > > > | Subport output rate | Subport output rate | > > > | (% line rate) | (Mpps) | > > > +-----------+-----------+----------+-----------+ > > > | Expected | Actual | Expected | Actual | > > > +-----------+-----------+----------+-----------+ > > > > This table is empty. > > > > > > > > Signed-off-by: Xiaonan Zhang > > > > It seems that this test report is not relevant. > > It will be ignored in the commit message. Sorry > >