From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3CAAB42927; Wed, 12 Apr 2023 15:42:49 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C4B5F410F2; Wed, 12 Apr 2023 15:42:48 +0200 (CEST) Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) by mails.dpdk.org (Postfix) with ESMTP id 43141406A2 for <dev@dpdk.org>; Wed, 12 Apr 2023 15:42:47 +0200 (CEST) Received: by mail-ej1-f41.google.com with SMTP id sh8so28891303ejc.10 for <dev@dpdk.org>; Wed, 12 Apr 2023 06:42:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon-tech.20210112.gappssmtp.com; s=20210112; t=1681306967; x=1683898967; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=liSEsaSrr+cLC3b+DoPhu+2BUAF2mf4HanvP7YMq9VE=; b=qMIlt+TL6n/NQgeJD/XwfsxpldouvYHmxjXevG5kCFvr8LQ8nM5Lsd8mmoxfGqk1od T46MfIF4hCCBSf62I67FL5NF+KJhP2Lb+4DNxWNkDvC6eTT1S/LA3hd9SkRxW+9nYvq2 3V/M1WAwaJOEjla5I9E/FH0v7nKVp4qEjBXhZo+b8RD1xxnRUFcIewo6hOXiAwHl84lo YP28uAF/ZPtUTz/okLE5R8Mjow+m2pyMiuTXihlliJllU1S2ccGTzqKyKzaNZqaKTB0F jymCoD1+SV3ocz+98WivngAq7Vg79D35yFrvK/VX3H0hHFAmFD5pnnHQVAwwxdGmScsJ W7ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681306967; x=1683898967; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=liSEsaSrr+cLC3b+DoPhu+2BUAF2mf4HanvP7YMq9VE=; b=2z9+s5yzxIKXP33LGqQSymYjqFyc2IITkI/0DbPAj4WSqLeRuSWhszP/hbAg95nsQH a9h2c8IzdjBgLTsE+PshR5WeSmoXCj/u08Q71hs9TBMhn4ldxOH9ei96lN2Uvi+xpOUe khpzX4FKsFPNumGU20CtDFTSoGywh1vxRXe83wu6k/yHlOQTXfMjzGZgnWzO5oHMc2k0 VZ2qfehshnO7tSvbE34SEERtAINjJxaEEhwrnc6L7wZ7MwczCDTVyhDX2Qzg06NUbyKh 3v9gBhHNMnAFWBZoi++dmWwOkvx1ww9EwYvHVgA3hAk4fJjKpC/IIKEqw7IXMyQFohEA CKPg== X-Gm-Message-State: AAQBX9eEst8FbpVRwc0UsmC0+Uh+IDh0WWfi8GeFdo+XKcNLINdrGBmy rZlJ7mRcY30lh1YK03n3xPCcePMAJk8zV6nO2DdExA== X-Google-Smtp-Source: AKy350bGX9PS9n29BFv3O7rnfybRFE+28fHYl+KXdNrOWO7dgGugjkLGd4JfCmIGCEz0cnJoK/7z8X0t6aU+H3zb8yI= X-Received: by 2002:a17:906:11d8:b0:94e:fdd:9319 with SMTP id o24-20020a17090611d800b0094e0fdd9319mr3441779eja.15.1681306966838; Wed, 12 Apr 2023 06:42:46 -0700 (PDT) MIME-Version: 1.0 References: <20230403114608.1423020-1-juraj.linkes@pantheon.tech> <7872319.mogB4TqSGs@thomas> <CAOb5WZb_bF=qCR3i4q-f2bMjKbg+0kpCwohyepVJv93v9ZRLUA@mail.gmail.com> <5667444.DvuYhMxLoT@thomas> In-Reply-To: <5667444.DvuYhMxLoT@thomas> From: =?UTF-8?Q?Juraj_Linke=C5=A1?= <juraj.linkes@pantheon.tech> Date: Wed, 12 Apr 2023 15:42:35 +0200 Message-ID: <CAOb5WZYEtgAzWZp5oO13hZ1ex-p9Qec8FPqQQXx1aOtoJm6V5A@mail.gmail.com> Subject: Re: [PATCH v1 1/2] dts: fabric requirements To: Thomas Monjalon <thomas@monjalon.net> Cc: wathsala.vithanage@arm.com, jspewock@iol.unh.edu, probb@iol.unh.edu, Honnappa.Nagarahalli@arm.com, lijuan.tu@intel.com, bruce.richardson@intel.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Tue, Apr 11, 2023 at 4:48=E2=80=AFPM Thomas Monjalon <thomas@monjalon.ne= t> wrote: > > 04/04/2023 13:51, Juraj Linke=C5=A1: > > On Mon, Apr 3, 2023 at 5:18=E2=80=AFPM Thomas Monjalon <thomas@monjalon= .net> wrote: > > > > > 03/04/2023 16:56, Juraj Linke=C5=A1: > > > > On Mon, Apr 3, 2023 at 2:33=E2=80=AFPM Thomas Monjalon <thomas@monj= alon.net> > > > wrote: > > > > > > > > > 03/04/2023 13:46, Juraj Linke=C5=A1: > > > > > > Replace pexpect with Fabric. > > > > > > > > > > You should squash these lines with the move to Fabric. > > > > > > > > > > > Signed-off-by: Juraj Linke=C5=A1 <juraj.linkes@pantheon.tech> > > > > > > --- > > > > > > dts/poetry.lock | 553 > > > +++++++++++++++++++++++++++++++++++++++------ > > > > > > > > > > Do we really need *all* these lines? > > > > > I see a lot of lines about Windows and MacOSX which are not suppo= rted > > > in > > > > > DTS. > > > > > It is so long that it looks impossible to review. > > > > > > > > > > > > > > This is a generated file and doesn't need to be reviewed. > > > > > > In general, I don't like storing generated files. > > > > > > > Me neither, but this one is specifically designed to be stored in a > > repository: > > https://python-poetry.org/docs/basic-usage/#commit-your-poetrylock-file= -to-version-control > > > > > > > > > > > I separated the > > > > dependencies part so that the code part is easier to review. If you > > > want, I > > > > can squash the two commits. > > > > > > What happens if we manually remove the useless lines? > > > > > > > > The lock file is there so that everyone installs exactly the same versi= ons > > of dependencies. We can specify the versions of dependencies in > > pyproject.toml, but we won't control the versions of dependencies of > > dependencies this way. If we remove the changes to the lock file, then = we > > won't be storing tested versions, everyone would be using slightly > > different versions and we may potentially need to address versioning is= sues > > in the future - best to prevent that with a lock file. > > You didn't answer about removing the usuless lines, like unneeded Windows= support. > Do you mean the list of files from macos and windows? I tried removing those from mypy and testing it and it looks like it didn't have an impact, but I don't know the inner workings of poetry and the lock file to test it properly (i.e. to rule out any breakages). What would be the reason for removing those? Seems like it has more downsides (we could potentially break something and it's extra work) than updsides (as this is a generated file, I don't really see any).