From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 99DBC42B22; Tue, 16 May 2023 12:32:49 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8643F4114A; Tue, 16 May 2023 12:32:49 +0200 (CEST) Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) by mails.dpdk.org (Postfix) with ESMTP id C8A2B40A8B for ; Tue, 16 May 2023 12:32:47 +0200 (CEST) Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-96a2b6de3cbso1276185866b.1 for ; Tue, 16 May 2023 03:32:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon-tech.20221208.gappssmtp.com; s=20221208; t=1684233167; x=1686825167; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=rpRmRJcTkPXgRuIpdMH2StEWBpZ1Gb33T8AN+dYL8J0=; b=K5Iy5yd0FVGABbGRfjvW6rkE0qBbTRjClVCCUSf889AeXyDV6DSAg9fkD7g7Fr+3v9 yLwkMFOCV58TOEsteRjM9H7RB6OogWaES6KH8K2Ii+qTSp5oNkoMKdVggIHq8yoij/iu AIOeR5KEXvreERi4GUSN627OfKPZcM2RDrnONcPuARu8PjvIwpl/PaHNUNyoWldt0xKO B9HrbxL8rL61KatuO5AQtH/M/L8vcGPnCfuXW2Aaqp8+F/EXL+cnLVyEqbe/7kS5PxLD dvk9OqcQ3uXnofAizXOX7c1WXt8dk5u55DeTGR+AQ8njpcXcztCosdmmuMOt1caT0+Eu kNIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684233167; x=1686825167; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rpRmRJcTkPXgRuIpdMH2StEWBpZ1Gb33T8AN+dYL8J0=; b=NXP9WhD9Gz7nPS9mAKr7XU2bhwRoMhaRwCR67vpmTiJLNqoDcB7iUn8BUXGvCltGVl Xwdy02kWvDia3Wjvkwy+5DHJWULcnSU/T+X+fS+Eej/wMlosxqqjGoXRuT0yuyWZZIth bzNNH3YwyDZ1EaD/ZeXyOpzNejgBvK80muuz7jIv5aiz4efif7Bn4xPcHm2DkhG/FRfK TQO4uvpzzBdSoAgyvxdyauWNQKT+DExzsXwHDeD7EL5jzouUQUS24O/XZC8JcpVTzohv fQ8QSj8iF1Up+IzCSPijZWnPPXQNFk+bYX3Hs5xmoOx4/tJEWAhmeUy407AoNJw8TbcO Zzlw== X-Gm-Message-State: AC+VfDzeU6E+xIdZIq8TpUk5vrdNEsWUfMnsGlEj9WVzoJt4vnxeK8aR uNBn5w1T9z3UbczCoYB8CWly8ZANXsGgONZgtnqq0l41NvlU0ScofXw= X-Google-Smtp-Source: ACHHUZ7eIIIq3U0wQhi81yFBUzr75BaNQNMOjIyvi0addbyTUTqQwx3OMcH2zKA099junxjcBOZozm1cfqKClyYhjpo= X-Received: by 2002:a17:906:fe45:b0:92f:33ca:c9a3 with SMTP id wz5-20020a170906fe4500b0092f33cac9a3mr32044822ejb.71.1684233167306; Tue, 16 May 2023 03:32:47 -0700 (PDT) MIME-Version: 1.0 References: <20230331091355.1224059-1-juraj.linkes@pantheon.tech> <20230516101623.92252-1-juraj.linkes@pantheon.tech> In-Reply-To: <20230516101623.92252-1-juraj.linkes@pantheon.tech> From: =?UTF-8?Q?Juraj_Linke=C5=A1?= Date: Tue, 16 May 2023 12:32:36 +0200 Message-ID: Subject: Re: [PATCH v2] dts: update dependencies and mypy execution To: thomas@monjalon.net, Honnappa.Nagarahalli@arm.com, lijuan.tu@intel.com, bruce.richardson@intel.com, jspewock@iol.unh.edu, probb@iol.unh.edu Cc: dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, May 16, 2023 at 12:16=E2=80=AFPM Juraj Linke=C5=A1 wrote: > > Poetry changed the syntax of dev dependencies section in version > 1.2.0. Remove the scripts section that did nothing. > Update Pylama linters: > * pep8 is the same as pycodestyle > * pylint is missing dependencies and thus not executed. It reports a > number of warnings and may be introduced in a future patch. > * mypy doesn't work properly with Pylama. Pylama executes linting > file-by-file and mypy works on all files at once. > > Mypy has thus been moved outside Pylama and is executed separately. > Added Mypy configuration that allows fine-grained specification of > ignored issues. > > Signed-off-by: Juraj Linke=C5=A1 > --- > devtools/dts-check-format.sh | 21 ++- > doc/guides/tools/dts.rst | 1 + > dts/poetry.lock | 304 +++++++++++++++++++++++++++-------- > dts/pyproject.toml | 26 ++- > 4 files changed, 276 insertions(+), 76 deletions(-) > > > diff --git a/dts/poetry.lock b/dts/poetry.lock > index 0b2a007d4d..64d6c18f35 100644 > --- a/dts/poetry.lock > +++ b/dts/poetry.lock > @@ -1,24 +1,45 @@ > +# This file is automatically @generated by Poetry and should not be chan= ged by hand. > + Let's continue the discussion about the generated file we started here: http://patches.dpdk.org/project/dpdk/patch/20230403114608.1423020-1-j= uraj.linkes@pantheon.tech/ > [[package]] > name =3D "mypy" > @@ -116,6 +165,31 @@ description =3D "Optional static typing for Python" > category =3D "dev" > optional =3D false > python-versions =3D ">=3D3.6" > +files =3D [ > + {file =3D "mypy-0.961-cp310-cp310-macosx_10_9_universal2.whl", hash = =3D "sha256:697540876638ce349b01b6786bc6094ccdaba88af446a9abb967293ce6eaa2b= 0"}, > + {file =3D "mypy-0.961-cp310-cp310-macosx_10_9_x86_64.whl", hash =3D = "sha256:b117650592e1782819829605a193360a08aa99f1fc23d1d71e1a75a142dc7e15"}, > + {file =3D "mypy-0.961-cp310-cp310-macosx_11_0_arm64.whl", hash =3D "= sha256:bdd5ca340beffb8c44cb9dc26697628d1b88c6bddf5c2f6eb308c46f269bb6f3"}, > + {file =3D "mypy-0.961-cp310-cp310-manylinux_2_5_x86_64.manylinux1_x8= 6_64.manylinux_2_12_x86_64.manylinux2010_x86_64.whl", hash =3D "sha256:3e09= f1f983a71d0672bbc97ae33ee3709d10c779beb613febc36805a6e28bb4e"}, > + {file =3D "mypy-0.961-cp310-cp310-win_amd64.whl", hash =3D "sha256:e= 999229b9f3198c0c880d5e269f9f8129c8862451ce53a011326cad38b9ccd24"}, > + {file =3D "mypy-0.961-cp36-cp36m-macosx_10_9_x86_64.whl", hash =3D "= sha256:b24be97351084b11582fef18d79004b3e4db572219deee0212078f7cf6352723"}, > + {file =3D "mypy-0.961-cp36-cp36m-manylinux_2_5_x86_64.manylinux1_x86= _64.manylinux_2_12_x86_64.manylinux2010_x86_64.whl", hash =3D "sha256:f4a21= d01fc0ba4e31d82f0fff195682e29f9401a8bdb7173891070eb260aeb3b"}, > + {file =3D "mypy-0.961-cp36-cp36m-win_amd64.whl", hash =3D "sha256:43= 9c726a3b3da7ca84a0199a8ab444cd8896d95012c4a6c4a0d808e3147abf5d"}, > + {file =3D "mypy-0.961-cp37-cp37m-macosx_10_9_x86_64.whl", hash =3D "= sha256:5a0b53747f713f490affdceef835d8f0cb7285187a6a44c33821b6d1f46ed813"}, > + {file =3D "mypy-0.961-cp37-cp37m-manylinux_2_5_x86_64.manylinux1_x86= _64.manylinux_2_12_x86_64.manylinux2010_x86_64.whl", hash =3D "sha256:0e9f7= 0df36405c25cc530a86eeda1e0867863d9471fe76d1273c783df3d35c2e"}, > + {file =3D "mypy-0.961-cp37-cp37m-win_amd64.whl", hash =3D "sha256:b8= 8f784e9e35dcaa075519096dc947a388319cb86811b6af621e3523980f1c8a"}, > + {file =3D "mypy-0.961-cp38-cp38-macosx_10_9_universal2.whl", hash = =3D "sha256:d5aaf1edaa7692490f72bdb9fbd941fbf2e201713523bdb3f4038be0af8846c= 6"}, > + {file =3D "mypy-0.961-cp38-cp38-macosx_10_9_x86_64.whl", hash =3D "s= ha256:9f5f5a74085d9a81a1f9c78081d60a0040c3efb3f28e5c9912b900adf59a16e6"}, > + {file =3D "mypy-0.961-cp38-cp38-macosx_11_0_arm64.whl", hash =3D "sh= a256:f4b794db44168a4fc886e3450201365c9526a522c46ba089b55e1f11c163750d"}, > + {file =3D "mypy-0.961-cp38-cp38-manylinux_2_5_x86_64.manylinux1_x86_= 64.manylinux_2_12_x86_64.manylinux2010_x86_64.whl", hash =3D "sha256:64759a= 273d590040a592e0f4186539858c948302c653c2eac840c7a3cd29e51b"}, > + {file =3D "mypy-0.961-cp38-cp38-win_amd64.whl", hash =3D "sha256:63e= 85a03770ebf403291ec50097954cc5caf2a9205c888ce3a61bd3f82e17569"}, > + {file =3D "mypy-0.961-cp39-cp39-macosx_10_9_universal2.whl", hash = =3D "sha256:5f1332964963d4832a94bebc10f13d3279be3ce8f6c64da563d6ee6e2eeda93= 2"}, > + {file =3D "mypy-0.961-cp39-cp39-macosx_10_9_x86_64.whl", hash =3D "s= ha256:006be38474216b833eca29ff6b73e143386f352e10e9c2fbe76aa8549e5554f5"}, > + {file =3D "mypy-0.961-cp39-cp39-macosx_11_0_arm64.whl", hash =3D "sh= a256:9940e6916ed9371809b35b2154baf1f684acba935cd09928952310fbddaba648"}, > + {file =3D "mypy-0.961-cp39-cp39-manylinux_2_5_x86_64.manylinux1_x86_= 64.manylinux_2_12_x86_64.manylinux2010_x86_64.whl", hash =3D "sha256:a5ea08= 75a049de1b63b972456542f04643daf320d27dc592d7c3d9cd5d9bf950"}, > + {file =3D "mypy-0.961-cp39-cp39-win_amd64.whl", hash =3D "sha256:1ec= e702f29270ec6af25db8cf6185c04c02311c6bb21a69f423d40e527b75c56"}, > + {file =3D "mypy-0.961-py3-none-any.whl", hash =3D "sha256:03c6cc893e= 7563e7b2949b969e63f02c000b32502a1b4d1314cabe391aa87d66"}, > + {file =3D "mypy-0.961.tar.gz", hash =3D "sha256:f730d56cb924d371c26b= 8eaddeea3cc07d78ff51c521c6d04899ac6904b75492"}, > +] The contentious point was the non-linux files among the lists of files in some packages. I think leaving these in doesn't result in any extra work in terms of review or maintenance. There's no reason to review this file, as it's effectively automatically managed by Poetry and the only maintenance needed is to update it when updating/adding dependencies. In addition, no one will (or should) ever look into this file, it's not meant to be consumed by users. Also, DTS is designed to allow support for different OS's (if anyone wishes to implement it), so leaving it in makes sense in this way.