From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 73DC74265D; Thu, 28 Sep 2023 09:34:07 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5F1C340296; Thu, 28 Sep 2023 09:34:07 +0200 (CEST) Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) by mails.dpdk.org (Postfix) with ESMTP id 6CAA240273 for ; Thu, 28 Sep 2023 09:34:06 +0200 (CEST) Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-5345a3dfe3bso7036801a12.3 for ; Thu, 28 Sep 2023 00:34:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1695886446; x=1696491246; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Mo9Ip49WLj5qncNYKWTajF5b2L0rA5SRH9lSp3+2ERs=; b=E48W/TPWmccdR2mTFvfnjEBD5aVnGGirri0QUb3ByoqDPI3pObYY8BN86remNnktww kDKTOnvLjhwF+esFCo70EkNIdCbe4n8Lc1uYZjfKmnry5qbonOkdd36we8ih5S+AzFed 7hlY5D1F8hlaYeypYSfc+95tJJAsHAD7zrA7JbmawP2DbyMbjtbI9QXFpL2gFILhDzSz nGYSbhManQLpAMd9trIzC465W8EAaB7CgBrGkHAh2Z7iiYUoc6Xr6tJxLPFilAmgLQXl cURPxEUSAjyFSzDN4UZngtqWPXPLztd5FdQpKt78+kaB/QG74DfmfAoxrENNO6VIeJI1 wrdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695886446; x=1696491246; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Mo9Ip49WLj5qncNYKWTajF5b2L0rA5SRH9lSp3+2ERs=; b=By+YW5jDja3Q1UT8s1X2oA0psSyise/aIndp1fpiW9RxvkD8o+nLE2giiPqps9i8uO +JxyqFeHmO7AnTszCwHdCFn2f268EY8SAe9kcQ04xULVt0Kex/ouHwz8H4CW7aSVuuGy xB2JEWL2KNRxDxG+C9V5k6nKtZXRf4zHxrFVUMhfmGAmDtqYcG9mkyMBXAdMfb/oQpke NyY/R6IfB83fT2zGTBrzh6xbShqYzhZaMtRjGLjirmzTFIQ5XcSYrcfHfdmmtH4/tiUJ KMb8nssvhWHwHgqfRsa1t3dtrSvqBT9W3boydmQgmYxd2KgOqXpI8LsRETJfc4EizNPA ZWTw== X-Gm-Message-State: AOJu0YzaWiMKkSqpLDuijs694IPW8NoPwJ8lGl6kQ7ZnHZcdRJKU9W6+ 9IJ1TkCj3NncVLeV/DAGuKCff3nUvUC5t3wi9ApiEg== X-Google-Smtp-Source: AGHT+IGPk5vxfSd0UDi1QkShW4s4uMfHF6+EPzSKrIh/lIfv8KcJDNT8oVZf+34TBrgFRB7bA0ehDvq7lkMCVC8CeYY= X-Received: by 2002:aa7:d1cc:0:b0:527:fa8d:d40b with SMTP id g12-20020aa7d1cc000000b00527fa8dd40bmr443946edp.26.1695886446091; Thu, 28 Sep 2023 00:34:06 -0700 (PDT) MIME-Version: 1.0 References: <20221103132926.445627-3-juraj.linkes@pantheon.tech> <20230926121013.23351-1-juraj.linkes@pantheon.tech> <20230926121013.23351-2-juraj.linkes@pantheon.tech> In-Reply-To: From: =?UTF-8?Q?Juraj_Linke=C5=A1?= Date: Thu, 28 Sep 2023 09:33:55 +0200 Message-ID: Subject: Re: [PATCH v2 2/2] dts: reformat to 100 line length To: Bruce Richardson Cc: thomas@monjalon.net, Honnappa.Nagarahalli@arm.com, jspewock@iol.unh.edu, probb@iol.unh.edu, stephen@networkplumber.org, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Sep 27, 2023 at 10:08=E2=80=AFAM Bruce Richardson wrote: > > On Tue, Sep 26, 2023 at 02:10:13PM +0200, Juraj Linke=C5=A1 wrote: > > Reformat to 100 from the previous 88 to unify with C recommendations. > > > > Signed-off-by: Juraj Linke=C5=A1 > > Generally for something like this we wouldn't reformat the existing code, > because it confuses the git history e.g. for those looking for "fixlines" > for bug fixes. However, given that DTS is so new in the repo, it's probab= ly > ok and worthwhile doing. > > Acked-by: Bruce Richardson Thanks for pointing this out, Bruce, I'll keep it in mind for the future. For now, it's kinda necessary we do this because our reformat tool, Black, reformats the whole codebase so I think the pros outweigh the cons. One more thing: I originally wanted to put this config part into the first patch (I wanted this patch to be only code changes) which I plan on fixing in the next version: diff --git a/dts/pyproject.toml b/dts/pyproject.toml index 6762edfa6b..980ac3c7db 100644 --- a/dts/pyproject.toml +++ b/dts/pyproject.toml @@ -41,7 +41,7 @@ build-backend =3D "poetry.core.masonry.api" [tool.pylama] linters =3D "mccabe,pycodestyle,pyflakes" format =3D "pylint" -max_line_length =3D 88 # https://black.readthedocs.io/en/stable/the_black_code_style/current_style.h= tml#line-length +max_line_length =3D 100 [tool.mypy] python_version =3D "3.10" @@ -55,4 +55,4 @@ profile =3D "black" [tool.black] target-version =3D ['py310'] include =3D '\.pyi?$' -line-length =3D 88 # https://black.readthedocs.io/en/stable/the_black_code_style/current_style.h= tml#line-length +line-length =3D 100