From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7B78043E2D; Tue, 9 Apr 2024 21:12:53 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 48979402C7; Tue, 9 Apr 2024 21:12:53 +0200 (CEST) Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) by mails.dpdk.org (Postfix) with ESMTP id ADF8E402C6 for ; Tue, 9 Apr 2024 21:12:50 +0200 (CEST) Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-56c5d05128dso6724688a12.0 for ; Tue, 09 Apr 2024 12:12:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1712689970; x=1713294770; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=lVrofN6aDK3l40hEDDzkG0Pku5DcFIyPDD8NPQprChA=; b=vpYRVcGEumfEyA3vK0wKEch1rdePh0ytgYvNDQBi95ZwNgsnv9U2tUILpt2oNrc55C jynHZazC7429BiTOxHOXZW04rIwnSrjkNXk3je0364/AosulWuQ4cV6OJsDE1Nhaz044 Ehdjwn9DOTtNvVp7ZWGj+1RVdlG2T0QVXiFnnbVmTFXxJYomHY3+HHxWHxtMXRSQqKBj Thcjccf72QElgsQ4ZVrFQyJ+JNRdI16psIFZjxaUs19O/9XzFuZL5Qz6XVIYHkUlZoux 3V5Bb1zwxOPc9SwKhHIX6zCO7nznrdi/6Bb4/ZW1Rb9OXbRxM4Eoq8Uwl9QpIdf7VDCM 5F0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712689970; x=1713294770; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lVrofN6aDK3l40hEDDzkG0Pku5DcFIyPDD8NPQprChA=; b=F1WhfwFUNsJ2y2ak/e9bhUGJOQuQkU3kw97RqcPLPajdnT4vZq2VkNrPKbWOkqnT0B DcITPRa6167UkHvSNHpQizj7a0DghULWwnFCPzevcw9x3oxQOwtYD0N0u/mvunf0vxLy 08wregOYi/mq0J1Lg3ODHKcMiN3QFMBJH7szXW+Cl10Iwc1pq1RKb5wMRoDDMs26H3EH 16SoOwqWj3eT6qrzjYSYSbWRzonWWsBAWYNe0IfP7mlfBWakCWKdVUAhbHt2184UnL4K 9RNMoJd6aG0P8ya4fKDyE5/HFPVdf9ZamFyZ/RdmGO8h/chJCijK5xT+TABiHq96GXdm 2IcA== X-Gm-Message-State: AOJu0YwgsOkWjfz9+CnD3NWx/SBjtwS8N7yPHKu/8F+H6/3BsQOBK2PI WZejqyOqFDrAWgR9mbhhPQFhKTKB+u4UlQIDv5YnjvX9GOMzV0fXyo41SbDIw+YENDA6Ty7ukn3 W0seijA1bibw1GxT2q3pXiWHKxVG/be6z5U6v5w== X-Google-Smtp-Source: AGHT+IGv9LNh45YCuW6pOri6Ox1Z3MCyfCFjmVLhuvs36A1fQUh4goSNiRzNr4Z4v8wYAD5pSXonQvQtKaNQ1ZrEybc= X-Received: by 2002:a50:a688:0:b0:56e:6e0:9f39 with SMTP id e8-20020a50a688000000b0056e06e09f39mr304543edc.17.1712689970482; Tue, 09 Apr 2024 12:12:50 -0700 (PDT) MIME-Version: 1.0 References: <20240326190422.577028-1-luca.vizzarro@arm.com> <20240326190422.577028-5-luca.vizzarro@arm.com> In-Reply-To: <20240326190422.577028-5-luca.vizzarro@arm.com> From: =?UTF-8?Q?Juraj_Linke=C5=A1?= Date: Tue, 9 Apr 2024 21:12:39 +0200 Message-ID: Subject: Re: [PATCH 4/6] dts: use testpmd params for scatter test suite To: Luca Vizzarro Cc: dev@dpdk.org, Jack Bond-Preston , Honnappa Nagarahalli Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Mar 26, 2024 at 8:04=E2=80=AFPM Luca Vizzarro wrote: > > Update the buffer scatter test suite to use TestPmdParameters > instead of the StrParams implementation. > > Signed-off-by: Luca Vizzarro > Reviewed-by: Jack Bond-Preston > Reviewed-by: Honnappa Nagarahalli > --- > dts/tests/TestSuite_pmd_buffer_scatter.py | 19 +++++++++++-------- > 1 file changed, 11 insertions(+), 8 deletions(-) > > diff --git a/dts/tests/TestSuite_pmd_buffer_scatter.py b/dts/tests/TestSu= ite_pmd_buffer_scatter.py > index 4cdbdc4272..c6d313fc64 100644 > --- a/dts/tests/TestSuite_pmd_buffer_scatter.py > +++ b/dts/tests/TestSuite_pmd_buffer_scatter.py > @@ -23,7 +23,11 @@ > from scapy.utils import hexstr # type: ignore[import] > > from framework.params import StrParams > -from framework.remote_session.testpmd_shell import TestPmdForwardingMode= s, TestPmdShell > +from framework.remote_session.testpmd_shell import ( > + TestPmdForwardingModes, > + TestPmdShell, > + TestPmdParameters, > +) > from framework.test_suite import TestSuite > > > @@ -104,16 +108,15 @@ def pmd_scatter(self, mbsize: int) -> None: > """ > testpmd =3D self.sut_node.create_interactive_shell( > TestPmdShell, > - app_parameters=3DStrParams( > - "--mbcache=3D200 " > - f"--mbuf-size=3D{mbsize} " > - "--max-pkt-len=3D9000 " > - "--port-topology=3Dpaired " > - "--tx-offloads=3D0x00008000" > + app_parameters=3DTestPmdParameters( > + forward_mode=3DTestPmdForwardingModes.mac, > + mbcache=3D200, > + mbuf_size=3D[mbsize], > + max_pkt_len=3D9000, > + tx_offloads=3D0x00008000, > ), > privileged=3DTrue, > ) > - testpmd.set_forward_mode(TestPmdForwardingModes.mac) Jeremy, does this change the test? Instead of configuring the fw mode after starting testpmd, we're starting testpmd with fw mode configured. If not, we should remove the testpmd.set_forward_mode method, as it's not used anymore. > testpmd.start() > > for offset in [-1, 0, 1, 4, 5]: > -- > 2.34.1 >