From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0FFFC4292F; Thu, 13 Apr 2023 09:50:00 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E1FA540A84; Thu, 13 Apr 2023 09:49:59 +0200 (CEST) Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) by mails.dpdk.org (Postfix) with ESMTP id 81AA44021F for ; Thu, 13 Apr 2023 09:49:58 +0200 (CEST) Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-504ecfdf6b6so1424102a12.3 for ; Thu, 13 Apr 2023 00:49:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon-tech.20221208.gappssmtp.com; s=20221208; t=1681372198; x=1683964198; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=g1oRuYb8H54Hk+gUXs1b25cXPCFbw2WegU+1D9L/hdM=; b=CjPG91zcyf+kBLtUmofLDpbtmnV5YLQz47/ZnOC94dyOEB9wTNt+dj79TmTpe+wepU WCD65UWPh50BKIjUzijj7VgxLZrMTNYZnAqv/oKlNHwP7sigf6kd/ZpN1T8HY6HIkO0D DzyT4fjjZSmwCV+CPJI717wccsDa5xge2i/IkKUV9NddOUTZn11UzyU5N6Ldd2zSNkk5 3+WxkuaCaPtJ6hSypqwomICc2CSJ/tAvQboNr9HgpwLjjBXRQKHwNEGY2Ze76ggWT4uh xr5gByygChUJ+W5wopHRPwPNPzu/TUf9KiX0U49xrK8HYLeWekozwYm1biDHIxTW9Pbk cdmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681372198; x=1683964198; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=g1oRuYb8H54Hk+gUXs1b25cXPCFbw2WegU+1D9L/hdM=; b=AUO1cfuHKnY8Lg53zw5KxAjeKkN0AxvqTHPfoVuye13zIxqrsMe11lfHUJOkpiVHEu qDLinmBqoxY3xBqhx8jG9qqqxDhLLTF/zb1Z8m57dgO9DdbfSr7X365a4t5BcETHL9qr a2ZqCKn404Lw8IK85CFQdsYHh1YOtxqrExmI6bPkuQ9WqEbdANDUORAJ6s647DMNumrZ jAZinQJlXyuReIMmTxiy05/xTGJRFJZsivHWpwOsppv9EWeUDuN1bnH7Hx6QE6eoPfha ZivR1xKQfIktGUf/0gKrx3IwEfP60pGTmheaZpGIQb2QVja/lTl+9Gm+OyjOM20xeAEa ZQBQ== X-Gm-Message-State: AAQBX9eyAaXaQPd9gFLWfP/hdNYSrA4o9yJ65UfyYvLEwtUZbf39AlaM gm9QA6K852AuwwJ01O9yOl9Cxv+lCR0KzJe57TOxYQ== X-Google-Smtp-Source: AKy350akrXDpOLak+P+qTqe7kbcVDdZA3A8shBZj4IeohNcR011dYzMtjrBG97tiWXwstZ3oUSC06ORFysScYgy7jIg= X-Received: by 2002:a50:c044:0:b0:502:49bf:7e8d with SMTP id u4-20020a50c044000000b0050249bf7e8dmr709873edd.8.1681372198096; Thu, 13 Apr 2023 00:49:58 -0700 (PDT) MIME-Version: 1.0 References: <20230403114608.1423020-1-juraj.linkes@pantheon.tech> <5667444.DvuYhMxLoT@thomas> <3228692.44csPzL39Z@thomas> In-Reply-To: From: =?UTF-8?Q?Juraj_Linke=C5=A1?= Date: Thu, 13 Apr 2023 09:49:47 +0200 Message-ID: Subject: Re: [PATCH v1 1/2] dts: fabric requirements To: Honnappa Nagarahalli Cc: "thomas@monjalon.net" , Wathsala Wathawana Vithanage , "jspewock@iol.unh.edu" , "probb@iol.unh.edu" , "lijuan.tu@intel.com" , "bruce.richardson@intel.com" , "dev@dpdk.org" , nd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Apr 13, 2023 at 8:50=E2=80=AFAM Juraj Linke=C5=A1 wrote: > > On Wed, Apr 12, 2023 at 5:38=E2=80=AFPM Honnappa Nagarahalli > wrote: > > > > > > > > > -----Original Message----- > > > From: Thomas Monjalon > > > Sent: Wednesday, April 12, 2023 10:25 AM > > > To: Juraj Linke=C5=A1 > > > Cc: Wathsala Wathawana Vithanage ; > > > jspewock@iol.unh.edu; probb@iol.unh.edu; Honnappa Nagarahalli > > > ; lijuan.tu@intel.com; > > > bruce.richardson@intel.com; dev@dpdk.org > > > Subject: Re: [PATCH v1 1/2] dts: fabric requirements > > > > > > 12/04/2023 15:42, Juraj Linke=C5=A1: > > > > On Tue, Apr 11, 2023 at 4:48=E2=80=AFPM Thomas Monjalon > > > wrote: > > > > > > > > > > 04/04/2023 13:51, Juraj Linke=C5=A1: > > > > > > On Mon, Apr 3, 2023 at 5:18=E2=80=AFPM Thomas Monjalon > > > wrote: > > > > > > > > > > > > > 03/04/2023 16:56, Juraj Linke=C5=A1: > > > > > > > > On Mon, Apr 3, 2023 at 2:33=E2=80=AFPM Thomas Monjalon > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > 03/04/2023 13:46, Juraj Linke=C5=A1: > > > > > > > > > > Replace pexpect with Fabric. > > > > > > > > > > > > > > > > > > You should squash these lines with the move to Fabric. > > > > > > > > > > > > > > > > > > > Signed-off-by: Juraj Linke=C5=A1 > > > > > > > > > > --- > > > > > > > > > > dts/poetry.lock | 553 > > > > > > > +++++++++++++++++++++++++++++++++++++++------ > > > > > > > > > > > > > > > > > > Do we really need *all* these lines? > > > > > > > > > I see a lot of lines about Windows and MacOSX which are n= ot > > > > > > > > > supported > > > > > > > in > > > > > > > > > DTS. > > > > > > > > > It is so long that it looks impossible to review. > > > > > > > > > > > > > > > > > > > > > > > > > > This is a generated file and doesn't need to be reviewed. > > > > > > > > > > > > > > In general, I don't like storing generated files. > > > > > > > > > > > > > > > > > > > Me neither, but this one is specifically designed to be stored = in > > > > > > a > > > > > > repository: > > > > > > https://python-poetry.org/docs/basic-usage/#commit-your-poetryl= ock > > > > > > -file-to-version-control > > > > > > > > > > > > > > > > > > > > > > > > > > > I separated the > > > > > > > > dependencies part so that the code part is easier to review= . > > > > > > > > If you > > > > > > > want, I > > > > > > > > can squash the two commits. > > > > > > > > > > > > > > What happens if we manually remove the useless lines? > > > > > > > > > > > > > > > > > > > > The lock file is there so that everyone installs exactly the sa= me > > > > > > versions of dependencies. We can specify the versions of > > > > > > dependencies in pyproject.toml, but we won't control the versio= ns > > > > > > of dependencies of dependencies this way. If we remove the chan= ges > > > > > > to the lock file, then we won't be storing tested versions, > > > > > > everyone would be using slightly different versions and we may > > > > > > potentially need to address versioning issues in the future - b= est to prevent > > > that with a lock file. > > > > > > > > > > You didn't answer about removing the usuless lines, like unneeded= Windows > > > support. > > > > > > > > > > > > > Do you mean the list of files from macos and windows? I tried remov= ing > > > > those from mypy and testing it and it looks like it didn't have an > > > > impact, but I don't know the inner workings of poetry and the lock > > > > file to test it properly (i.e. to rule out any breakages). What wou= ld > > > > be the reason for removing those? Seems like it has more downsides = (we > > > > could potentially break something and it's extra work) than updside= s > > > > (as this is a generated file, I don't really see any). > > > > > > Yes this is what I mean. > > > Any other opinion? > > > > > If it is a generated file, there might be an expectation from the tool = that the file is not changed. It would be good to understand this. > > > > Since it is a generated file, should we generate this during DTS run ti= me rather than storing a generated file? > > > > The file is not used during runtime, but rather when installing > dependencies. It's supposed to be generated by maintainers (once every > time dependencies change or need updating) who verify the versions > defined in the generated lockfile so that everyone then uses the same > versions from that point on, preventing issues arising from different > users using different versions of dependencies. So it's maintainers > giving this file to other people. > > Juraj I looked into this some more and I have some extra stuff to explain. There's another patch that updates and cleans up the dependencies: http://patches.dpdk.org/project/dpdk/patch/20230331091355.1224059-1-juraj.l= inkes@pantheon.tech/ To do this patch, I updated my Poetry version to 1.2.0 and apparently, then changed the file lists of packages. Before, they had that in a separate section and in Poetry 1.2.0 they separated it into packages. This led to this patch having a lot of unrelated changes (in unrelated dependencies) brought on by the Poetry upgrade. I'll submit an update with just the pexpect/fabric switch and we can discuss the changes brought by the Poetry update in the other patch.