From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0DF244401B; Mon, 13 May 2024 17:03:09 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A5FCF402EC; Mon, 13 May 2024 17:03:08 +0200 (CEST) Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) by mails.dpdk.org (Postfix) with ESMTP id 0D73C402CD for ; Mon, 13 May 2024 17:03:07 +0200 (CEST) Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-a59a0168c75so1166269966b.1 for ; Mon, 13 May 2024 08:03:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1715612586; x=1716217386; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=umldktBR8GDihn7fK6Rr6cGVJ2L1O1i6mJne3jD2yeo=; b=PVYJUR36NsQjZQycZHcWIKiURG8OT9iaE87ypIzJ0NaEAPiz+3GO+JkrjaSx0yL9Zn 11iLWq1bZ8UH497qXbnSOeL9yc0MkB3EsKVZxPUvoUyyI3Jdymbths0QmbXT6XK+J/xY WlKEDfscmUspzEzte423CX4r/4KxOWVZfCQVCzdmk0MD1GOLCfER0og9GHsiMXx34uzt x5q3tlWUDtirb0HETLnz5IEEWMNvTO4Z3QSpOr4TI1ioE6ChecHhh0lR+tKx6XA2+egQ xHVJFdIP88UM2RzfzGwGyhJGlhWj8mZJnhgHIU60ZZiKsdCW7EHfCLC2aCDbYagx/EZl E7Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715612586; x=1716217386; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=umldktBR8GDihn7fK6Rr6cGVJ2L1O1i6mJne3jD2yeo=; b=JKG2jhrbE6zXrsQdNNU8E4WUif7DxfZzzW8jeiDdRjK2nBe0dbPG/ebF8ryz2EUUf2 UpIbUXRnvBYqZyEpVaEJ6SKIORDSTvvpenmBbzIsrn94YNH5g0vqKH2G2OD1+bVILE/K yLDFdzX0Rh0c+j3AK8koE/jPBXaEBEaSk95Rl+k7b7lY/Vo91HHT1RLdKpZPMgDEcF9x /d0Potebpg3j3xC/zV01DWYmA0I6KXu1j4hjzSyKL04rkkKe7eebVnVpHeEBL96NNIJB bclCGE2Avx2qO545tnpp69auHA5O/3xvrc/fKgY+upW2i+7ce7DI1PuL68m1l0oZQ0oN Rhyg== X-Forwarded-Encrypted: i=1; AJvYcCWjiXz5YnIdQILFfe8FSDIr4HgQLCAjwtobX1atww+05wvGw/2EOI7VpUD/89e2ZrZINcjslp5qrpk5IW0= X-Gm-Message-State: AOJu0YyYPWfjvMTucSQFNx21QIOupofqj3BJtWN1JmYNvS/FhYRuAlOs Q5+QittN1vzFS+4cLFHsgekG9sBnmUlLox3CUcAL2KeXAByV+EXi1ZpyL2mR8EsIuD6tGAKIwW7 q7INuyMfDY3OiNjAd/RS+D2AJrtPW3ZxPcdEaHg== X-Google-Smtp-Source: AGHT+IGiYeIOd2abpt8kzrJgirlYDubUE5zNnkiETzHM7YA/xTY+1f/gsGdZ77YVBBsT4pjYVYgIruLsF46LOyZ1pB0= X-Received: by 2002:a17:906:194a:b0:a58:e8c7:c0b8 with SMTP id a640c23a62f3a-a5a2d53ad9amr683987566b.7.1715612586472; Mon, 13 May 2024 08:03:06 -0700 (PDT) MIME-Version: 1.0 References: <20240312172558.11844-1-jspewock@iol.unh.edu> <20240501161623.26672-1-jspewock@iol.unh.edu> <20240501161623.26672-4-jspewock@iol.unh.edu> In-Reply-To: <20240501161623.26672-4-jspewock@iol.unh.edu> From: =?UTF-8?Q?Juraj_Linke=C5=A1?= Date: Mon, 13 May 2024 17:02:55 +0200 Message-ID: Subject: Re: [PATCH v2 3/3] dts: Improve logging for interactive shells To: jspewock@iol.unh.edu Cc: Luca.Vizzarro@arm.com, wathsala.vithanage@arm.com, yoan.picchi@foss.arm.com, paul.szczepanek@arm.com, probb@iol.unh.edu, thomas@monjalon.net, Honnappa.Nagarahalli@arm.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Good idea. And again, with the one minor point below, Reviewed-by: Juraj Linke=C5=A1 > diff --git a/dts/framework/remote_session/interactive_shell.py b/dts/fram= ework/remote_session/interactive_shell.py > index 0b0ccdb545..eb9c9b6843 100644 > --- a/dts/framework/remote_session/interactive_shell.py > +++ b/dts/framework/remote_session/interactive_shell.py > @@ -91,7 +92,7 @@ def __init__( > self._stdout =3D self._ssh_channel.makefile("r") > self._ssh_channel.settimeout(timeout) > self._ssh_channel.set_combine_stderr(True) # combines stdout an= d stderr streams > - self._logger =3D logger > + self._logger =3D get_dts_logger(f"{interactive_session._node_con= fig.name}.{name}") We should make interactive_session._node_config public since we're referencing it outside the class. > self._timeout =3D timeout > self._app_args =3D app_args > self._start_application(get_privileged_command)