From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1308443E36; Wed, 10 Apr 2024 15:19:10 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F1824402CF; Wed, 10 Apr 2024 15:19:09 +0200 (CEST) Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) by mails.dpdk.org (Postfix) with ESMTP id EE8F0402C7 for ; Wed, 10 Apr 2024 15:19:08 +0200 (CEST) Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-56e2b41187aso8285457a12.1 for ; Wed, 10 Apr 2024 06:19:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1712755148; x=1713359948; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=JrQcj0jLoluOexNxuw6OHpr9kJYdaEceMTJh0lIfCho=; b=jsT1HuiYDTkT/qRboskh0dAvDPwbh/tSqp/rbwflC6tJwZlTlntnamSD9vFSR4Hlpk /Rm1qHUbqJFp+0yor6eciYvrDHFb9CnOEReuakPY4rr92Z6vdxLW0oZYmqLGaWOJ1yjK W2mv8AdTK119PMlXMmmem6BktNABQZ35T+kINAlceEWPkAL2/2dmMWK0s++Na6ZTQBrx gjVD0FHg1PXBRkT5DsIec6jbLY2ZK+6/totKOxcch5xavPgyNpXZaqFwqnoskd2tLIBI XNMYeRGoKRO0TUQiPoUy7sY3fWxuHQxmnONheJCgAON7crrF6fbJCNGn0q4qUjqQ1Ldy x9hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712755148; x=1713359948; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JrQcj0jLoluOexNxuw6OHpr9kJYdaEceMTJh0lIfCho=; b=xK8Scgd56v93nVwrpSs3zG32B/B1wEBQDfAHMakQLbD2vVm/ACItx5VSaxLVH26nIe Rir2N2jarqcWYC+g4nlenWKw0NG29+CUQbJOXzxth90bFNvFNN/iNRdWGILtdqM0QIWr rWisosCCphwmEgtX+QOw9g42zEKnQMCPdqqW0yBiBKgtmsP+5wPn8UlAyY/ymSQGVujM PHuQMi0dOKgm7lYXOJjUGjYYBKTbUItmz+Jr273yYCu34IfiTgOhVEVLxBwZWYJd7s4o slKzEBKa/TQHrAPtsyxuIKeKcjz3VcgzIx/c1eUFTGEx7hs879bdXn2x1T3AJfgQNl91 2d3g== X-Forwarded-Encrypted: i=1; AJvYcCW95ld8lX4rYBB0Eusna6QCh23y344/U/ZBvDE8Iln3/N0zWHE4Rj+YfblRY+8vSXXyC8F+QKk/9nKeMR8= X-Gm-Message-State: AOJu0YxETQ6tuMNj8wGH+OHWFhSyuX9c9iWL0GjGjMGA0l4zYAGisFXU pIaPu9DlWdAq/biPdDq0aWOnHUxk+QbymN7eMHGtXMQSMaKOJxC901j612s7nCM6bzGrRbgiE9A x3EuzOw9QWb/3Po5iY8Gv4E+WOsikergs/7qvMw== X-Google-Smtp-Source: AGHT+IE4GlVHf3Es5vkYnQBvFkomis/Fll6Tg8Tu3j1snjqN/Zactqmv73fjeiI5kzjeq5A7WGmfCQ80GWNuoQofigE= X-Received: by 2002:a05:6402:1f11:b0:56e:7537:b508 with SMTP id b17-20020a0564021f1100b0056e7537b508mr4547635edb.0.1712755148597; Wed, 10 Apr 2024 06:19:08 -0700 (PDT) MIME-Version: 1.0 References: <20240326190422.577028-1-luca.vizzarro@arm.com> <20240326190422.577028-5-luca.vizzarro@arm.com> In-Reply-To: From: =?UTF-8?Q?Juraj_Linke=C5=A1?= Date: Wed, 10 Apr 2024 15:18:57 +0200 Message-ID: Subject: Re: [PATCH 4/6] dts: use testpmd params for scatter test suite To: Luca Vizzarro Cc: Jeremy Spewock , dev@dpdk.org, Jack Bond-Preston , Honnappa Nagarahalli Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Apr 10, 2024 at 12:53=E2=80=AFPM Luca Vizzarro wrote: > > On 09/04/2024 20:12, Juraj Linke=C5=A1 wrote: > >> @@ -104,16 +108,15 @@ def pmd_scatter(self, mbsize: int) -> None: > >> """ > >> testpmd =3D self.sut_node.create_interactive_shell( > >> TestPmdShell, > >> - app_parameters=3DStrParams( > >> - "--mbcache=3D200 " > >> - f"--mbuf-size=3D{mbsize} " > >> - "--max-pkt-len=3D9000 " > >> - "--port-topology=3Dpaired " > >> - "--tx-offloads=3D0x00008000" > >> + app_parameters=3DTestPmdParameters( > >> + forward_mode=3DTestPmdForwardingModes.mac, > >> + mbcache=3D200, > >> + mbuf_size=3D[mbsize], > >> + max_pkt_len=3D9000, > >> + tx_offloads=3D0x00008000, > >> ), > >> privileged=3DTrue, > >> ) > >> - testpmd.set_forward_mode(TestPmdForwardingModes.mac) > > > > Jeremy, does this change the test? Instead of configuring the fw mode > > after starting testpmd, we're starting testpmd with fw mode > > configured. > > I am not Jeremy (please Jeremy still reply), but we discussed this on > Slack. Reading through the testpmd source code, setting arguments like > forward-mode in the command line, is the exact equivalent of calling > `set forward mode` right after start-up. So it is equivalent in theory. > > > If not, we should remove the testpmd.set_forward_mode method, as it's > > not used anymore. > > Could there be test cases that change the forward mode multiple times in > the same shell, though? As this could still be needed to cover this. Yes, but we don't have such a test now. It's good practice to remove unused code. We can still bring it back anytime, it'll be in git history.