From: "Juraj Linkeš" <juraj.linkes@pantheon.tech>
To: Luca Vizzarro <luca.vizzarro@arm.com>
Cc: dev@dpdk.org, Jeremy Spewock <jspewock@iol.unh.edu>,
Paul Szczepanek <paul.szczepanek@arm.com>
Subject: Re: [PATCH 2/2] dts: clean up config types
Date: Mon, 13 May 2024 18:12:01 +0200 [thread overview]
Message-ID: <CAOb5WZaAyBCH4UwfJu6O3HFMtFNdPZvSf9VDv_hYsBSV1ipGUg@mail.gmail.com> (raw)
In-Reply-To: <20240509105704.1162449-3-luca.vizzarro@arm.com>
> diff --git a/dts/framework/testbed_model/traffic_generator/__init__.py b/dts/framework/testbed_model/traffic_generator/__init__.py
> @@ -39,8 +39,8 @@ def create_traffic_generator(
> Returns:
> A traffic generator capable of capturing received packets.
> """
> - match traffic_generator_config.traffic_generator_type:
> - case TrafficGeneratorType.SCAPY:
> + match traffic_generator_config:
> + case ScapyTrafficGeneratorConfig():
> return ScapyTrafficGenerator(tg_node, traffic_generator_config)
> case _:
> raise ConfigurationError(
Just one minor ask, could you fix the error string to an f-string?
next prev parent reply other threads:[~2024-05-13 16:12 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 10:57 [PATCH 0/2] dts: update mypy and clean up Luca Vizzarro
2024-05-09 10:57 ` [PATCH 1/2] dts: update mypy static checker Luca Vizzarro
2024-05-13 16:02 ` Juraj Linkeš
2024-05-14 11:30 ` Luca Vizzarro
2024-05-29 11:22 ` Juraj Linkeš
2024-05-09 10:57 ` [PATCH 2/2] dts: clean up config types Luca Vizzarro
2024-05-13 16:12 ` Juraj Linkeš [this message]
2024-05-14 11:30 ` Luca Vizzarro
2024-05-29 11:41 ` Juraj Linkeš
2024-05-14 11:34 ` [PATCH v2 0/2] dts: update mypy and clean up Luca Vizzarro
2024-05-14 11:34 ` [PATCH v2 1/2] dts: update mypy static checker Luca Vizzarro
2024-05-24 14:51 ` Patrick Robb
2024-05-28 12:00 ` Luca Vizzarro
2024-05-29 10:58 ` Juraj Linkeš
2024-05-29 11:39 ` Juraj Linkeš
2024-05-29 15:20 ` Luca Vizzarro
2024-05-14 11:34 ` [PATCH v2 2/2] dts: clean up config types Luca Vizzarro
2024-05-24 16:13 ` Patrick Robb
2024-05-20 15:37 ` [PATCH v2 0/2] dts: update mypy and clean up Nicholas Pratte
2024-05-21 14:59 ` Luca Vizzarro
2024-05-24 13:47 ` Nicholas Pratte
2024-05-24 16:17 ` Patrick Robb
2024-05-28 12:05 ` Luca Vizzarro
2024-05-29 10:44 ` Juraj Linkeš
2024-05-30 15:19 ` [PATCH v3 " Luca Vizzarro
2024-05-30 15:19 ` [PATCH v3 1/2] dts: update mypy static checker Luca Vizzarro
2024-05-30 20:23 ` Jeremy Spewock
2024-05-31 9:29 ` Juraj Linkeš
2024-05-30 15:19 ` [PATCH v3 2/2] dts: clean up config types Luca Vizzarro
2024-05-30 20:23 ` Jeremy Spewock
2024-05-31 9:29 ` Juraj Linkeš
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOb5WZaAyBCH4UwfJu6O3HFMtFNdPZvSf9VDv_hYsBSV1ipGUg@mail.gmail.com \
--to=juraj.linkes@pantheon.tech \
--cc=dev@dpdk.org \
--cc=jspewock@iol.unh.edu \
--cc=luca.vizzarro@arm.com \
--cc=paul.szczepanek@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).