From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F353943337; Wed, 15 Nov 2023 11:11:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E0CCF40633; Wed, 15 Nov 2023 11:11:25 +0100 (CET) Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by mails.dpdk.org (Postfix) with ESMTP id 0877340285 for <dev@dpdk.org>; Wed, 15 Nov 2023 11:11:25 +0100 (CET) Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-9d267605ceeso959386666b.2 for <dev@dpdk.org>; Wed, 15 Nov 2023 02:11:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1700043084; x=1700647884; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=NAWSh6MGx7o9jW2p615f/JcmuVoCkVesE4GJpMEEQt4=; b=cW0M1myEYExEUz4kvAI4NglWSaaYGiE3LUSSA9VCsies27rqSv5kQPqQA/hfl9xhm5 DaCv4U1madFGzjjbAlH6OddxxdVxiSncbi6XSRBFOBQ4/OViEycQz1VvqLaIXufsuJDk oben8Qr8hnLwyp9iFc1l+gVPtUFG3o/qgCoXcK3NjH0uhcZoDMslTDX67csMZ4ReJBHS IcW8egoDtR4DRVZdCwILItu6BQXuWz20/xY+e4plM0r/U+tNkXR7pGhr0BHePWdlXswq WzJYQlqeVeGfQYqfz1csAnpyEUBlQlMQyFO13GgNJzkSH1FhRmsEd4tiG4vyUpSin+Lc zbJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700043084; x=1700647884; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NAWSh6MGx7o9jW2p615f/JcmuVoCkVesE4GJpMEEQt4=; b=ETW9wLzscU4x0BGHSP0MFfuB+I+inIEHtvQW+3evmOYY5OStf1Qu+P7jQFkrHJ8i2g 1j82x3bE+HuCzpEZDWWBFCZmZ9z7LPKtDa4t63NCuONmcEs/djc6Wx4Bl2MgB4gGLuJd tCr46hKvfbcS6UA0isDvrOOtHPwinTITrbMcWSenRajzcFXvu6nbmvMyLxEAm5WsuOYF gq6AxwlVy2AaqVTTBtEFxN0lG7wkbQWZ7GyXJBjq6qM7vRK+aOpfRutOmApMhovF3u6z nF3q69rw0LmQ8+pOm1cE1epzEQIPV89A1f+6PrEvRetle7V7D0pDiw8fH1mkwT1mxXWI WnZg== X-Gm-Message-State: AOJu0YyoetmY+eAu8bOGQ+e248iah6JuyAkRHUAqZzoyoj0KwuePQB6k FpQOtlQU9lLOMHno2+My8wpkv35AMF9MTqVuZO/lGw== X-Google-Smtp-Source: AGHT+IEdMn1J7doBM1p1YDJPTUF7Q1iMTQtIh0m456U3vnBiya5gjofVOkPVFzFrXc4yNOwfpZrfMyiT5vn49B0V6Ok= X-Received: by 2002:a17:906:c41:b0:9b2:b2ad:2a76 with SMTP id t1-20020a1709060c4100b009b2b2ad2a76mr8519986ejf.16.1700043084711; Wed, 15 Nov 2023 02:11:24 -0800 (PST) MIME-Version: 1.0 References: <20231106171601.160749-1-juraj.linkes@pantheon.tech> <20231108125324.191005-1-juraj.linkes@pantheon.tech> <20231108125324.191005-6-juraj.linkes@pantheon.tech> <c27a679a-2137-4c74-a392-ed39038e4228@foss.arm.com> In-Reply-To: <c27a679a-2137-4c74-a392-ed39038e4228@foss.arm.com> From: =?UTF-8?Q?Juraj_Linke=C5=A1?= <juraj.linkes@pantheon.tech> Date: Wed, 15 Nov 2023 11:11:14 +0100 Message-ID: <CAOb5WZaCx6s+zZi+eW-1m3iD3KVg=a8X137xWj92oFSQ2rODow@mail.gmail.com> Subject: Re: [PATCH v6 06/23] dts: logger and settings docstring update To: Yoan Picchi <yoan.picchi@foss.arm.com> Cc: thomas@monjalon.net, Honnappa.Nagarahalli@arm.com, bruce.richardson@intel.com, jspewock@iol.unh.edu, probb@iol.unh.edu, paul.szczepanek@arm.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Wed, Nov 8, 2023 at 6:14=E2=80=AFPM Yoan Picchi <yoan.picchi@foss.arm.co= m> wrote: > > On 11/8/23 12:53, Juraj Linke=C5=A1 wrote: > > Format according to the Google format and PEP257, with slight > > deviations. > > > > Signed-off-by: Juraj Linke=C5=A1 <juraj.linkes@pantheon.tech> > > --- > > dts/framework/logger.py | 72 +++++++++++++++++++++---------- > > dts/framework/utils.py | 96 ++++++++++++++++++++++++++++++----------= - > > 2 files changed, 121 insertions(+), 47 deletions(-) > > <snip> > > diff --git a/dts/framework/utils.py b/dts/framework/utils.py > > index f0c916471c..0613adf7ad 100644 > > --- a/dts/framework/utils.py > > +++ b/dts/framework/utils.py <snip> > > @@ -93,35 +129,33 @@ class _TarCompressionFormat(StrEnum): > > and Enum values are the associated file extensions. > > """ > > > > + #: > > gzip =3D "gz" > > + #: > > compress =3D "Z" > > + #: > > bzip2 =3D "bz2" > > + #: > > lzip =3D "lz" > > + #: > > lzma =3D "lzma" > > + #: > > lzop =3D "lzo" > > + #: > > xz =3D "xz" > > + #: > > zstd =3D "zst" > > Just to be sure, _TarCompressionFormat doesn't appear in the doc > (framework.utils.html). I believe that's intended (because of the _) but > then I don't think the #: are used for anything. > Good point, I'll remove the comments as they're just clutter when not in doc generation.