DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Juraj Linkeš" <juraj.linkes@pantheon.tech>
To: Luca Vizzarro <luca.vizzarro@arm.com>
Cc: dev@dpdk.org, Jeremy Spewock <jspewock@iol.unh.edu>,
	 Paul Szczepanek <paul.szczepanek@arm.com>
Subject: Re: [PATCH 1/2] dts: update mypy static checker
Date: Mon, 13 May 2024 18:02:01 +0200	[thread overview]
Message-ID: <CAOb5WZaR0+Tj3uRVnxeA+OHMSotTWT4QNmsH_yiiMONepecUPg@mail.gmail.com> (raw)
In-Reply-To: <20240509105704.1162449-2-luca.vizzarro@arm.com>

> diff --git a/dts/framework/runner.py b/dts/framework/runner.py
> index db8e3ba96b..d74f1871db 100644
> --- a/dts/framework/runner.py
> +++ b/dts/framework/runner.py
> @@ -23,7 +23,7 @@
>  import re
>  import sys
>  from pathlib import Path
> -from types import MethodType
> +from types import FunctionType
>  from typing import Iterable, Sequence
>
>  from .config import (
> @@ -132,8 +132,8 @@ def run(self):
>          the :option:`--test-suite` command line argument or
>          the :envvar:`DTS_TESTCASES` environment variable.
>          """
> -        sut_nodes: dict[str, SutNode] = {}
> -        tg_nodes: dict[str, TGNode] = {}
> +        sut_nodes = {}
> +        tg_nodes = {}
>          try:
>              # check the python version of the server that runs dts
>              self._check_dts_python_version()
> @@ -305,7 +305,7 @@ def is_test_suite(object) -> bool:
>
>      def _filter_test_cases(
>          self, test_suite_class: type[TestSuite], test_cases_to_run: Sequence[str]
> -    ) -> tuple[list[MethodType], list[MethodType]]:
> +    ) -> tuple[list[FunctionType], list[FunctionType]]:

Does changing inspect.getmembers(test_suite_class, inspect.isfunction)
to use inspect.ismethod not work?

>          """Filter `test_cases_to_run` from `test_suite_class`.
>
>          There are two rounds of filtering if `test_cases_to_run` is not empty.

  reply	other threads:[~2024-05-13 16:03 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-09 10:57 [PATCH 0/2] dts: update mypy and clean up Luca Vizzarro
2024-05-09 10:57 ` [PATCH 1/2] dts: update mypy static checker Luca Vizzarro
2024-05-13 16:02   ` Juraj Linkeš [this message]
2024-05-14 11:30     ` Luca Vizzarro
2024-05-29 11:22       ` Juraj Linkeš
2024-05-09 10:57 ` [PATCH 2/2] dts: clean up config types Luca Vizzarro
2024-05-13 16:12   ` Juraj Linkeš
2024-05-14 11:30     ` Luca Vizzarro
2024-05-29 11:41   ` Juraj Linkeš
2024-05-14 11:34 ` [PATCH v2 0/2] dts: update mypy and clean up Luca Vizzarro
2024-05-14 11:34   ` [PATCH v2 1/2] dts: update mypy static checker Luca Vizzarro
2024-05-24 14:51     ` Patrick Robb
2024-05-28 12:00       ` Luca Vizzarro
2024-05-29 10:58         ` Juraj Linkeš
2024-05-29 11:39     ` Juraj Linkeš
2024-05-29 15:20       ` Luca Vizzarro
2024-05-14 11:34   ` [PATCH v2 2/2] dts: clean up config types Luca Vizzarro
2024-05-24 16:13     ` Patrick Robb
2024-05-20 15:37   ` [PATCH v2 0/2] dts: update mypy and clean up Nicholas Pratte
2024-05-21 14:59     ` Luca Vizzarro
2024-05-24 13:47       ` Nicholas Pratte
2024-05-24 16:17   ` Patrick Robb
2024-05-28 12:05     ` Luca Vizzarro
2024-05-29 10:44       ` Juraj Linkeš
2024-05-30 15:19 ` [PATCH v3 " Luca Vizzarro
2024-05-30 15:19   ` [PATCH v3 1/2] dts: update mypy static checker Luca Vizzarro
2024-05-30 20:23     ` Jeremy Spewock
2024-05-31  9:29     ` Juraj Linkeš
2024-05-30 15:19   ` [PATCH v3 2/2] dts: clean up config types Luca Vizzarro
2024-05-30 20:23     ` Jeremy Spewock
2024-05-31  9:29     ` Juraj Linkeš

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOb5WZaR0+Tj3uRVnxeA+OHMSotTWT4QNmsH_yiiMONepecUPg@mail.gmail.com \
    --to=juraj.linkes@pantheon.tech \
    --cc=dev@dpdk.org \
    --cc=jspewock@iol.unh.edu \
    --cc=luca.vizzarro@arm.com \
    --cc=paul.szczepanek@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).