From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3BCBC43E36; Wed, 10 Apr 2024 15:36:11 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F0DE140689; Wed, 10 Apr 2024 15:36:09 +0200 (CEST) Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) by mails.dpdk.org (Postfix) with ESMTP id CBD68402CF for ; Wed, 10 Apr 2024 15:36:07 +0200 (CEST) Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-56e1baf0380so7738461a12.3 for ; Wed, 10 Apr 2024 06:36:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1712756167; x=1713360967; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=lJ2evmIUVqvf8BepMBGZi8phN/X1MGH8F+eZnh0DZew=; b=BsfORErw873gJmdsmkZEMWQ+aZGNlXHbkoM3mNSBvmJh1ZzyaBEmJ1Sos083XaNxAX 9KvtwmSvP4xxY50fu5ruIHRvt/VQy9IaSrMkLixAQ44DQIJU4txBniwCavH1z+ZgBls5 hTZzOoj63TbXrDQJ2vvWvHpOSGPBerkVGQw90bh5F4CK6hegd6iMUtNama0KH5HMF6kq dNB8pAyfuhP2GH1FDrDtnlCWVXbjOI/Vmgn4dHjlwPBY1lXu0hwtQMq6d8+aLX3YU0QJ /opQ80AdToX13nCHpq8tLpUXkYn1bj7y5DFNEynq0rip8yEhD6yPilZSBOjCE804isMh P3Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712756167; x=1713360967; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lJ2evmIUVqvf8BepMBGZi8phN/X1MGH8F+eZnh0DZew=; b=ePNHwg2BTkVEbEEN34GLx3ftw76FCw3/97iHwAqKWOJXMPaJHOVL0SZuZwrEkMFj7/ POfw7I0wOEqATlA3OSvn/iSWgOp6wMy1t9xz5BIGM6pTG3sNYinXIUzIqZ2oPTJifcG2 r/ukMNWQJv4PsBaXGov5pJWg2egShuDXJNoIqezuY+mBbZptz6sSkb3GQevO6C8hPk6q O0MGYoXAl2PczqHO7DRIml8LcX3BGUWWM4Ts2UqaaEzVYEwvH9QV7PBEaJ7IRZ6y4T9h GHGosfNUdESyOeHEjHlwZ0lXSs/XAbkYxVXcU2GYR0r73emKPyuWR4EB4RFQtFJLG5TU HUug== X-Forwarded-Encrypted: i=1; AJvYcCXo3hXOWPR5+Zxmjw3PTWiCEWbca/7Aph/eT2Gt5psBkKAjHc+SIN/LXCCXyEsBTDWlI051p4tdzqGn7wQ= X-Gm-Message-State: AOJu0YzDT5PWgPVwN9eNHqXC2DpOTxkhIVsY7rSWYh7lz6oQw9qwvq+7 rHaCvxxfOVQARj73SJe72w32hzELNz493ao8Kcz3QGt6sGUDNBixFHNbVjwJc1CSnIE43lmnjxM Ex5f7//PDt7eTF5gM5sldnYqu0bmaK3XaDRZdTQ== X-Google-Smtp-Source: AGHT+IFIl4yoUxQBgMuBXGEvMBzZGAynVD4bE0+TOYyba2tQp+VajvHFpa2d8KMxpVLnF5UBF6xeWIR9Q+Noyl9H50Q= X-Received: by 2002:a17:906:184a:b0:a52:882:abaa with SMTP id w10-20020a170906184a00b00a520882abaamr1477968eje.76.1712756167311; Wed, 10 Apr 2024 06:36:07 -0700 (PDT) MIME-Version: 1.0 References: <20240326190422.577028-1-luca.vizzarro@arm.com> <20240326190422.577028-6-luca.vizzarro@arm.com> In-Reply-To: From: =?UTF-8?Q?Juraj_Linke=C5=A1?= Date: Wed, 10 Apr 2024 15:35:56 +0200 Message-ID: Subject: Re: [PATCH 5/6] dts: add statefulness to InteractiveShell To: Luca Vizzarro Cc: Jeremy Spewock , dev@dpdk.org, Jack Bond-Preston , Honnappa Nagarahalli Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Apr 10, 2024 at 1:27=E2=80=AFPM Luca Vizzarro wrote: > > On 10/04/2024 07:53, Juraj Linke=C5=A1 wrote: > > I have a general question. What are these changes for? Do you > > anticipate us needing this in the future? Wouldn't it be better to add > > it only when we need it? > > It's been sometime since we raised this task internally. This patch and > the next one arise from some survey done on old DTS test cases. > Unfortunately, I can't pinpoint. > > Specifically for this patch though, the timeout bit is useful in > conjunction with the related change in the next. Instead of giving an > optional timeout argument to all the commands where we may want to > change it, aren't we better off with providing a facility to temporarily > change this for the current scope? > This is a good question. If the scope is just one command, then no. If it's more than one, then maybe yes. I don't know which is better. We should also consider that this would introduce a difference in API between the interactive and non-interactive sessions. Do we want to do this there as well? Also, maybe set_timeout should be a property or we could just make _timeout public. And is_privileged should just be privileged, as it's a property (which shouldn't contain a verb; if it was a method it would be a good name). > > > > On Thu, Mar 28, 2024 at 5:48=E2=80=AFPM Jeremy Spewock wrote: > >> > >> On Tue, Mar 26, 2024 at 3:04=E2=80=AFPM Luca Vizzarro wrote: > >> > >>> diff --git a/dts/framework/remote_session/interactive_shell.py b/dts/= framework/remote_session/interactive_shell.py > >>> index a2c7b30d9f..5d80061e8d 100644 > >>> --- a/dts/framework/remote_session/interactive_shell.py > >>> +++ b/dts/framework/remote_session/interactive_shell.py > >>> @@ -41,8 +41,10 @@ class InteractiveShell(ABC): > >>> _stdout: channel.ChannelFile > >>> _ssh_channel: Channel > >>> _logger: DTSLogger > >>> + __default_timeout: float > >> > >> Only single underscores are used for other private variables, probably > >> better to keep that consistent with this one. > >> > > > > I agree, I don't see a reason for the double underscore. > > Ack. > > > > >>> _timeout: float > >>> _app_args: Params | None > >>> + _is_privileged: bool =3D False > >> > >>> 2.34.1 > >>> >