From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5DE5D44019; Mon, 13 May 2024 12:06:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F32AB402EB; Mon, 13 May 2024 12:06:33 +0200 (CEST) Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) by mails.dpdk.org (Postfix) with ESMTP id 4D3F84028A for ; Mon, 13 May 2024 12:06:32 +0200 (CEST) Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-a59a0e4b773so1007319966b.2 for ; Mon, 13 May 2024 03:06:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1715594792; x=1716199592; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=v3iMaUxKx1IFD3nJJZMlf6CP4vlc8ARw6tOabQnaD0Y=; b=A4+NrWR2QcV+ukHE4c0gFU/esFEYKdmq0t3iRZr7NTtRwHEihrL4IXjDoYeAOqNHLI 2ekZg1Y39kU6y6AEL5yYkvRljFFX+Nj5xExNrEn1YQyQsC+h0nXzc8ufTQf4sd4anGnv zsiKvxQOVJwrpFWT7XBwx1wO1V/AwNoblXZwK3f/eDLH+lJGwF6Z1oLBiRztPYuWzWsA WcgjNWYMM6cHB5CsLBXPkNPJTACfE0xMwjB4Qx9agqynB2SZKm9ByAOHMy/woLekqe6l fDowXsiwQj0cAybIazUEUDDSdGM8dLu379IaU9v+73lhgcCmKbuA6qKolPkeSiEuYz+8 9mHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715594792; x=1716199592; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v3iMaUxKx1IFD3nJJZMlf6CP4vlc8ARw6tOabQnaD0Y=; b=id3ZF0wSAnAuU7YluUW9kFsjpuPa0Dt/ANAUTtbNsnX0iYQUSuDgZg/pOdNj+jq4Q2 jxH70BxDj9fsw2Rk13DtTAzu9dTYhIn2KSIiXSfHskga0FHNCN0xq7mWE2G5zS23rgbk Lhrejt94YaMdEJYpy41Xn9ceS6ggVYGwKcG+lSXsjN6wPcxHXsn43OaewdIt4Z71WlRI WQq54tbjoy8I9wcFWzDOXqnzeKQ7RJoHwlpxHBNkXiDo94aylmTviLaHX+P6o9fE1XTI e6gfwbQbMOS3PRWbvubfRccFJcHo7a1HFexXzXdx9XBj0nui8k5TBhOIBw1eiUIc3aKH vqRQ== X-Forwarded-Encrypted: i=1; AJvYcCUr12FYFkQSqzQDOLJgeGeHJuKSwU3jJJRu4aQtOnQhvp3FOrX5dlv3o6cSbdjZ+hkYHPL7LGnHjADntC4= X-Gm-Message-State: AOJu0YxsAcpBIHivf+p/s4jBtO8IbIrGrttPIS2f+p7BsGo8B3DIR1rD 2Y1rESHNUSd7d+lUwOFrsWxAJ729tJtD6QBydhu31T+xJp6S9WP56vUXyJV4ehvLVCK50kqvpNv Uag/l3xQSwD99ZP+pU+mGoWA61ny6enasULtdIw== X-Google-Smtp-Source: AGHT+IHfGNzRs/Jwb1PbM8yaZfGlDNftKVkdTecIS+LhJ2ELkeafuU7zoqw7nEmR/ygF+tzQdtX0NtJbCoAiEK1VvqA= X-Received: by 2002:a17:907:7f09:b0:a59:b61f:b96d with SMTP id a640c23a62f3a-a5a2d53bc6amr701276566b.5.1715594791937; Mon, 13 May 2024 03:06:31 -0700 (PDT) MIME-Version: 1.0 References: <20240430184533.29247-2-npratte@iol.unh.edu> <20240430184533.29247-3-npratte@iol.unh.edu> In-Reply-To: From: =?UTF-8?Q?Juraj_Linke=C5=A1?= Date: Mon, 13 May 2024 12:06:21 +0200 Message-ID: Subject: Re: [PATCH v5 2/2] dts: Change hugepage 'amount' to a different term To: Bruce Richardson Cc: Luca Vizzarro , Nicholas Pratte , yoan.picchi@foss.arm.com, paul.szczepanek@arm.com, wathsala.vithanage@arm.com, thomas@monjalon.net, Honnappa.Nagarahalli@arm.com, probb@iol.unh.edu, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, May 7, 2024 at 3:00=E2=80=AFPM Bruce Richardson wrote: > > On Tue, May 07, 2024 at 01:43:30PM +0100, Luca Vizzarro wrote: > > On 07/05/2024 13:05, Bruce Richardson wrote: > > > Sorry to be late to the reviews here, but since this is a countable v= alue - > > > as you state in the cover letter- would "number" or "count" not be be= tter > > > terms. To me, "quantity" is just a synonym of "amount", and can be us= ed for > > > uncountable values too, e.g. "a quantity of water". > > > > > > Hi Bruce, > > > > The change is based on the readability and intuitiveness of the > > configuration file. In which case "number" could be ambiguous: > > > > hugepages_2mb: > > number: 100 > > > > And here I could see "count" working: > > > > hugepages_2mb: > > count: 100 > > We could use number_of: but that doesn't look great. Count looks fine. > > But since the change is propagated for consistency. "count" would no lo= nger > > be well fitting in the rest: > > > > "description": "The count of hugepages to configure. Hugepage > > size will be the system default." > > > Whatever term is actually used, the description should definitely refer t= o > "The number of hugepages to configure". This makes sense, let's use "number of" in descriptions. Ideally we'd also use number in code, but it's a bit ambiguous, such as her= e: def _configure_huge_pages(self, number: int, size: int, force_first_numa: bool) -> None: At a first glance it's not quite clear what "number" is here. "number_of" would be pretty clear, but so would be "count". But using count would mean we're using different words with the same meaning in the same context, which I'd also like to avoid - this is the reason why I was originally ok with quantity. Now I'm not sure what the best option is :-)