From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 592A7428BF; Mon, 3 Apr 2023 16:56:28 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3D41B40ED7; Mon, 3 Apr 2023 16:56:28 +0200 (CEST) Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) by mails.dpdk.org (Postfix) with ESMTP id 2F8F840A7E for ; Mon, 3 Apr 2023 16:56:27 +0200 (CEST) Received: by mail-ed1-f48.google.com with SMTP id b20so118494956edd.1 for ; Mon, 03 Apr 2023 07:56:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon-tech.20210112.gappssmtp.com; s=20210112; t=1680533787; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=U+9+LVfWekwq+ayfpYK2dCn7Y6eTOfpBf1jngG0ssms=; b=iNyGfUuXMaw0+TaQtdDG3Oe8HZ1avMjcoZVRaO+rbkrJEUDw71H6CyvNy4eagKBnCg G1YLSpYM5U3QQvj23eFeNT4/iECG9/drfTKZvHZX2u7N3FLAvWtgmQO9fL3l5wDiXgc+ cBX16co3vxqKEjK+qnCjNjuqUGndM9wa6bkf5NEiyDqyCxT1pPXQK7mQ75Z16dNefsgu lgILsvqoVKq3KCDJZrtI5Vki71QJ26RHNWVr/zPdswX66/dLcem7iG+bWe1Y3m/AxRi4 0NvzUnDQ4iA+vA3CXUo28282RrRHfwScWKdtaVGwZ7m8opXMxSS80tO/l2Oo7r/8a7/+ sK9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680533787; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=U+9+LVfWekwq+ayfpYK2dCn7Y6eTOfpBf1jngG0ssms=; b=WQPHxvlBiSzBUAw/jhRurV1L+nV3Mc6ScV6HfyNsfyJ6YCDbtLcM7Hpi59xmIr/q+j c//DXeFiC/9lBsW3TD+myxwaKNSFDS23yAbnNunfH3UIeOa1aELokvWNKjdVHOjc4Ftk QExD3Ts8PiznVEFqStD0zeEea0zUsW4xSyWfo9J0K6VZ7syb0IQPif4AVKLvfgP4Paft Cebr0/7KHxfMYVaum6iV5knssBWDTdDS9pltzFWBId/hs5gEkuRVk0ByHg89LlFuBwu4 hinvEbLcZEURhWXrh5SYOoR9QhAKnDQk3vihyP0tBL3xknJmGNbFtzplWYqACnaS4Zjh 4+Jw== X-Gm-Message-State: AAQBX9das3VwS8dCa8lp9OqdvJwSsnUpy8+r0Z8OADonPuPGJrRH+fhz xiCpYsVtzk6fe3+jnhnLfASx/KwZDh/sPpCG92gTng== X-Google-Smtp-Source: AKy350a64H6sD8kEVGOTVeQ5x18sX2v5x0HIGmx+wWbqciiduMaTfXh2/Dyry1GZvNiufyWfcdk5/KeMbPguFXmIe9k= X-Received: by 2002:a50:9e43:0:b0:502:4459:f2b8 with SMTP id z61-20020a509e43000000b005024459f2b8mr13002007ede.8.1680533786892; Mon, 03 Apr 2023 07:56:26 -0700 (PDT) MIME-Version: 1.0 References: <20230403114608.1423020-1-juraj.linkes@pantheon.tech> <5831673.1BCLMh4Saa@thomas> In-Reply-To: <5831673.1BCLMh4Saa@thomas> From: =?UTF-8?Q?Juraj_Linke=C5=A1?= Date: Mon, 3 Apr 2023 16:56:15 +0200 Message-ID: Subject: Re: [PATCH v1 1/2] dts: fabric requirements To: Thomas Monjalon Cc: wathsala.vithanage@arm.com, jspewock@iol.unh.edu, probb@iol.unh.edu, Honnappa.Nagarahalli@arm.com, lijuan.tu@intel.com, bruce.richardson@intel.com, dev@dpdk.org Content-Type: multipart/alternative; boundary="00000000000066ae6905f86fc36d" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --00000000000066ae6905f86fc36d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Apr 3, 2023 at 2:33=E2=80=AFPM Thomas Monjalon wrote: > 03/04/2023 13:46, Juraj Linke=C5=A1: > > Replace pexpect with Fabric. > > You should squash these lines with the move to Fabric. > > > Signed-off-by: Juraj Linke=C5=A1 > > --- > > dts/poetry.lock | 553 +++++++++++++++++++++++++++++++++++++++------ > > Do we really need *all* these lines? > I see a lot of lines about Windows and MacOSX which are not supported in > DTS. > It is so long that it looks impossible to review. > > This is a generated file and doesn't need to be reviewed. I separated the dependencies part so that the code part is easier to review. If you want, I can squash the two commits. --00000000000066ae6905f86fc36d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Mon, Apr 3, 2023 at 2:33=E2=80=AFP= M Thomas Monjalon <thomas@monjalo= n.net> wrote:
03/04/2023 13:46, Juraj Linke=C5=A1:
> Replace pexpect with Fabric.

You should squash these lines with the move to Fabric.

> Signed-off-by: Juraj Linke=C5=A1 <juraj.linkes@pantheon.tech> > ---
>=C2=A0 dts/poetry.lock=C2=A0 =C2=A0 | 553 +++++++++++++++++++++++++++++= ++++++++++------

Do we really need *all* these lines?
I see a lot of lines about Windows and MacOSX which are not supported in DT= S.
It is so long that it looks impossible to review.


This is a generated file and doesn'= ;t need to be reviewed. I separated the dependencies part so that the code = part is easier to review. If you want, I can squash the two commits.
--00000000000066ae6905f86fc36d--