From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2FF37438A1; Fri, 12 Jan 2024 11:23:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9EF004028C; Fri, 12 Jan 2024 11:23:37 +0100 (CET) Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by mails.dpdk.org (Postfix) with ESMTP id 96DC24026E for ; Fri, 12 Jan 2024 11:23:34 +0100 (CET) Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-557bfc7f7b4so8871488a12.0 for ; Fri, 12 Jan 2024 02:23:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1705055014; x=1705659814; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=VgFrLF5pNLwgzPvFFCfZZUyX5rnDiHMfKiZvgcMxIZc=; b=BZWRhpZ8rAiMrcsrSiRXmi1M/IdX0uugOALSOhCzSSNkJoCP51fmnHMvUVQqlY7lOk etB561snMHclvj2LcD0TeyVtGLMJ7DiwpLtlVXyKHVN9brnIURuCT7loZmLVFBy9ei9k i3trmkC5YdST/ayL6wur1qdGq+XHyqEg+sE6izAUm8J81zi+ObPEnC/xCHB05+T2PUKm BuDeIudsKTRFoqV9rkK8w+IAxkviuOaQqwNHGXKiih/QLTwqrxUKgAIK2L2h9h3N4TEM fZKV6muQO8z/YzqGurul8XDk/kXcBOunfa5mRHutG6EFn0A1j2lz3VYFx40luuJhwvSM S6zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705055014; x=1705659814; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VgFrLF5pNLwgzPvFFCfZZUyX5rnDiHMfKiZvgcMxIZc=; b=A2ewzjSujKEv/YKkr9csds1hmM/aMGUYxrTCNWafDr0/dn2KyPBeO/+yQMOWXG8M/9 JUusA7gaX1zyiWVTmdqIgJttJ4ulWVRRO91vrl4O8bWOu7rtA7m4mpi8FZe4DnWNFiVy NeYo3ut6EaQCERw5i6SP2Ehn4cF9fJE+srj3YGOohNgubAweUV7JmoewwaGBsaZbMdjb H5fLYSriCkV3n8pJ79Nz70Jp9Dk44VpnKw3IvALN4gsMZC/Xw5Wa7+8x5Nm378WbnjEd /PHN+MHevu7QNZR9evVkl3e719jPhlqvPpahVZuX30SCEK7L4xPp7Vv+PiSewraU3aff V3Uw== X-Gm-Message-State: AOJu0YxZbQAKDUd1X1LGLfL59DKm9RJKnJt/w9056AjLc3Uwe5DVwUrI icVq1HVkvNQ4XSHlRZ8Nqh7/mEIosxHTDxd0JQpsJCb7xNdFHXqETrncTHRc6Y8= X-Google-Smtp-Source: AGHT+IF+9/sHzJNlIdtrRWj57y/2LQGWz/0GuTsU6lvWYoZsH5rzRBC3kxjFm/VHjSiqDHxoNH74woSsa9WtcnZ//lA= X-Received: by 2002:a05:6402:1d9c:b0:558:252c:21fc with SMTP id dk28-20020a0564021d9c00b00558252c21fcmr1084167edb.43.1705055014284; Fri, 12 Jan 2024 02:23:34 -0800 (PST) MIME-Version: 1.0 References: <20240111213505.4577-2-jspewock@iol.unh.edu> <20240111222608.13239-1-jspewock@iol.unh.edu> In-Reply-To: <20240111222608.13239-1-jspewock@iol.unh.edu> From: =?UTF-8?Q?Juraj_Linke=C5=A1?= Date: Fri, 12 Jan 2024 11:23:23 +0100 Message-ID: Subject: Re: [PATCH v3] dts: add Dockerfile To: jspewock@iol.unh.edu Cc: Honnappa.Nagarahalli@arm.com, thomas@monjalon.net, wathsala.vithanage@arm.com, probb@iol.unh.edu, paul.szczepanek@arm.com, yoan.picchi@foss.arm.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > diff --git a/dts/.devcontainer/devcontainer.json b/dts/.devcontainer/devcontainer.json > new file mode 100644 > index 0000000000..6313cd3ded > --- /dev/null > +++ b/dts/.devcontainer/devcontainer.json > @@ -0,0 +1,33 @@ > +// For format details, see https://aka.ms/devcontainer.json. For config options, see the README at: > +// https://github.com/microsoft/vscode-dev-containers/tree/v0.241.1/containers/docker-existing-dockerfile > +{ > + "name": "Existing Dockerfile", > + > + // Sets the run context to one level up instead of the .devcontainer folder. > + "context": "..", > + > + // Update the 'dockerFile' property if you aren't using the standard 'Dockerfile' filename. > + "dockerFile": "../Dockerfile", > + > + // Use 'forwardPorts' to make a list of ports inside the container available locally. > + // "forwardPorts": [], > + > + // Uncomment the next line to run commands after the container is created - for example installing curl. The next line is uncommented, we should update or remove the comment. > + "postCreateCommand": "poetry install --no-root", > + > + "extensions": [ > + "ms-python.vscode-pylance", > + ] > + > + // Uncomment when using a ptrace-based debugger like C++, Go, and Rust > + // "runArgs": [ "--cap-add=SYS_PTRACE", "--security-opt", "seccomp=unconfined" ], > + > + // Uncomment to use the Docker CLI from inside the container. See https://aka.ms/vscode-remote/samples/docker-from-docker. > + // "mounts": [ "source=/var/run/docker.sock,target=/var/run/docker.sock,type=bind" ], > + > + // Uncomment to mount your SSH keys into the devcontainer used by vscode. > + // "mounts": ["source=${localEnv:HOME}/.ssh,destination=/root/.ssh,type=bind,readonly"] Should this SSH key correspond to the user below? > + > + // Uncomment to connect as a non-root user if you've added one. See https://aka.ms/vscode-remote/containers/non-root. > + // "remoteUser": "vscode" > +} > diff --git a/dts/README.md b/dts/README.md > new file mode 100644 > index 0000000000..dc88ec585e > --- /dev/null > +++ b/dts/README.md > @@ -0,0 +1,70 @@ > +#### Start docker container with SSH keys > + > +```shell > +docker build --target dev -t dpdk-dts . > +docker run -v $(pwd)/..:/dpdk -v /home/dtsuser/.ssh:/root/.ssh:ro -it dpdk-dts bash We talked about possibly baking the key into the image, but this seems safer and pretty easy to use. I understand this is tailored to the lab and I'm thinking about other possible use cases, but it seems there would only be convoluted ones (possibly with some extra security considerations, which is generally not needed for testing purposes) where this doesn't do what we want it to. I'd say this is good enough. > +$ poetry install > +$ poetry shell > +``` > +