From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 21FA744018; Mon, 13 May 2024 11:53:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B30BE402EC; Mon, 13 May 2024 11:53:35 +0200 (CEST) Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by mails.dpdk.org (Postfix) with ESMTP id 83EB94028A for ; Mon, 13 May 2024 11:53:33 +0200 (CEST) Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-a59a0168c75so1064639966b.1 for ; Mon, 13 May 2024 02:53:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1715594013; x=1716198813; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=zyK3ledTmy/r3wryOEw+MdzGq9ZNmnftZUeA4HqdOCs=; b=PAMVYF3vctgUnd3FRBpqLp4/RUJNoJxSKHt3YJgAaxJHrsBl1cnYQrNgoK89UgxMFO xOJSksHawWFfAJvCiMuh79V9Xxnh9QcGfkGKHW7+ISc492AuEiwPIKzeWR3M556Fu0rj q1kwjRqO+YiX+eCLvpxfjdq1Azf9Fff6xi7bIS/I79jorBsvz0B9LfSxiNvvYpW/Yzcu wEn0Wb3g2Og4Pb4THu1bzMhWkkEhb27WGPc6qAN0KO2QCZqa5ttBTY7DM0PhXMMe3LS6 ihqQJIdsSqPb8UujedIeWNqwNFGOl8Z3Tp8ksYOqxhA6I8d+hqEcS5NrFhC5vJ5ACNm2 rJVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715594013; x=1716198813; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zyK3ledTmy/r3wryOEw+MdzGq9ZNmnftZUeA4HqdOCs=; b=WMzHre9FbjUQMXjC0XlWGMKqcj/Ijh9iPyzRm2TCuM5J7mziiGi5OYXh0++RQ4+NCG VgPyEMFQNheeLRFu0l41DnVOSocnlvfV2xIMq8gCeZygAzS4OOj1a1p4bthKeD4OzRDv ksa777KSgJ79/fDYtkD9qAgqPcYZAsW1pmwVG89m7/2Aouft5E8tKLFxKikFqCCZmIOf 9QfVENRrnvHS2YhgGO245tlgI/wiOJpZgHRhuqKBPSLHQC6yK8NjFu8q7FmrXrNMT459 uUsN160AWilDve/yCdqxwMt3mmdDdqWY4HNL48qMP0PvWF7TOScdG7PnDpI5UT0s/jsJ lZgA== X-Forwarded-Encrypted: i=1; AJvYcCUSrBz8J55nuVrVrkANfRANnIYIhX395NGP7y2aTFt2vFUz8YOmg9+UsMJiNP6D3Lqcm5oud5E7PUpcrbA= X-Gm-Message-State: AOJu0YzhWCbzCQ+WWDzyYVbgUknABiEhb0HCzVwzIn9eKpsShT8OaHZZ a4rkl/FUfWiIqmJshqyQ06xKiffN14HvdTNtQF/os7mT3jCTDxVtKyzI0vBqN1C5ioPatunew+K 4CoeFf9oBGShWtdzP9WA3xYS1+eqwV+EMbpKWWw== X-Google-Smtp-Source: AGHT+IGO1n7mEYNoSykoWjIhtvyjcqKe+7r1K0OB3DcstbBguvuyPGOtDVNN+2MX/NDbIOnZU51Qz/Cy+VfFCdU+nqc= X-Received: by 2002:a17:906:459:b0:a59:db0f:6bd7 with SMTP id a640c23a62f3a-a5a2d6763efmr584547266b.71.1715594013218; Mon, 13 May 2024 02:53:33 -0700 (PDT) MIME-Version: 1.0 References: <20240430184533.29247-4-npratte@iol.unh.edu> <20240507174430.29403-1-npratte@iol.unh.edu> In-Reply-To: <20240507174430.29403-1-npratte@iol.unh.edu> From: =?UTF-8?Q?Juraj_Linke=C5=A1?= Date: Mon, 13 May 2024 11:53:22 +0200 Message-ID: Subject: Re: [PATCH v6 0/2] Methodology change for hugepage configuration To: Nicholas Pratte Cc: probb@iol.unh.edu, bruce.richardson@intel.com, Honnappa.Nagarahalli@arm.com, thomas@monjalon.net, jspewock@iol.unh.edu, yoan.picchi@foss.arm.com, mb@smartsharesystems.com, wathsala.vithanage@arm.com, paul.szczepanek@arm.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org What's the difference between this version and v4? On Tue, May 7, 2024 at 7:44=E2=80=AFPM Nicholas Pratte wrote: > > In order to prevent accidental misconfiguration of hugepages at runtime, > the following changes are made to only allow for configuration of 2MB > hugepages within the DTS config.yaml. In the previous implementation, a > default hugepage size was selected via the size listed in /proc/meminfo. > The problem with this implementation is that, assuming the end-user has > made prior modifications to the system, /proc/meminfo may default to > hugepage sizes that are not recommended to be configured at runtime > (i.e. 1GB hugepages). This can lead to two problems: overallocation of > hugepages (which may crash the remote host) configuration of hugepages > sizes that are not recommended during runtime. In this new implementation= , > we stipulate that any runtime hugepage configuration size that is not 2MB > is considered an outlier. If the end-user would like to configure either > 1GB hugepages or any unique hugepage size outside of 2MB, then they shoul= d > make these configurations either at startup (in the case of 1GB hugepages= ) > or runtime outside of DTS configuration (if a user would like hugepages > that are not 2MB). In either case, the expectation is that, if wish to > use hugepage sizes that are not 2MB, you will make these changes outside > and prior to the initialization of DTS. > > The end-user has two options: remove the option for hugepage > configuration in the conf.yaml, or keep the option and specify the > amount of 2MB hugepages desired. In the case of the former, then we assum= e > that hugepages are already configured prior to DTS initialization. In > the latter case, the user must define the amount of 2MB hugepages to be > configured at runtime. If the amount of 2MB hugepages requested exceeds > the amount of 2MB hugepages already configured on the system, then the > system will remount hugepages to cover the difference. If the amount of > hugepages requested is either greater than or equal to the amount > already configured on the system, then nothing is done. > > Nicholas Pratte (2): > dts: Change hugepage runtime config to 2MB Exclusively > dts: Change hugepage 'amount' to a different term > > doc/guides/tools/dts.rst | 6 ++++- > dts/conf.yaml | 8 +++--- > dts/framework/config/__init__.py | 8 +++--- > dts/framework/config/conf_yaml_schema.json | 12 ++++----- > dts/framework/config/types.py | 4 +-- > dts/framework/testbed_model/linux_session.py | 28 +++++++++++--------- > dts/framework/testbed_model/node.py | 4 ++- > dts/framework/testbed_model/os_session.py | 7 ++++- > 8 files changed, 45 insertions(+), 32 deletions(-) > > -- > 2.44.0 >